You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by fatty1380 <gi...@git.apache.org> on 2015/09/02 23:00:02 UTC
[GitHub] cordova-ios pull request: Prevent Compilation Warning : Conflictin...
GitHub user fatty1380 opened a pull request:
https://github.com/apache/cordova-ios/pull/157
Prevent Compilation Warning : Conflicting Return Type
The `supportedInterfaceOrientationsForWindow` method currently returns a value of type `NSUInteger`. This causes a warning in the Xcode console:
> Conflicting return type in implementation of 'application:supportedInterfaceOrientationsForWindow:': 'UIInterfaceOrientationMask' (aka 'enum UIInterfaceOrientationMask') vs 'NSUInteger' (aka 'unsigned long')
This change updates the return type to be `UIInterfaceOrientationMask` rather than `NSUInteger` to avoid the warning
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/fatty1380/cordova-ios patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-ios/pull/157.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #157
----
commit cfe9ad7ef646d974abcf93e56b6ee27bab589435
Author: Patrick Fowler <pf...@cs.stanford.edu>
Date: 2015-09-02T20:59:55Z
Prevent Compilation Warning : Conflicting Return Type
The `supportedInterfaceOrientationsForWindow` method currently returns a value of type `NSUInteger`. This causes a warning in the Xcode console:
> Conflicting return type in implementation of 'application:supportedInterfaceOrientationsForWindow:': 'UIInterfaceOrientationMask' (aka 'enum UIInterfaceOrientationMask') vs 'NSUInteger' (aka 'unsigned long')
This change updates the return type to be `UIInterfaceOrientationMask` rather than `NSUInteger` to avoid the warning
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request: CB-9610 Prevent Compilation Warning : Co...
Posted by fatty1380 <gi...@git.apache.org>.
Github user fatty1380 closed the pull request at:
https://github.com/apache/cordova-ios/pull/157
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request: Prevent Compilation Warning : Conflictin...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-ios/pull/157#issuecomment-137696927
Hi can you add a prefix of "CB-9610" to the title to enable Apache's JIRA issue tracker auto-magic linking?
https://issues.apache.org/jira/browse/CB-9610
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request: CB-9610 Prevent Compilation Warning : Co...
Posted by macdonst <gi...@git.apache.org>.
Github user macdonst commented on the pull request:
https://github.com/apache/cordova-ios/pull/157#issuecomment-138648374
I'm working on merging this PR now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request: CB-9610 Prevent Compilation Warning : Co...
Posted by jcesarmobile <gi...@git.apache.org>.
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-ios/pull/157#issuecomment-138280386
shouldn't the ```- (NSUInteger)application:(UIApplication*)application supportedInterfaceOrientationsForWindow:(UIWindow*)window``` still be needed for iOS 8 and previous?
why not something like this?
```
#if __IPHONE_OS_VERSION_MAX_ALLOWED < 90000
- (NSUInteger)application:(UIApplication*)application supportedInterfaceOrientationsForWindow:(UIWindow*)window
#else
- (UIInterfaceOrientationMask)application:(UIApplication*)application supportedInterfaceOrientationsForWindow:(UIWindow*)window
#endif
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request: CB-9610 Prevent Compilation Warning : Co...
Posted by macdonst <gi...@git.apache.org>.
Github user macdonst commented on the pull request:
https://github.com/apache/cordova-ios/pull/157#issuecomment-138657802
@fatty1380 please close this PR when you get a chance.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request: CB-9610 Prevent Compilation Warning : Co...
Posted by macdonst <gi...@git.apache.org>.
Github user macdonst commented on the pull request:
https://github.com/apache/cordova-ios/pull/157#issuecomment-138655645
I committed a fix for this so this PR can be closed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request: CB-9610 Prevent Compilation Warning : Co...
Posted by fatty1380 <gi...@git.apache.org>.
Github user fatty1380 commented on the pull request:
https://github.com/apache/cordova-ios/pull/157#issuecomment-137835079
Done! Let me know if I can tweak in any way
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org