You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Andrew Purtell (JIRA)" <ji...@apache.org> on 2016/06/16 06:27:05 UTC

[jira] [Commented] (HBASE-15816) Provide client with ability to set priority on Operations

    [ https://issues.apache.org/jira/browse/HBASE-15816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15333203#comment-15333203 ] 

Andrew Purtell commented on HBASE-15816:
----------------------------------------

[~churromorales] still interested in carrying this forward? I haven't heard much about this for a while. Is that because the problem to solve has been handled a different way or simply because I haven't been around much.

I looked at the v1 patch, it's fine, but...

bq.  I'll create another patch for removing the annotation driven priorities

This does make the reading of this patch "interesting", like the double setting of priority in HTable call implementations. Did you try this and indeed end up with a monster patch? 

When removing annotation driven priorities we'll want unit tests that confirm where we're expecting QoS != NORMAL_QOS, the patch doesn't change behavior

I think it's fine to submit and review this as a sequence of patches but what should be committed is a single patch that addresses all relevant issues.

> Provide client with ability to set priority on Operations 
> ----------------------------------------------------------
>
>                 Key: HBASE-15816
>                 URL: https://issues.apache.org/jira/browse/HBASE-15816
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 2.0.0
>            Reporter: churro morales
>            Assignee: churro morales
>         Attachments: HBASE-15816-v1.patch, HBASE-15816.patch
>
>
> First round will just be to expose the ability to set priorities for client operations.  For more background: http://mail-archives.apache.org/mod_mbox/hbase-dev/201604.mbox/%3CCA+RK=_BG_o=q8HMptcP2WauAinmEsL+15f3YEJuz=qbpcya5-g@mail.gmail.com%3E
> Next step would be to remove AnnotationReadingPriorityFunction and have the client send priorities explicitly.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)