You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2018/12/04 23:50:17 UTC

[GitHub] janpio commented on issue #363: (iOS & Android) add request headers support

janpio commented on issue #363: (iOS & Android) add request headers support
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/363#issuecomment-444304008
 
 
   Something is broken with the formatting:
   
   ```
   npm run eslint
   > cordova-plugin-inappbrowser@3.1.0-dev eslint /home/travis/build/apache/cordova-plugin-inappbrowser
   > node node_modules/eslint/bin/eslint www && node node_modules/eslint/bin/eslint src && node node_modules/eslint/bin/eslint tests
   /home/travis/build/apache/cordova-plugin-inappbrowser/www/inappbrowser.js
     118:1    error  Expected indentation of 8 spaces but found 2 tabs                             indent
     118:2    error  Unexpected tab character                                                      no-tabs
     118:29   error  Trailing spaces not allowed                                                   no-trailing-spaces
     119:1    error  Expected indentation of 8 spaces but found 2 tabs                             indent
     119:2    error  Unexpected tab character                                                      no-tabs
     120:1    error  Expected indentation of 12 spaces but found 3 tabs                            indent
     120:2    error  Unexpected tab character                                                      no-tabs
     121:1    error  Expected indentation of 16 spaces but found 4 tabs                            indent
     121:2    error  Unexpected tab character                                                      no-tabs
     121:51   error  A space is required after ','                                                 comma-spacing
     122:1    error  Expected indentation of 12 spaces but found 3 tabs                            indent
     122:2    error  Unexpected tab character                                                      no-tabs
     122:4    error  Closing curly brace does not appear on the same line as the subsequent block  brace-style
     123:1    error  Expected indentation of 12 spaces but found 3 tabs                            indent
     123:2    error  Unexpected tab character                                                      no-tabs
     124:1    error  Expected indentation of 16 spaces but found 4 tabs                            indent
     124:2    error  Unexpected tab character                                                      no-tabs
     124:22   error  Trailing spaces not allowed                                                   no-trailing-spaces
     125:1    error  Expected indentation of 16 spaces but found 4 tabs                            indent
     125:2    error  Unexpected tab character                                                      no-tabs
     126:1    error  Expected indentation of 20 spaces but found 5 tabs                            indent
     126:2    error  Unexpected tab character                                                      no-tabs
     127:1    error  Expected indentation of 24 spaces but found 6 tabs                            indent
     127:2    error  Unexpected tab character                                                      no-tabs
     127:32   error  A space is required after ','                                                 comma-spacing
     127:52   error  A space is required after ','                                                 comma-spacing
     127:72   error  A space is required after ','                                                 comma-spacing
     128:1    error  Expected indentation of 24 spaces but found 6 tabs                            indent
     128:2    error  Unexpected tab character                                                      no-tabs
     128:60   error  A space is required after ','                                                 comma-spacing
     128:80   error  A space is required after ','                                                 comma-spacing
     128:100  error  A space is required after ','                                                 comma-spacing
     129:1    error  Expected indentation of 24 spaces but found 6 tabs                            indent
     129:2    error  Unexpected tab character                                                      no-tabs
     130:1    error  Expected indentation of 28 spaces but found 7 tabs                            indent
     130:2    error  Unexpected tab character                                                      no-tabs
     131:1    error  Expected indentation of 24 spaces but found 6 tabs                            indent
     131:2    error  Unexpected tab character                                                      no-tabs
     131:15   error  Multiple spaces found before '{'                                              no-multi-spaces
     132:1    error  Expected indentation of 28 spaces but found 7 tabs                            indent
     132:2    error  Unexpected tab character                                                      no-tabs
     132:28   error  Strings must use singlequote                                                  quotes
     133:1    error  Expected indentation of 24 spaces but found 6 tabs                            indent
     133:2    error  Unexpected tab character                                                      no-tabs
     134:1    error  Expected indentation of 24 spaces but found 6 tabs                            indent
     134:2    error  Unexpected tab character                                                      no-tabs
     134:33   error  Strings must use singlequote                                                  quotes
     134:45   error  Trailing spaces not allowed                                                   no-trailing-spaces
     135:1    error  Expected indentation of 20 spaces but found 5 tabs                            indent
     135:2    error  Unexpected tab character                                                      no-tabs
     136:1    error  Expected indentation of 16 spaces but found 4 tabs                            indent
     136:2    error  Unexpected tab character                                                      no-tabs
     137:1    error  Expected indentation of 12 spaces but found 3 tabs                            indent
     137:2    error  Unexpected tab character                                                      no-tabs
     138:1    error  Expected indentation of 8 spaces but found 2 tabs                             indent
     138:2    error  Unexpected tab character                                                      no-tabs
   ✖ 56 problems (56 errors, 0 warnings)
     35 errors, 0 warnings potentially fixable with the `--fix` option.
   ```
   
   Note the last line, use `npm run eslint --fix` to fix most of those, then run `npm run eslint` again and fix manually. Then commit and push the result.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org