You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ariatosca.apache.org by mxmrlv <gi...@git.apache.org> on 2017/03/05 17:18:55 UTC

[GitHub] incubator-ariatosca pull request #74: ARIA-115-Log-model-should-have-an-Exec...

GitHub user mxmrlv opened a pull request:

    https://github.com/apache/incubator-ariatosca/pull/74

    ARIA-115-Log-model-should-have-an-Execution-field

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/incubator-ariatosca ARIA-115-Log-model-should-have-an-Execution-field

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-ariatosca/pull/74.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #74
    
----
commit 33ff844cdefe2e26744c03b452916f8f834eee2a
Author: max-orlov <ma...@gigaspaces.com>
Date:   2017-03-05T17:18:21Z

    ARIA-115-Log-model-should-have-an-Execution-field

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-ariatosca pull request #74: ARIA-115-Log-model-should-have-an-Exec...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-ariatosca/pull/74


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-ariatosca pull request #74: ARIA-115-Log-model-should-have-an-Exec...

Posted by ran-z <gi...@git.apache.org>.
Github user ran-z commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/74#discussion_r104373752
  
    --- Diff: aria/storage/modeling/orchestrator_elements.py ---
    @@ -471,6 +471,14 @@ def retry(message=None, retry_interval=None):
     class LogBase(ModelMixin):
         __tablename__ = 'log'
     
    +    @declared_attr
    +    def execution_fk(cls):
    +        return cls.foreign_key('execution', nullable=True)
    --- End diff --
    
    nullable should be False


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---