You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by Ryan McKinley <ry...@gmail.com> on 2007/02/22 07:58:34 UTC

is trunk compiling?

I have a clean trunk, and get a bunch of HIGHLIGHT errors:

$ ant compile
Buildfile: build.xml

checkJunitPresence:

compile:
    [mkdir] Created dir: C:\workspace\TTT\build
    [javac] Compiling 171 source files to C:\workspace\TTT\build
    [javac] C:\workspace\TTT\src\java\org\apache\solr\util\CommonParams.java:144:
cannot find symbol
    [javac] symbol  : variable HIGHLIGHT
    [javac] location: class org.apache.solr.request.SolrParams
    [javac]     tmp = args.get(SolrParams.HIGHLIGHT);
    [javac]                              ^
    [javac] C:\workspace\TTT\src\java\org\apache\solr\util\CommonParams.java:151:
cannot find symbol
    [javac] symbol  : variable HIGHLIGHT
    [javac] location: class org.apache.solr.request.SolrParams
    [javac]         SolrCore.log.severe("init param is not a str: " +
SolrParams.HIGHLIGHT);
    [javac]
         ^
    [javac] C:\workspace\TTT\src\java\org\apache\solr\util\CommonParams.java:155:
cannot find symbol
    [javac] symbol  : variable HIGHLIGHT_FIELDS
    [javac] location: class org.apache.solr.request.SolrParams
    [javac]     tmp = args.get(SolrParams.HIGHLIGHT_FIELDS);
    [javac]                              ^
    [javac] C:\workspace\TTT\src\java\org\apache\solr\util\CommonParams.java:160:
cannot find symbol
    [javac] symbol  : variable HIGHLIGHT
    [javac] location: class org.apache.solr.request.SolrParams
    [javac]         SolrCore.log.severe("init param is not a str: " +
SolrParams.HIGHLIGHT);
    [javac]
         ^
    [javac] C:\workspace\TTT\src\java\org\apache\solr\util\CommonParams.java:164:
cannot find symbol
    [javac] symbol  : variable MAX_SNIPPETS
    [javac] location: class org.apache.solr.request.SolrParams
    [javac]     tmp = args.get(SolrParams.MAX_SNIPPETS);
    [javac]                              ^
    [javac] C:\workspace\TTT\src\java\org\apache\solr\util\CommonParams.java:169:
cannot find symbol
    [javac] symbol  : variable MAX_SNIPPETS
    [javac] location: class org.apache.solr.request.SolrParams
    [javac]         SolrCore.log.severe("init param is not an int: " +
SolrParams.MAX_SNIPPETS);
    [javac]
          ^
    [javac] C:\workspace\TTT\src\java\org\apache\solr\util\CommonParams.java:173:
cannot find symbol
    [javac] symbol  : variable HIGHLIGHT_FORMATTER_CLASS
    [javac] location: class org.apache.solr.request.SolrParams
    [javac]     tmp = args.get(SolrParams.HIGHLIGHT_FORMATTER_CLASS);
    [javac]                              ^
    [javac] C:\workspace\TTT\src\java\org\apache\solr\util\CommonParams.java:178:
cannot find symbol
    [javac] symbol  : variable HIGHLIGHT_FORMATTER_CLASS
    [javac] location: class org.apache.solr.request.SolrParams
    [javac]         SolrCore.log.severe("init param is not a str: " +
SolrParams.HIGHLIGHT_FORMATTER_CLASS);
    [javac]
         ^
    [javac] Note: Some input files use or override a deprecated API.
    [javac] Note: Recompile with -Xlint:deprecation for details.
    [javac] Note: Some input files use unchecked or unsafe operations.
    [javac] Note: Recompile with -Xlint:unchecked for details.
    [javac] 8 errors

BUILD FAILED

Re: is trunk compiling?

Posted by Ryan McKinley <ry...@gmail.com>.
>
> > Sigh, sorry about that.  ant test is not ant clean test.  Will fix presently.
>
> Done.
>
> Anyone think that we should continue maintaing CommonParams?  It is
> never instantiated.  It is possible that it is being used by a custom
> request handler out there, somewhere.
>

thanks!

I'm voting for restructuring stuff so we can have external shared
libraries (SOLR-135)

maybe CommonParams should become an interface with most of the the
"public static final String" constants from SolrParams defined there
and SolrParams could implement CommonParams.  This would keep
backwards compatibility.

I think the logic part of CommonParams should go away.

Re: is trunk compiling?

Posted by Mike Klaas <mi...@gmail.com>.
On 2/21/07, Mike Klaas <mi...@gmail.com> wrote:

> Sigh, sorry about that.  ant test is not ant clean test.  Will fix presently.

Done.

Anyone think that we should continue maintaing CommonParams?  It is
never instantiated.  It is possible that it is being used by a custom
request handler out there, somewhere.

-Mike

Re: is trunk compiling?

Posted by Mike Klaas <mi...@gmail.com>.
On 2/21/07, Ryan McKinley <ry...@gmail.com> wrote:
> I have a clean trunk, and get a bunch of HIGHLIGHT errors:
>
> $ ant compile
> Buildfile: build.xml
>
> checkJunitPresence:

Sigh, sorry about that.  ant test is not ant clean test.  Will fix presently.

-Mike