You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Ning Li (JIRA)" <ji...@apache.org> on 2007/08/15 17:19:32 UTC
[jira] Created: (LUCENE-978) GC resources in TermInfosReader when
exception occurs in its constructor
GC resources in TermInfosReader when exception occurs in its constructor
------------------------------------------------------------------------
Key: LUCENE-978
URL: https://issues.apache.org/jira/browse/LUCENE-978
Project: Lucene - Java
Issue Type: Bug
Components: Index
Reporter: Ning Li
Priority: Minor
Attachments: TermInfosReader.patch
I replaced IndexModifier with IndexWriter in test case TestStressIndexing and noticed the test failed from time to time because some .tis file is still open when MockRAMDirectory.close() is called. It turns out it is because .tis file is not closed if an exception occurs in TermInfosReader's constructor.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Resolved: (LUCENE-978) GC resources in TermInfosReader when
exception occurs in its constructor
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael McCandless resolved LUCENE-978.
---------------------------------------
Resolution: Fixed
Fix Version/s: 2.3
I just committed this.
> GC resources in TermInfosReader when exception occurs in its constructor
> ------------------------------------------------------------------------
>
> Key: LUCENE-978
> URL: https://issues.apache.org/jira/browse/LUCENE-978
> Project: Lucene - Java
> Issue Type: Bug
> Components: Index
> Reporter: Ning Li
> Assignee: Michael McCandless
> Priority: Minor
> Fix For: 2.3
>
> Attachments: Readers.patch, TermInfosReader.patch
>
>
> I replaced IndexModifier with IndexWriter in test case TestStressIndexing and noticed the test failed from time to time because some .tis file is still open when MockRAMDirectory.close() is called. It turns out it is because .tis file is not closed if an exception occurs in TermInfosReader's constructor.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-978) GC resources in TermInfosReader when
exception occurs in its constructor
Posted by "Ning Li (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ning Li updated LUCENE-978:
---------------------------
Lucene Fields: [Patch Available] (was: [New])
> GC resources in TermInfosReader when exception occurs in its constructor
> ------------------------------------------------------------------------
>
> Key: LUCENE-978
> URL: https://issues.apache.org/jira/browse/LUCENE-978
> Project: Lucene - Java
> Issue Type: Bug
> Components: Index
> Reporter: Ning Li
> Priority: Minor
> Attachments: TermInfosReader.patch
>
>
> I replaced IndexModifier with IndexWriter in test case TestStressIndexing and noticed the test failed from time to time because some .tis file is still open when MockRAMDirectory.close() is called. It turns out it is because .tis file is not closed if an exception occurs in TermInfosReader's constructor.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-978) GC resources in TermInfosReader when
exception occurs in its constructor
Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12520269 ]
Yonik Seeley commented on LUCENE-978:
-------------------------------------
Nice catch! fix looks good to me.
> GC resources in TermInfosReader when exception occurs in its constructor
> ------------------------------------------------------------------------
>
> Key: LUCENE-978
> URL: https://issues.apache.org/jira/browse/LUCENE-978
> Project: Lucene - Java
> Issue Type: Bug
> Components: Index
> Reporter: Ning Li
> Priority: Minor
> Attachments: TermInfosReader.patch
>
>
> I replaced IndexModifier with IndexWriter in test case TestStressIndexing and noticed the test failed from time to time because some .tis file is still open when MockRAMDirectory.close() is called. It turns out it is because .tis file is not closed if an exception occurs in TermInfosReader's constructor.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-978) GC resources in TermInfosReader when
exception occurs in its constructor
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12520835 ]
Michael McCandless commented on LUCENE-978:
-------------------------------------------
This looks good Ning, thanks! I will commit...
> GC resources in TermInfosReader when exception occurs in its constructor
> ------------------------------------------------------------------------
>
> Key: LUCENE-978
> URL: https://issues.apache.org/jira/browse/LUCENE-978
> Project: Lucene - Java
> Issue Type: Bug
> Components: Index
> Reporter: Ning Li
> Priority: Minor
> Attachments: Readers.patch, TermInfosReader.patch
>
>
> I replaced IndexModifier with IndexWriter in test case TestStressIndexing and noticed the test failed from time to time because some .tis file is still open when MockRAMDirectory.close() is called. It turns out it is because .tis file is not closed if an exception occurs in TermInfosReader's constructor.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-978) GC resources in TermInfosReader when
exception occurs in its constructor
Posted by "Ning Li (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12520286 ]
Ning Li commented on LUCENE-978:
--------------------------------
> Agreed. Actually, it also looks like we need to do something similar for FieldsReader/TermVectorsReader too?
That's right. I'll submit a new patch.
> GC resources in TermInfosReader when exception occurs in its constructor
> ------------------------------------------------------------------------
>
> Key: LUCENE-978
> URL: https://issues.apache.org/jira/browse/LUCENE-978
> Project: Lucene - Java
> Issue Type: Bug
> Components: Index
> Reporter: Ning Li
> Priority: Minor
> Attachments: TermInfosReader.patch
>
>
> I replaced IndexModifier with IndexWriter in test case TestStressIndexing and noticed the test failed from time to time because some .tis file is still open when MockRAMDirectory.close() is called. It turns out it is because .tis file is not closed if an exception occurs in TermInfosReader's constructor.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-978) GC resources in TermInfosReader when
exception occurs in its constructor
Posted by "Ning Li (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ning Li updated LUCENE-978:
---------------------------
Attachment: TermInfosReader.patch
> GC resources in TermInfosReader when exception occurs in its constructor
> ------------------------------------------------------------------------
>
> Key: LUCENE-978
> URL: https://issues.apache.org/jira/browse/LUCENE-978
> Project: Lucene - Java
> Issue Type: Bug
> Components: Index
> Reporter: Ning Li
> Priority: Minor
> Attachments: TermInfosReader.patch
>
>
> I replaced IndexModifier with IndexWriter in test case TestStressIndexing and noticed the test failed from time to time because some .tis file is still open when MockRAMDirectory.close() is called. It turns out it is because .tis file is not closed if an exception occurs in TermInfosReader's constructor.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-978) GC resources in TermInfosReader when
exception occurs in its constructor
Posted by "Ning Li (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ning Li updated LUCENE-978:
---------------------------
Attachment: Readers.patch
Similar fixes are added for FieldsReader and TermVectorsReader as well.
> GC resources in TermInfosReader when exception occurs in its constructor
> ------------------------------------------------------------------------
>
> Key: LUCENE-978
> URL: https://issues.apache.org/jira/browse/LUCENE-978
> Project: Lucene - Java
> Issue Type: Bug
> Components: Index
> Reporter: Ning Li
> Priority: Minor
> Attachments: Readers.patch, TermInfosReader.patch
>
>
> I replaced IndexModifier with IndexWriter in test case TestStressIndexing and noticed the test failed from time to time because some .tis file is still open when MockRAMDirectory.close() is called. It turns out it is because .tis file is not closed if an exception occurs in TermInfosReader's constructor.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-978) GC resources in TermInfosReader when
exception occurs in its constructor
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12520273 ]
Michael McCandless commented on LUCENE-978:
-------------------------------------------
Agreed. Actually, it also looks like we need to do something similar for FieldsReader/TermVectorsReader too?
> GC resources in TermInfosReader when exception occurs in its constructor
> ------------------------------------------------------------------------
>
> Key: LUCENE-978
> URL: https://issues.apache.org/jira/browse/LUCENE-978
> Project: Lucene - Java
> Issue Type: Bug
> Components: Index
> Reporter: Ning Li
> Priority: Minor
> Attachments: TermInfosReader.patch
>
>
> I replaced IndexModifier with IndexWriter in test case TestStressIndexing and noticed the test failed from time to time because some .tis file is still open when MockRAMDirectory.close() is called. It turns out it is because .tis file is not closed if an exception occurs in TermInfosReader's constructor.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Assigned: (LUCENE-978) GC resources in TermInfosReader when
exception occurs in its constructor
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael McCandless reassigned LUCENE-978:
-----------------------------------------
Assignee: Michael McCandless
> GC resources in TermInfosReader when exception occurs in its constructor
> ------------------------------------------------------------------------
>
> Key: LUCENE-978
> URL: https://issues.apache.org/jira/browse/LUCENE-978
> Project: Lucene - Java
> Issue Type: Bug
> Components: Index
> Reporter: Ning Li
> Assignee: Michael McCandless
> Priority: Minor
> Attachments: Readers.patch, TermInfosReader.patch
>
>
> I replaced IndexModifier with IndexWriter in test case TestStressIndexing and noticed the test failed from time to time because some .tis file is still open when MockRAMDirectory.close() is called. It turns out it is because .tis file is not closed if an exception occurs in TermInfosReader's constructor.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org