[GitHub] markusthoemmes commented on a change in pull request #3534: Add abstraction to controller role in ansible

[GitBox <gi...@apache.org>]

markusthoemmes commented on a change in pull request #3534: Add abstraction to controller role in ansible
URL: https://github.com/apache/incubator-openwhisk/pull/3534#discussion_r180647477
 
 

 ##########
 File path: ansible/controller.yml
 ##########
 @@ -1,6 +1,12 @@
 ---
-# This playbook deploys Openwhisk Controllers.  
+# This playbook deploys Openwhisk Controllers.
 
 - hosts: controllers
+  vars:
+    host_group: "{{ groups['controllers'] }}"
+    name_prefix: "controller"
+    controller_index_base: 0
+    local_bookkeeping: controller.localBookkeeping
+    akka_enabled: "True"
 
 Review comment:
   Can we abstract this to `join_cluster: True`? akka_enabled is only partially true, since the component will ofcourse still use akka, but it doesn't join the cluster.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services