You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2023/01/05 13:49:47 UTC
[GitHub] [doris] cambyzju opened a new pull request, #15661: [fix](compile) compile failed in Mac with clang14
cambyzju opened a new pull request, #15661:
URL: https://github.com/apache/doris/pull/15661
# Proposed changes
Issue Number: close #xxx
## Problem summary
Describe your changes.
1. unused-but-set-variable error while compile vectorscan
doris/thirdparty/src/vectorscan-vectorscan-5.4.7/src/nfa/mcclellancompile.cpp:1485:13: error: variable 'total_daddy' set but not used [-Werror,-Wunused-but-set-variable]
u16 total_daddy = 0;
2. we should compile gflags with Release mode, to output libgflags.a instead of libgflags_debug.a
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 commented on pull request #15661: [fix](compile) compile failed in Mac with clang14
Posted by GitBox <gi...@apache.org>.
adonis0147 commented on PR #15661:
URL: https://github.com/apache/doris/pull/15661#issuecomment-1372368853
By the way, what is the version of clang you used? Would you like to provide the information by executing the command `clang --version`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 commented on a diff in pull request #15661: [fix](compile) compile failed in Mac with clang14
Posted by GitBox <gi...@apache.org>.
adonis0147 commented on code in PR #15661:
URL: https://github.com/apache/doris/pull/15661#discussion_r1065315916
##########
thirdparty/build-thirdparty.sh:
##########
@@ -681,7 +681,7 @@ build_hyperscan() {
mkdir -p "${BUILD_DIR}"
cd "${BUILD_DIR}"
- "${CMAKE_CMD}" -G "${GENERATOR}" -DBUILD_SHARED_LIBS=0 \
+ "${CMAKE_CMD}" -G "${GENERATOR}" -DBUILD_SHARED_LIBS=0 -DCMAKE_BUILD_TYPE=RELWITHDEBINFO \
Review Comment:
```suggestion
"${CMAKE_CMD}" -G "${GENERATOR}" -DBUILD_SHARED_LIBS=0 -DCMAKE_BUILD_TYPE=RelWithDebInfo \
```
Reference:
```shell
~ cmake --help-variable CMAKE_BUILD_TYPE
CMAKE_BUILD_TYPE
----------------
Specifies the build type on single-configuration generators (e.g.
:ref:`Makefile Generators` or ``Ninja``). Typical values include
``Debug``, ``Release``, ``RelWithDebInfo`` and ``MinSizeRel``, but custom
build types can also be defined.
This variable is initialized by the first ``project()`` or
``enable_language()`` command called in a project when a new build
tree is first created. If the ``CMAKE_BUILD_TYPE`` environment
variable is set, its value is used. Otherwise, a toolchain-specific
default is chosen when a language is enabled. The default value is often
an empty string, but this is usually not desirable and one of the other
standard build types is usually more appropriate.
Depending on the situation, the value of this variable may be treated
case-sensitively or case-insensitively. See :ref:`Build Configurations`
for discussion of this and other related topics.
For multi-config generators, see ``CMAKE_CONFIGURATION_TYPES``.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] cambyzju commented on pull request #15661: [fix](compile) compile failed in Mac with clang14
Posted by GitBox <gi...@apache.org>.
cambyzju commented on PR #15661:
URL: https://github.com/apache/doris/pull/15661#issuecomment-1373047242
> By the way, what is the version of clang you used? Would you like to provide the information by executing the command `clang --version`?
any better solution, please let me know.
// clang version:
% clang --version
Apple clang version 14.0.0 (clang-1400.0.29.202)
Target: arm64-apple-darwin22.1.0
Thread model: posix
InstalledDir: /Library/Developer/CommandLineTools/usr/bin
// solution in hyperscan:
https://github.com/intel/hyperscan/commit/f69696999e8d22e9f9ead12e8384e8f357fe3854
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 merged pull request #15661: [fix](compile) compile failed in Mac with clang14
Posted by GitBox <gi...@apache.org>.
adonis0147 merged PR #15661:
URL: https://github.com/apache/doris/pull/15661
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15661: [fix](compile) compile failed in Mac with clang14
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15661:
URL: https://github.com/apache/doris/pull/15661#issuecomment-1376923987
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #15661: [fix](compile) compile failed in Mac with clang14
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #15661:
URL: https://github.com/apache/doris/pull/15661#issuecomment-1372549685
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 36.46 seconds
load time: 477 seconds
storage size: 17122884129 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230105180043_clickbench_pr_74446.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 commented on pull request #15661: [fix](compile) compile failed in Mac with clang14
Posted by GitBox <gi...@apache.org>.
adonis0147 commented on PR #15661:
URL: https://github.com/apache/doris/pull/15661#issuecomment-1372365663
> Describe your changes.
>
> 1. unused-but-set-variable error while compile vectorscan
> doris/thirdparty/src/vectorscan-vectorscan-5.4.7/src/nfa/mcclellancompile.cpp:1485:13: > error: variable 'total_daddy' set but not used [-Werror,-Wunused-but-set-variable]
> u16 total_daddy = 0;
> 2. we should compile gflags with Release mode, to output libgflags.a instead of libgflags_debug.a
The second change is ok. But I don't think it is good to resolve the first issue by adding a patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 commented on pull request #15661: [fix](compile) compile failed in Mac with clang14
Posted by GitBox <gi...@apache.org>.
adonis0147 commented on PR #15661:
URL: https://github.com/apache/doris/pull/15661#issuecomment-1376701559
Hi @cambyzju , these changes have no side effects and we can apply them safely, but I think you would better modify the description to tell others in which scenarios these issues may occur.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] cambyzju commented on pull request #15661: [fix](compile) compile failed in Mac with clang14
Posted by GitBox <gi...@apache.org>.
cambyzju commented on PR #15661:
URL: https://github.com/apache/doris/pull/15661#issuecomment-1376921855
> Hi @cambyzju , these changes have no side effects and we can apply them safely, but I think you would better modify the description to tell others in which scenarios these issues may occur.
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15661: [fix](compile) compile failed in Mac with clang14
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15661:
URL: https://github.com/apache/doris/pull/15661#issuecomment-1376923953
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org