You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "rajeshbabu (JIRA)" <ji...@apache.org> on 2012/06/29 13:37:42 UTC
[jira] [Created] (HBASE-6293) HMaster does not go down while
splitting logs even if explicit shutdown is called.
rajeshbabu created HBASE-6293:
---------------------------------
Summary: HMaster does not go down while splitting logs even if explicit shutdown is called.
Key: HBASE-6293
URL: https://issues.apache.org/jira/browse/HBASE-6293
Project: HBase
Issue Type: Bug
Affects Versions: 0.94.0, 0.92.1
Reporter: rajeshbabu
Assignee: rajeshbabu
Fix For: 0.92.2, 0.96.0, 0.94.1
When master starts up and tries to do splitlog, in case of any error we try to do that infinitely in a loop until it succeeds.
But now if we get a shutdown call, inside SplitLogManager
{code}
if (stopper.isStopped()) {
LOG.warn("Stopped while waiting for log splits to be completed");
return;
}
{code}
Here we know that the master has stopped. As the task may not be completed now
{code}
if (batch.done != batch.installed) {
batch.isDead = true;
tot_mgr_log_split_batch_err.incrementAndGet();
LOG.warn("error while splitting logs in " + logDirs +
" installed = " + batch.installed + " but only " + batch.done + " done");
throw new IOException("error or interrupt while splitting logs in "
+ logDirs + " Task = " + batch);
}
{code}
we throw an exception. In MasterFileSystem.splitLogAfterStartup() we don't check if the master is stopped and we try continously.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6293) HMaster does not go down while
splitting logs even if explicit shutdown is called.
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13405991#comment-13405991 ]
stack commented on HBASE-6293:
------------------------------
+1
> HMaster does not go down while splitting logs even if explicit shutdown is called.
> ----------------------------------------------------------------------------------
>
> Key: HBASE-6293
> URL: https://issues.apache.org/jira/browse/HBASE-6293
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.1, 0.94.0
> Reporter: rajeshbabu
> Assignee: rajeshbabu
> Fix For: 0.92.2, 0.96.0, 0.94.1
>
> Attachments: 6293.txt
>
>
> When master starts up and tries to do splitlog, in case of any error we try to do that infinitely in a loop until it succeeds.
> But now if we get a shutdown call, inside SplitLogManager
> {code}
> if (stopper.isStopped()) {
> LOG.warn("Stopped while waiting for log splits to be completed");
> return;
> }
> {code}
> Here we know that the master has stopped. As the task may not be completed now
> {code}
> if (batch.done != batch.installed) {
> batch.isDead = true;
> tot_mgr_log_split_batch_err.incrementAndGet();
> LOG.warn("error while splitting logs in " + logDirs +
> " installed = " + batch.installed + " but only " + batch.done + " done");
> throw new IOException("error or interrupt while splitting logs in "
> + logDirs + " Task = " + batch);
> }
> {code}
> we throw an exception. In MasterFileSystem.splitLogAfterStartup() we don't check if the master is stopped and we try continously.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6293) HMaster does not go down while
splitting logs even if explicit shutdown is called.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13428754#comment-13428754 ]
Hudson commented on HBASE-6293:
-------------------------------
Integrated in HBase-0.94-security-on-Hadoop-23 #6 (See [https://builds.apache.org/job/HBase-0.94-security-on-Hadoop-23/6/])
HBASE-6293 HMaster does not go down while splitting logs even if explicit shutdown is called. (Revision 1357759)
Result = FAILURE
larsh :
Files :
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java
> HMaster does not go down while splitting logs even if explicit shutdown is called.
> ----------------------------------------------------------------------------------
>
> Key: HBASE-6293
> URL: https://issues.apache.org/jira/browse/HBASE-6293
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.1, 0.94.0
> Reporter: rajeshbabu
> Assignee: Lars Hofhansl
> Fix For: 0.92.2, 0.96.0, 0.94.1
>
> Attachments: 6293.txt
>
>
> When master starts up and tries to do splitlog, in case of any error we try to do that infinitely in a loop until it succeeds.
> But now if we get a shutdown call, inside SplitLogManager
> {code}
> if (stopper.isStopped()) {
> LOG.warn("Stopped while waiting for log splits to be completed");
> return;
> }
> {code}
> Here we know that the master has stopped. As the task may not be completed now
> {code}
> if (batch.done != batch.installed) {
> batch.isDead = true;
> tot_mgr_log_split_batch_err.incrementAndGet();
> LOG.warn("error while splitting logs in " + logDirs +
> " installed = " + batch.installed + " but only " + batch.done + " done");
> throw new IOException("error or interrupt while splitting logs in "
> + logDirs + " Task = " + batch);
> }
> {code}
> we throw an exception. In MasterFileSystem.splitLogAfterStartup() we don't check if the master is stopped and we try continously.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6293) HMaster does not go down while
splitting logs even if explicit shutdown is called.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13407328#comment-13407328 ]
Hudson commented on HBASE-6293:
-------------------------------
Integrated in HBase-0.94 #298 (See [https://builds.apache.org/job/HBase-0.94/298/])
HBASE-6293 HMaster does not go down while splitting logs even if explicit shutdown is called. (Revision 1357759)
Result = FAILURE
larsh :
Files :
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java
> HMaster does not go down while splitting logs even if explicit shutdown is called.
> ----------------------------------------------------------------------------------
>
> Key: HBASE-6293
> URL: https://issues.apache.org/jira/browse/HBASE-6293
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.1, 0.94.0
> Reporter: rajeshbabu
> Assignee: Lars Hofhansl
> Fix For: 0.92.2, 0.96.0, 0.94.1
>
> Attachments: 6293.txt
>
>
> When master starts up and tries to do splitlog, in case of any error we try to do that infinitely in a loop until it succeeds.
> But now if we get a shutdown call, inside SplitLogManager
> {code}
> if (stopper.isStopped()) {
> LOG.warn("Stopped while waiting for log splits to be completed");
> return;
> }
> {code}
> Here we know that the master has stopped. As the task may not be completed now
> {code}
> if (batch.done != batch.installed) {
> batch.isDead = true;
> tot_mgr_log_split_batch_err.incrementAndGet();
> LOG.warn("error while splitting logs in " + logDirs +
> " installed = " + batch.installed + " but only " + batch.done + " done");
> throw new IOException("error or interrupt while splitting logs in "
> + logDirs + " Task = " + batch);
> }
> {code}
> we throw an exception. In MasterFileSystem.splitLogAfterStartup() we don't check if the master is stopped and we try continously.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6293) HMaster does not go down while
splitting logs even if explicit shutdown is called.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13407519#comment-13407519 ]
Hudson commented on HBASE-6293:
-------------------------------
Integrated in HBase-0.94-deploy #4 (See [https://builds.apache.org/job/HBase-0.94-deploy/4/])
HBASE-6293 HMaster does not go down while splitting logs even if explicit shutdown is called. (Revision 1357759)
Result = SUCCESS
larsh :
Files :
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java
> HMaster does not go down while splitting logs even if explicit shutdown is called.
> ----------------------------------------------------------------------------------
>
> Key: HBASE-6293
> URL: https://issues.apache.org/jira/browse/HBASE-6293
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.1, 0.94.0
> Reporter: rajeshbabu
> Assignee: Lars Hofhansl
> Fix For: 0.92.2, 0.96.0, 0.94.1
>
> Attachments: 6293.txt
>
>
> When master starts up and tries to do splitlog, in case of any error we try to do that infinitely in a loop until it succeeds.
> But now if we get a shutdown call, inside SplitLogManager
> {code}
> if (stopper.isStopped()) {
> LOG.warn("Stopped while waiting for log splits to be completed");
> return;
> }
> {code}
> Here we know that the master has stopped. As the task may not be completed now
> {code}
> if (batch.done != batch.installed) {
> batch.isDead = true;
> tot_mgr_log_split_batch_err.incrementAndGet();
> LOG.warn("error while splitting logs in " + logDirs +
> " installed = " + batch.installed + " but only " + batch.done + " done");
> throw new IOException("error or interrupt while splitting logs in "
> + logDirs + " Task = " + batch);
> }
> {code}
> we throw an exception. In MasterFileSystem.splitLogAfterStartup() we don't check if the master is stopped and we try continously.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6293) HMaster does not go down while
splitting logs even if explicit shutdown is called.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13406764#comment-13406764 ]
Hadoop QA commented on HBASE-6293:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12534877/6293.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.
+1 javadoc. The javadoc tool did not generate any warning messages.
-1 javac. The applied patch generated 5 javac compiler warnings (more than the trunk's current 4 warnings).
-1 findbugs. The patch appears to introduce 7 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.security.access.TestZKPermissionsWatcher
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2320//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2320//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2320//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2320//console
This message is automatically generated.
> HMaster does not go down while splitting logs even if explicit shutdown is called.
> ----------------------------------------------------------------------------------
>
> Key: HBASE-6293
> URL: https://issues.apache.org/jira/browse/HBASE-6293
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.1, 0.94.0
> Reporter: rajeshbabu
> Assignee: rajeshbabu
> Fix For: 0.92.2, 0.96.0, 0.94.1
>
> Attachments: 6293.txt
>
>
> When master starts up and tries to do splitlog, in case of any error we try to do that infinitely in a loop until it succeeds.
> But now if we get a shutdown call, inside SplitLogManager
> {code}
> if (stopper.isStopped()) {
> LOG.warn("Stopped while waiting for log splits to be completed");
> return;
> }
> {code}
> Here we know that the master has stopped. As the task may not be completed now
> {code}
> if (batch.done != batch.installed) {
> batch.isDead = true;
> tot_mgr_log_split_batch_err.incrementAndGet();
> LOG.warn("error while splitting logs in " + logDirs +
> " installed = " + batch.installed + " but only " + batch.done + " done");
> throw new IOException("error or interrupt while splitting logs in "
> + logDirs + " Task = " + batch);
> }
> {code}
> we throw an exception. In MasterFileSystem.splitLogAfterStartup() we don't check if the master is stopped and we try continously.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6293) HMaster does not go down while
splitting logs even if explicit shutdown is called.
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl updated HBASE-6293:
---------------------------------
Status: Patch Available (was: Open)
> HMaster does not go down while splitting logs even if explicit shutdown is called.
> ----------------------------------------------------------------------------------
>
> Key: HBASE-6293
> URL: https://issues.apache.org/jira/browse/HBASE-6293
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.94.0, 0.92.1
> Reporter: rajeshbabu
> Assignee: rajeshbabu
> Fix For: 0.92.2, 0.96.0, 0.94.1
>
> Attachments: 6293.txt
>
>
> When master starts up and tries to do splitlog, in case of any error we try to do that infinitely in a loop until it succeeds.
> But now if we get a shutdown call, inside SplitLogManager
> {code}
> if (stopper.isStopped()) {
> LOG.warn("Stopped while waiting for log splits to be completed");
> return;
> }
> {code}
> Here we know that the master has stopped. As the task may not be completed now
> {code}
> if (batch.done != batch.installed) {
> batch.isDead = true;
> tot_mgr_log_split_batch_err.incrementAndGet();
> LOG.warn("error while splitting logs in " + logDirs +
> " installed = " + batch.installed + " but only " + batch.done + " done");
> throw new IOException("error or interrupt while splitting logs in "
> + logDirs + " Task = " + batch);
> }
> {code}
> we throw an exception. In MasterFileSystem.splitLogAfterStartup() we don't check if the master is stopped and we try continously.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6293) HMaster does not go down while
splitting logs even if explicit shutdown is called.
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl updated HBASE-6293:
---------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
Committed to 0.92, 0.94, and 0.96
> HMaster does not go down while splitting logs even if explicit shutdown is called.
> ----------------------------------------------------------------------------------
>
> Key: HBASE-6293
> URL: https://issues.apache.org/jira/browse/HBASE-6293
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.1, 0.94.0
> Reporter: rajeshbabu
> Assignee: Lars Hofhansl
> Fix For: 0.92.2, 0.96.0, 0.94.1
>
> Attachments: 6293.txt
>
>
> When master starts up and tries to do splitlog, in case of any error we try to do that infinitely in a loop until it succeeds.
> But now if we get a shutdown call, inside SplitLogManager
> {code}
> if (stopper.isStopped()) {
> LOG.warn("Stopped while waiting for log splits to be completed");
> return;
> }
> {code}
> Here we know that the master has stopped. As the task may not be completed now
> {code}
> if (batch.done != batch.installed) {
> batch.isDead = true;
> tot_mgr_log_split_batch_err.incrementAndGet();
> LOG.warn("error while splitting logs in " + logDirs +
> " installed = " + batch.installed + " but only " + batch.done + " done");
> throw new IOException("error or interrupt while splitting logs in "
> + logDirs + " Task = " + batch);
> }
> {code}
> we throw an exception. In MasterFileSystem.splitLogAfterStartup() we don't check if the master is stopped and we try continously.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6293) HMaster does not go down while
splitting logs even if explicit shutdown is called.
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13406870#comment-13406870 ]
Lars Hofhansl commented on HBASE-6293:
--------------------------------------
Will make 0.92/0.94 versions tomorrow and commit.
> HMaster does not go down while splitting logs even if explicit shutdown is called.
> ----------------------------------------------------------------------------------
>
> Key: HBASE-6293
> URL: https://issues.apache.org/jira/browse/HBASE-6293
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.1, 0.94.0
> Reporter: rajeshbabu
> Assignee: rajeshbabu
> Fix For: 0.92.2, 0.96.0, 0.94.1
>
> Attachments: 6293.txt
>
>
> When master starts up and tries to do splitlog, in case of any error we try to do that infinitely in a loop until it succeeds.
> But now if we get a shutdown call, inside SplitLogManager
> {code}
> if (stopper.isStopped()) {
> LOG.warn("Stopped while waiting for log splits to be completed");
> return;
> }
> {code}
> Here we know that the master has stopped. As the task may not be completed now
> {code}
> if (batch.done != batch.installed) {
> batch.isDead = true;
> tot_mgr_log_split_batch_err.incrementAndGet();
> LOG.warn("error while splitting logs in " + logDirs +
> " installed = " + batch.installed + " but only " + batch.done + " done");
> throw new IOException("error or interrupt while splitting logs in "
> + logDirs + " Task = " + batch);
> }
> {code}
> we throw an exception. In MasterFileSystem.splitLogAfterStartup() we don't check if the master is stopped and we try continously.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (HBASE-6293) HMaster does not go down while
splitting logs even if explicit shutdown is called.
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl closed HBASE-6293.
--------------------------------
> HMaster does not go down while splitting logs even if explicit shutdown is called.
> ----------------------------------------------------------------------------------
>
> Key: HBASE-6293
> URL: https://issues.apache.org/jira/browse/HBASE-6293
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.1, 0.94.0
> Reporter: rajeshbabu
> Assignee: Lars Hofhansl
> Fix For: 0.92.2, 0.94.1, 0.96.0
>
> Attachments: 6293.txt
>
>
> When master starts up and tries to do splitlog, in case of any error we try to do that infinitely in a loop until it succeeds.
> But now if we get a shutdown call, inside SplitLogManager
> {code}
> if (stopper.isStopped()) {
> LOG.warn("Stopped while waiting for log splits to be completed");
> return;
> }
> {code}
> Here we know that the master has stopped. As the task may not be completed now
> {code}
> if (batch.done != batch.installed) {
> batch.isDead = true;
> tot_mgr_log_split_batch_err.incrementAndGet();
> LOG.warn("error while splitting logs in " + logDirs +
> " installed = " + batch.installed + " but only " + batch.done + " done");
> throw new IOException("error or interrupt while splitting logs in "
> + logDirs + " Task = " + batch);
> }
> {code}
> we throw an exception. In MasterFileSystem.splitLogAfterStartup() we don't check if the master is stopped and we try continously.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6293) HMaster does not go down while
splitting logs even if explicit shutdown is called.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13411178#comment-13411178 ]
Hudson commented on HBASE-6293:
-------------------------------
Integrated in HBase-0.94-security #39 (See [https://builds.apache.org/job/HBase-0.94-security/39/])
HBASE-6293 HMaster does not go down while splitting logs even if explicit shutdown is called. (Revision 1357759)
Result = SUCCESS
larsh :
Files :
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java
> HMaster does not go down while splitting logs even if explicit shutdown is called.
> ----------------------------------------------------------------------------------
>
> Key: HBASE-6293
> URL: https://issues.apache.org/jira/browse/HBASE-6293
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.1, 0.94.0
> Reporter: rajeshbabu
> Assignee: Lars Hofhansl
> Fix For: 0.92.2, 0.96.0, 0.94.1
>
> Attachments: 6293.txt
>
>
> When master starts up and tries to do splitlog, in case of any error we try to do that infinitely in a loop until it succeeds.
> But now if we get a shutdown call, inside SplitLogManager
> {code}
> if (stopper.isStopped()) {
> LOG.warn("Stopped while waiting for log splits to be completed");
> return;
> }
> {code}
> Here we know that the master has stopped. As the task may not be completed now
> {code}
> if (batch.done != batch.installed) {
> batch.isDead = true;
> tot_mgr_log_split_batch_err.incrementAndGet();
> LOG.warn("error while splitting logs in " + logDirs +
> " installed = " + batch.installed + " but only " + batch.done + " done");
> throw new IOException("error or interrupt while splitting logs in "
> + logDirs + " Task = " + batch);
> }
> {code}
> we throw an exception. In MasterFileSystem.splitLogAfterStartup() we don't check if the master is stopped and we try continously.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6293) HMaster does not go down while
splitting logs even if explicit shutdown is called.
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13405294#comment-13405294 ]
stack commented on HBASE-6293:
------------------------------
Good find Rajesh.
> HMaster does not go down while splitting logs even if explicit shutdown is called.
> ----------------------------------------------------------------------------------
>
> Key: HBASE-6293
> URL: https://issues.apache.org/jira/browse/HBASE-6293
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.1, 0.94.0
> Reporter: rajeshbabu
> Assignee: rajeshbabu
> Fix For: 0.92.2, 0.96.0, 0.94.1
>
>
> When master starts up and tries to do splitlog, in case of any error we try to do that infinitely in a loop until it succeeds.
> But now if we get a shutdown call, inside SplitLogManager
> {code}
> if (stopper.isStopped()) {
> LOG.warn("Stopped while waiting for log splits to be completed");
> return;
> }
> {code}
> Here we know that the master has stopped. As the task may not be completed now
> {code}
> if (batch.done != batch.installed) {
> batch.isDead = true;
> tot_mgr_log_split_batch_err.incrementAndGet();
> LOG.warn("error while splitting logs in " + logDirs +
> " installed = " + batch.installed + " but only " + batch.done + " done");
> throw new IOException("error or interrupt while splitting logs in "
> + logDirs + " Task = " + batch);
> }
> {code}
> we throw an exception. In MasterFileSystem.splitLogAfterStartup() we don't check if the master is stopped and we try continously.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6293) HMaster does not go down while
splitting logs even if explicit shutdown is called.
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl updated HBASE-6293:
---------------------------------
Attachment: 6293.txt
Simple patch.
> HMaster does not go down while splitting logs even if explicit shutdown is called.
> ----------------------------------------------------------------------------------
>
> Key: HBASE-6293
> URL: https://issues.apache.org/jira/browse/HBASE-6293
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.1, 0.94.0
> Reporter: rajeshbabu
> Assignee: rajeshbabu
> Fix For: 0.92.2, 0.96.0, 0.94.1
>
> Attachments: 6293.txt
>
>
> When master starts up and tries to do splitlog, in case of any error we try to do that infinitely in a loop until it succeeds.
> But now if we get a shutdown call, inside SplitLogManager
> {code}
> if (stopper.isStopped()) {
> LOG.warn("Stopped while waiting for log splits to be completed");
> return;
> }
> {code}
> Here we know that the master has stopped. As the task may not be completed now
> {code}
> if (batch.done != batch.installed) {
> batch.isDead = true;
> tot_mgr_log_split_batch_err.incrementAndGet();
> LOG.warn("error while splitting logs in " + logDirs +
> " installed = " + batch.installed + " but only " + batch.done + " done");
> throw new IOException("error or interrupt while splitting logs in "
> + logDirs + " Task = " + batch);
> }
> {code}
> we throw an exception. In MasterFileSystem.splitLogAfterStartup() we don't check if the master is stopped and we try continously.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HBASE-6293) HMaster does not go down while
splitting logs even if explicit shutdown is called.
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl reassigned HBASE-6293:
------------------------------------
Assignee: Lars Hofhansl (was: rajeshbabu)
> HMaster does not go down while splitting logs even if explicit shutdown is called.
> ----------------------------------------------------------------------------------
>
> Key: HBASE-6293
> URL: https://issues.apache.org/jira/browse/HBASE-6293
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.1, 0.94.0
> Reporter: rajeshbabu
> Assignee: Lars Hofhansl
> Fix For: 0.92.2, 0.96.0, 0.94.1
>
> Attachments: 6293.txt
>
>
> When master starts up and tries to do splitlog, in case of any error we try to do that infinitely in a loop until it succeeds.
> But now if we get a shutdown call, inside SplitLogManager
> {code}
> if (stopper.isStopped()) {
> LOG.warn("Stopped while waiting for log splits to be completed");
> return;
> }
> {code}
> Here we know that the master has stopped. As the task may not be completed now
> {code}
> if (batch.done != batch.installed) {
> batch.isDead = true;
> tot_mgr_log_split_batch_err.incrementAndGet();
> LOG.warn("error while splitting logs in " + logDirs +
> " installed = " + batch.installed + " but only " + batch.done + " done");
> throw new IOException("error or interrupt while splitting logs in "
> + logDirs + " Task = " + batch);
> }
> {code}
> we throw an exception. In MasterFileSystem.splitLogAfterStartup() we don't check if the master is stopped and we try continously.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6293) HMaster does not go down while
splitting logs even if explicit shutdown is called.
Posted by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13405954#comment-13405954 ]
ramkrishna.s.vasudevan commented on HBASE-6293:
-----------------------------------------------
+1.
> HMaster does not go down while splitting logs even if explicit shutdown is called.
> ----------------------------------------------------------------------------------
>
> Key: HBASE-6293
> URL: https://issues.apache.org/jira/browse/HBASE-6293
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.1, 0.94.0
> Reporter: rajeshbabu
> Assignee: rajeshbabu
> Fix For: 0.92.2, 0.96.0, 0.94.1
>
> Attachments: 6293.txt
>
>
> When master starts up and tries to do splitlog, in case of any error we try to do that infinitely in a loop until it succeeds.
> But now if we get a shutdown call, inside SplitLogManager
> {code}
> if (stopper.isStopped()) {
> LOG.warn("Stopped while waiting for log splits to be completed");
> return;
> }
> {code}
> Here we know that the master has stopped. As the task may not be completed now
> {code}
> if (batch.done != batch.installed) {
> batch.isDead = true;
> tot_mgr_log_split_batch_err.incrementAndGet();
> LOG.warn("error while splitting logs in " + logDirs +
> " installed = " + batch.installed + " but only " + batch.done + " done");
> throw new IOException("error or interrupt while splitting logs in "
> + logDirs + " Task = " + batch);
> }
> {code}
> we throw an exception. In MasterFileSystem.splitLogAfterStartup() we don't check if the master is stopped and we try continously.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira