You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@johnzon.apache.org by James Carman <ja...@carmanconsulting.com> on 2017/06/24 04:48:48 UTC
Typo in class JohnsonJsonb?
Should the JohnsonJsonb class be named JohnzonJsonb instead?
Re: Typo in class JohnsonJsonb?
Posted by Romain Manni-Bucau <rm...@gmail.com>.
Thanks James!
Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> | Blog
<https://blog-rmannibucau.rhcloud.com> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | JavaEE Factory
<https://javaeefactory-rmannibucau.rhcloud.com>
2017-06-28 2:18 GMT+02:00 James Carman <ja...@carmanconsulting.com>:
> I'll close them. Thanks again for the quick turnaround!
> On Tue, Jun 27, 2017 at 6:15 PM Romain Manni-Bucau <rm...@gmail.com>
> wrote:
>
> > yep, the PR are not updated and i think I dont have the perms to do it.
> > Some other projects have a better integration but never got the "how" we
> > can do it.
> >
> >
> > Romain Manni-Bucau
> > @rmannibucau <https://twitter.com/rmannibucau> | Blog
> > <https://blog-rmannibucau.rhcloud.com> | Old Blog
> > <http://rmannibucau.wordpress.com> | Github <
> > https://github.com/rmannibucau> |
> > LinkedIn <https://www.linkedin.com/in/rmannibucau> | JavaEE Factory
> > <https://javaeefactory-rmannibucau.rhcloud.com>
> >
> > 2017-06-28 0:13 GMT+02:00 James Carman <ja...@carmanconsulting.com>:
> >
> > > So, what's the PR process these days? Do you want me to close these
> PRs
> > > out? They don't even show as merged on GitHub.
> > >
> > > On Sat, Jun 24, 2017 at 7:14 AM James Carman <
> james@carmanconsulting.com
> > >
> > > wrote:
> > >
> > > > I'm going to send in some PRs...
> > > >
> > > > On Sat, Jun 24, 2017 at 3:20 AM Romain Manni-Bucau <
> > > rmannibucau@gmail.com>
> > > > wrote:
> > > >
> > > >> Yes :)
> > > >>
> > > >> Le 24 juin 2017 06:49, "James Carman" <ja...@carmanconsulting.com>
> a
> > > >> écrit :
> > > >>
> > > >> > Should the JohnsonJsonb class be named JohnzonJsonb instead?
> > > >> >
> > > >>
> > > >
> > >
> >
>
Re: Typo in class JohnsonJsonb?
Posted by James Carman <ja...@carmanconsulting.com>.
I'll close them. Thanks again for the quick turnaround!
On Tue, Jun 27, 2017 at 6:15 PM Romain Manni-Bucau <rm...@gmail.com>
wrote:
> yep, the PR are not updated and i think I dont have the perms to do it.
> Some other projects have a better integration but never got the "how" we
> can do it.
>
>
> Romain Manni-Bucau
> @rmannibucau <https://twitter.com/rmannibucau> | Blog
> <https://blog-rmannibucau.rhcloud.com> | Old Blog
> <http://rmannibucau.wordpress.com> | Github <
> https://github.com/rmannibucau> |
> LinkedIn <https://www.linkedin.com/in/rmannibucau> | JavaEE Factory
> <https://javaeefactory-rmannibucau.rhcloud.com>
>
> 2017-06-28 0:13 GMT+02:00 James Carman <ja...@carmanconsulting.com>:
>
> > So, what's the PR process these days? Do you want me to close these PRs
> > out? They don't even show as merged on GitHub.
> >
> > On Sat, Jun 24, 2017 at 7:14 AM James Carman <james@carmanconsulting.com
> >
> > wrote:
> >
> > > I'm going to send in some PRs...
> > >
> > > On Sat, Jun 24, 2017 at 3:20 AM Romain Manni-Bucau <
> > rmannibucau@gmail.com>
> > > wrote:
> > >
> > >> Yes :)
> > >>
> > >> Le 24 juin 2017 06:49, "James Carman" <ja...@carmanconsulting.com> a
> > >> écrit :
> > >>
> > >> > Should the JohnsonJsonb class be named JohnzonJsonb instead?
> > >> >
> > >>
> > >
> >
>
Re: Typo in class JohnsonJsonb?
Posted by Romain Manni-Bucau <rm...@gmail.com>.
yep, the PR are not updated and i think I dont have the perms to do it.
Some other projects have a better integration but never got the "how" we
can do it.
Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> | Blog
<https://blog-rmannibucau.rhcloud.com> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | JavaEE Factory
<https://javaeefactory-rmannibucau.rhcloud.com>
2017-06-28 0:13 GMT+02:00 James Carman <ja...@carmanconsulting.com>:
> So, what's the PR process these days? Do you want me to close these PRs
> out? They don't even show as merged on GitHub.
>
> On Sat, Jun 24, 2017 at 7:14 AM James Carman <ja...@carmanconsulting.com>
> wrote:
>
> > I'm going to send in some PRs...
> >
> > On Sat, Jun 24, 2017 at 3:20 AM Romain Manni-Bucau <
> rmannibucau@gmail.com>
> > wrote:
> >
> >> Yes :)
> >>
> >> Le 24 juin 2017 06:49, "James Carman" <ja...@carmanconsulting.com> a
> >> écrit :
> >>
> >> > Should the JohnsonJsonb class be named JohnzonJsonb instead?
> >> >
> >>
> >
>
Re: Typo in class JohnsonJsonb?
Posted by James Carman <ja...@carmanconsulting.com>.
So, what's the PR process these days? Do you want me to close these PRs
out? They don't even show as merged on GitHub.
On Sat, Jun 24, 2017 at 7:14 AM James Carman <ja...@carmanconsulting.com>
wrote:
> I'm going to send in some PRs...
>
> On Sat, Jun 24, 2017 at 3:20 AM Romain Manni-Bucau <rm...@gmail.com>
> wrote:
>
>> Yes :)
>>
>> Le 24 juin 2017 06:49, "James Carman" <ja...@carmanconsulting.com> a
>> écrit :
>>
>> > Should the JohnsonJsonb class be named JohnzonJsonb instead?
>> >
>>
>
Re: Typo in class JohnsonJsonb?
Posted by James Carman <ja...@carmanconsulting.com>.
I'm going to send in some PRs...
On Sat, Jun 24, 2017 at 3:20 AM Romain Manni-Bucau <rm...@gmail.com>
wrote:
> Yes :)
>
> Le 24 juin 2017 06:49, "James Carman" <ja...@carmanconsulting.com> a
> écrit :
>
> > Should the JohnsonJsonb class be named JohnzonJsonb instead?
> >
>
Re: Typo in class JohnsonJsonb?
Posted by Romain Manni-Bucau <rm...@gmail.com>.
Yes :)
Le 24 juin 2017 06:49, "James Carman" <ja...@carmanconsulting.com> a écrit :
> Should the JohnsonJsonb class be named JohnzonJsonb instead?
>