You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by "notroj (via GitHub)" <gi...@apache.org> on 2024/12/13 09:07:58 UTC
[PR] Fix ra-test execution of svnserve in some build environments. [subversion]
notroj opened a new pull request, #25:
URL: https://github.com/apache/subversion/pull/25
```
Fix ra-test execution of svnserve in some build environments.
* subversion/tests/libsvn_ra/ra-test.c
(open_tunnel): Execute the wrapper with APR_PROGRAM_ENV rather than
APR_PROGRAM, so the build environment is inherited. The "svnserve"
executed here may be a libtool wrapper script which can in some cases
depend on the build environment to execute correctly.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@subversion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix ra-test execution of svnserve in some build environments. [subversion]
Posted by Joe Orton <jo...@redhat.com>.
On Tue, Jan 07, 2025 at 11:02:57PM +0100, Daniel Sahlberg wrote:
> Hi Joe,
>
> We are a little bit short on people who actually understand the impact of
> this PR, but since you are full committer, maybe you want to commit it
> yourself? If so, please commit the fix to ra-test.c first (while closing
> the PR). We also believe the GHA fixes are good but they should be
> committed separately.
Will do, sorry I forgot about this over Christmas!
Regards, Joe
Re: [PR] Fix ra-test execution of svnserve in some build environments. [subversion]
Posted by Daniel Sahlberg <da...@gmail.com>.
Hi Joe,
We are a little bit short on people who actually understand the impact of
this PR, but since you are full committer, maybe you want to commit it
yourself? If so, please commit the fix to ra-test.c first (while closing
the PR). We also believe the GHA fixes are good but they should be
committed separately.
Cheers,
Daniel
Den fre 13 dec. 2024 kl 10:08 skrev notroj (via GitHub) <gi...@apache.org>:
>
> notroj opened a new pull request, #25:
> URL: https://github.com/apache/subversion/pull/25
>
> ```
> Fix ra-test execution of svnserve in some build environments.
>
> * subversion/tests/libsvn_ra/ra-test.c
> (open_tunnel): Execute the wrapper with APR_PROGRAM_ENV rather than
> APR_PROGRAM, so the build environment is inherited. The "svnserve"
> executed here may be a libtool wrapper script which can in some cases
> depend on the build environment to execute correctly.
> ```
>
>
> --
> This is an automated message from the Apache Git Service.
> To respond to the message, please log on to GitHub and use the
> URL above to go to the specific comment.
>
> To unsubscribe, e-mail: dev-unsubscribe@subversion.apache.org
>
> For queries about this service, please contact Infrastructure at:
> users@infra.apache.org
>
>
Re: [PR] Fix ra-test execution of svnserve in some build environments. [subversion]
Posted by Daniel Sahlberg <da...@gmail.com>.
Den mån 16 dec. 2024 kl 21:18 skrev Timofei Zhakov <ti...@chemodax.net>:
> On Fri, Dec 13, 2024 at 10:08 AM notroj (via GitHub) <gi...@apache.org>
> wrote:
>
>>
>> notroj opened a new pull request, #25:
>> URL: https://github.com/apache/subversion/pull/25
>>
>> ```
>> Fix ra-test execution of svnserve in some build environments.
>>
>> * subversion/tests/libsvn_ra/ra-test.c
>> (open_tunnel): Execute the wrapper with APR_PROGRAM_ENV rather than
>> APR_PROGRAM, so the build environment is inherited. The "svnserve"
>> executed here may be a libtool wrapper script which can in some cases
>> depend on the build environment to execute correctly.
>> ```
>>
>>
>> --
>> This is an automated message from the Apache Git Service.
>> To respond to the message, please log on to GitHub and use the
>> URL above to go to the specific comment.
>>
>> To unsubscribe, e-mail: dev-unsubscribe@subversion.apache.org
>>
>> For queries about this service, please contact Infrastructure at:
>> users@infra.apache.org
>>
>>
> Hi,
>
> I think that it might be a good idea to commit the `Enable GitHub Actions
> workflows in pull requests` [1] commit from this PR into the trunk.
>
> What do you think?
>
That sounds like a good idea. We should probably commit this separately
from the main change.
Did you review the rest of the PR? It looks good to me, but I can't judge
if there could be a problem with inheriting the environment. The argument
given by Joe is seems reasonable but I'd like to reproduce it first.
@Timofei Zhakov <ti...@chemodax.net> If you'd like to commit it, remember
that we can close the PR directly with a suitable log message, see HACKING
[2].
Cheers,
Daniel
> [1]:
> https://github.com/apache/subversion/pull/25/commits/17d645a9c2b2a02fa315044fddc4cdfce559d03f
>
[2]
https://subversion.apache.org/docs/community-guide/conventions.html#github
> --
> Timofei Zhakov
>
Re: [PR] Fix ra-test execution of svnserve in some build environments. [subversion]
Posted by Timofei Zhakov <ti...@chemodax.net>.
On Fri, Dec 13, 2024 at 10:08 AM notroj (via GitHub) <gi...@apache.org> wrote:
>
> notroj opened a new pull request, #25:
> URL: https://github.com/apache/subversion/pull/25
>
> ```
> Fix ra-test execution of svnserve in some build environments.
>
> * subversion/tests/libsvn_ra/ra-test.c
> (open_tunnel): Execute the wrapper with APR_PROGRAM_ENV rather than
> APR_PROGRAM, so the build environment is inherited. The "svnserve"
> executed here may be a libtool wrapper script which can in some cases
> depend on the build environment to execute correctly.
> ```
>
>
> --
> This is an automated message from the Apache Git Service.
> To respond to the message, please log on to GitHub and use the
> URL above to go to the specific comment.
>
> To unsubscribe, e-mail: dev-unsubscribe@subversion.apache.org
>
> For queries about this service, please contact Infrastructure at:
> users@infra.apache.org
>
>
Hi,
I think that it might be a good idea to commit the `Enable GitHub Actions
workflows in pull requests` [1] commit from this PR into the trunk.
What do you think?
[1]:
https://github.com/apache/subversion/pull/25/commits/17d645a9c2b2a02fa315044fddc4cdfce559d03f
--
Timofei Zhakov
Re: [PR] Fix ra-test execution of svnserve in some build environments. [subversion]
Posted by "asfgit (via GitHub)" <gi...@apache.org>.
asfgit closed pull request #25: Fix ra-test execution of svnserve in some build environments.
URL: https://github.com/apache/subversion/pull/25
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@subversion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix ra-test execution of svnserve in some build environments. [subversion]
Posted by "MarsrockEarth (via GitHub)" <gi...@apache.org>.
MarsrockEarth commented on PR #25:
URL: https://github.com/apache/subversion/pull/25#issuecomment-2540937694
您的来信已收到
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@subversion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org