You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anand Mazumdar <ma...@gmail.com> on 2016/02/03 07:59:31 UTC
Review Request 43134: Added output operator for unversioned executor
protobuf.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43134/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Repository: mesos
Description
-------
This change adds the missing output operator for the unversioned executor protobuf. These are not used in the source code currently and hence were missing. The executor library uses the `v1` protobufs and the output operator for them was already added.
Diffs
-----
include/mesos/executor/executor.hpp a7d40f6acaf24e086fb46ecfb74e97612ba326d4
Diff: https://reviews.apache.org/r/43134/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 43134: Added output operator for unversioned
executor protobuf.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43134/#review117700
-----------------------------------------------------------
Ship it!
Looks like the output operator for call is already used in slave/http.cpp :)
- Vinod Kone
On Feb. 3, 2016, 6:59 a.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43134/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2016, 6:59 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change adds the missing output operator for the unversioned executor protobuf. These are not used in the source code currently and hence were missing. The executor library uses the `v1` protobufs and the output operator for them was already added.
>
>
> Diffs
> -----
>
> include/mesos/executor/executor.hpp a7d40f6acaf24e086fb46ecfb74e97612ba326d4
>
> Diff: https://reviews.apache.org/r/43134/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 43134: Added output operator for unversioned
executor protobuf.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43134/#review117598
-----------------------------------------------------------
Patch looks great!
Reviews applied: [43134]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Feb. 3, 2016, 6:59 a.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43134/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2016, 6:59 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change adds the missing output operator for the unversioned executor protobuf. These are not used in the source code currently and hence were missing. The executor library uses the `v1` protobufs and the output operator for them was already added.
>
>
> Diffs
> -----
>
> include/mesos/executor/executor.hpp a7d40f6acaf24e086fb46ecfb74e97612ba326d4
>
> Diff: https://reviews.apache.org/r/43134/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>