Re: svn commit: r11156 - in trunk/subversion: libsvn_ra_svn svnserve

[kf...@collab.net]

rooneg@tigris.org writes:
> --- trunk/subversion/svnserve/serve.c	(original)
> +++ trunk/subversion/svnserve/serve.c	Mon Sep 27 22:00:43 2004
> @@ -887,14 +887,19 @@
>    apr_array_header_t *paths, *full_paths;
>    svn_ra_svn_item_t *elt;
>    int i;
> -  int limit;
> +  apr_uint64_t limit;
>    log_baton_t lb;
>  
>    /* Parse the arguments. */
>    SVN_ERR(svn_ra_svn_parse_tuple(params, pool, "l(?r)(?r)bb?n", &paths,
>                                   &start_rev, &end_rev, &changed_paths,
>                                   &strict_node, &limit));
> -  if (limit == SVN_RA_SVN_UNSPECIFIED_NUMBER)
> +
> +  /* if we got an unspecified number then the user didn't send us anything,
> +     so we assume no limit.  if it's larger than INT_MAX then someone is 
> +     messing with us, since we know the svn client libraries will never send
> +     us anything that big, so play it safe and default to no limit. */
> +  if (limit == SVN_RA_SVN_UNSPECIFIED_NUMBER || limit > INT_MAX)
>      limit = 0;

Can you capitalize sentences?  It really makes a difference in
readability.

Thanks,
-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: r11156 - in trunk/subversion: libsvn_ra_svn svnserve

[Garrett Rooney <ro...@electricjellyfish.net>]

kfogel@collab.net wrote:

> Can you capitalize sentences?  It really makes a difference in
> readability.

Will do.

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org