You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by abhishekagarwal87 <gi...@git.apache.org> on 2016/04/01 12:55:41 UTC
[GitHub] storm pull request: STORM-1675 - Allow submitting multiple jars fr...
GitHub user abhishekagarwal87 opened a pull request:
https://github.com/apache/storm/pull/1296
STORM-1675 - Allow submitting multiple jars from the client
The PR is not complete yet and needs some refinements. I wanted to get some feedback first. I tried out multiple approaches -
1. Submitting individual jar one by one - Right now the stormjar has a hardcoded key so that both supervisor and nimbus can download/upload the jar. This becomes complicated if there is more than one jar. The keys for all the jars have to be passed from nimbus to supervisor. Then these keys have to be updated, removed, waited--upon-for-code-replication etc.
2. Build an app-assembly jar programmatically - It is not desired as it changes the internal structure of jar. which can result in unknown issues e.g. manifests have to be handled correctly.
3. Packing jars into a zip, upload it and unzip it and supervisor - This is the current approach. It seemed to me the cleanest approach.
I can also add an option to turn zip/unzip off for single jar topologies.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/abhishekagarwal87/storm multi-jar
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1296.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1296
----
commit 81c3a331333793ebd94bf9b9c6f376d0c7817dde
Author: Abhishek Agarwal <ab...@inmobi.com>
Date: 2016-04-01T10:35:59Z
Allow submitting multiple jars from the client
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1296: STORM-1675 - Allow submitting multiple jars from the clie...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1296
I think STORM-2016 covers this, so we can close this.
@abhishekagarwal87 What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1296: STORM-1675 - Allow submitting multiple jars from t...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1296
---
[GitHub] storm pull request: STORM-1675 - Allow submitting multiple jars fr...
Posted by abhishekagarwal87 <gi...@git.apache.org>.
Github user abhishekagarwal87 commented on the pull request:
https://github.com/apache/storm/pull/1296#issuecomment-207325039
Any comments/suggestions?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---