You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by or...@apache.org on 2018/03/20 14:53:55 UTC

qpid-broker-j git commit: QPID-8124: [Broker-J] Fix ACL logging on checking web management console access after REST SASL authentication

Repository: qpid-broker-j
Updated Branches:
  refs/heads/master 5c570579d -> 957f7eda0


QPID-8124: [Broker-J] Fix ACL logging on checking web management console access after REST SASL authentication


Project: http://git-wip-us.apache.org/repos/asf/qpid-broker-j/repo
Commit: http://git-wip-us.apache.org/repos/asf/qpid-broker-j/commit/957f7eda
Tree: http://git-wip-us.apache.org/repos/asf/qpid-broker-j/tree/957f7eda
Diff: http://git-wip-us.apache.org/repos/asf/qpid-broker-j/diff/957f7eda

Branch: refs/heads/master
Commit: 957f7eda039eb165aa2f75ab5f3afddbaefac87e
Parents: 5c57057
Author: Alex Rudyy <or...@apache.org>
Authored: Tue Mar 20 14:40:27 2018 +0000
Committer: Alex Rudyy <or...@apache.org>
Committed: Tue Mar 20 14:53:24 2018 +0000

----------------------------------------------------------------------
 .../qpid/server/management/plugin/servlet/rest/SaslServlet.java   | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/qpid-broker-j/blob/957f7eda/broker-plugins/management-http/src/main/java/org/apache/qpid/server/management/plugin/servlet/rest/SaslServlet.java
----------------------------------------------------------------------
diff --git a/broker-plugins/management-http/src/main/java/org/apache/qpid/server/management/plugin/servlet/rest/SaslServlet.java b/broker-plugins/management-http/src/main/java/org/apache/qpid/server/management/plugin/servlet/rest/SaslServlet.java
index 080b291..8d10ec4 100644
--- a/broker-plugins/management-http/src/main/java/org/apache/qpid/server/management/plugin/servlet/rest/SaslServlet.java
+++ b/broker-plugins/management-http/src/main/java/org/apache/qpid/server/management/plugin/servlet/rest/SaslServlet.java
@@ -249,9 +249,8 @@ public class SaslServlet extends AbstractServlet
             Broker broker = getBroker();
             try
             {
-                HttpManagementUtil.assertManagementAccess(broker, original);
                 Subject subject = HttpManagementUtil.createServletConnectionSubject(request, original);
-
+                HttpManagementUtil.assertManagementAccess(broker, subject);
                 HttpManagementUtil.saveAuthorisedSubject(request, subject);
                 if(challenge != null && challenge.length != 0)
                 {


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org