You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@kafka.apache.org by "Joel Koshy (JIRA)" <ji...@apache.org> on 2012/10/09 07:30:03 UTC

[jira] [Commented] (KAFKA-548) remove partition from ProducerRequestPartitionData and FetchResponsePartitionData

    [ https://issues.apache.org/jira/browse/KAFKA-548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13472147#comment-13472147 ] 

Joel Koshy commented on KAFKA-548:
----------------------------------

Why is it dirty? :) It looks pretty good to me - I did not upload it but I also had a draft patch for this from last week, and it was almost identical on the FetchResponse side. I think the only not so clean part is the fact that the partition byte size which was recorded in FetchResponseData.headerSize is now "split" between PartitionDataSend and TopicData. It might be better to move the 4-byte literal back to the FetchResponsePartitionData.headerSize, but that is also not ideal since that contribution comes from outside the FetchResponsePartitionData.

Also, what about the ProducerRequest-side?

                
> remove partition from ProducerRequestPartitionData and FetchResponsePartitionData
> ---------------------------------------------------------------------------------
>
>                 Key: KAFKA-548
>                 URL: https://issues.apache.org/jira/browse/KAFKA-548
>             Project: Kafka
>          Issue Type: Improvement
>            Reporter: Joe Stein
>              Labels: optimization
>             Fix For: 0.8
>
>         Attachments: kafka_548_v1.diff
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira