[jira] [Commented] (TINKERPOP3-243) Before GA we should go through IO and organize and clean.

["stephen mallette (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TINKERPOP3-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14499881#comment-14499881 ] 

stephen mallette commented on TINKERPOP3-243:
---------------------------------------------

The previous comment listed some remaining items to look at before closing out this ticket.  At this point, I've removed the extra Kryo instance that was being created for use of the file header and wrote a test to validate that a {{GryoReader.Builder}} could be used in multiple threads without issue.  In regards to the thread issue (which was raised in relation to hadoop-gremlin by [~okram]), I either don't have the test right:

https://github.com/apache/incubator-tinkerpop/blob/8122b15ae1f12bd6fc22ace3aad8a1ff838fa012/gremlin-core/src/test/java/org/apache/tinkerpop/gremlin/structure/io/gryo/GryoReaderWriterTest.java

or there is something else going on in hadoop-gremlin that isn't related to the builder being used across multiple threads.  I've confirmed that {{GryoReader}} should not be used across multiple threads as there is a shared kryo instance as a member variable which would mess stuff up.  Note that this is documented in the javadoc for the class.  So there should be one {{GryoReader}} per thread, but he builder should have no such restrictions.  

As it stands, there are several remaining issues with IO:

1. the issue on versioning with gryo mentioned in the last comment (which at the moment doesn't look quite right...still reviewing)
2. the work in the refactor-io branch which i need to review with [~okram]
3. TINKERPOP3-609 which really doesn't block this ticket but is related

> Before GA we should go through IO and organize and clean.
> ---------------------------------------------------------
>
>                 Key: TINKERPOP3-243
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP3-243
>             Project: TinkerPop 3
>          Issue Type: Improvement
>          Components: structure
>            Reporter: Marko A. Rodriguez
>            Assignee: stephen mallette
>             Fix For: 3.0.0.GA
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)