[GitHub] jasonpet closed pull request #307: Do Not Disable Triggers on Document Update Conflicts

[GitBox <gi...@apache.org>]

jasonpet closed pull request #307: Do Not Disable Triggers on Document Update Conflicts
URL: https://github.com/apache/incubator-openwhisk-package-kafka/pull/307
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/provider/consumer.py b/provider/consumer.py
index 12cfd75..865c209 100644
--- a/provider/consumer.py
+++ b/provider/consumer.py
@@ -359,9 +359,9 @@ def __pollForMessages(self):
 
     # decide whether or not to disable a trigger based on the status code returned
     # from firing the trigger. Specifically, disable on all 4xx status codes
-    # except 408 (gateway timeout) and 429 (throttle)
+    # except 408 (gateway timeout), 409 (document update conflict), and 429 (throttle)
     def __shouldDisable(self, status_code):
-        return status_code in range(400, 500) and status_code not in [408, 429]
+        return status_code in range(400, 500) and status_code not in [408, 409, 429]
 
     def __fireTrigger(self, messages):
         if self.__shouldRun():


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services