svn commit: r904212 - in /commons/proper/lang/branches/LANG_2_X/src/main/java/org/apache/commons/lang: ClassUtils.java builder/HashCodeBuilder.java builder/ToStringStyle.java

[se...@apache.org]

Author: sebb
Date: Thu Jan 28 18:46:25 2010
New Revision: 904212

URL: http://svn.apache.org/viewvc?rev=904212&view=rev
Log:
Make private fields final

Modified:
    commons/proper/lang/branches/LANG_2_X/src/main/java/org/apache/commons/lang/ClassUtils.java
    commons/proper/lang/branches/LANG_2_X/src/main/java/org/apache/commons/lang/builder/HashCodeBuilder.java
    commons/proper/lang/branches/LANG_2_X/src/main/java/org/apache/commons/lang/builder/ToStringStyle.java

Modified: commons/proper/lang/branches/LANG_2_X/src/main/java/org/apache/commons/lang/ClassUtils.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/branches/LANG_2_X/src/main/java/org/apache/commons/lang/ClassUtils.java?rev=904212&r1=904211&r2=904212&view=diff
==============================================================================
--- commons/proper/lang/branches/LANG_2_X/src/main/java/org/apache/commons/lang/ClassUtils.java (original)
+++ commons/proper/lang/branches/LANG_2_X/src/main/java/org/apache/commons/lang/ClassUtils.java Thu Jan 28 18:46:25 2010
@@ -69,7 +69,7 @@
     /**
      * Maps primitive <code>Class</code>es to their corresponding wrapper <code>Class</code>.
      */
-    private static Map primitiveWrapperMap = new HashMap();
+    private static final Map primitiveWrapperMap = new HashMap();
     static {
          primitiveWrapperMap.put(Boolean.TYPE, Boolean.class);
          primitiveWrapperMap.put(Byte.TYPE, Byte.class);
@@ -85,7 +85,7 @@
     /**
      * Maps wrapper <code>Class</code>es to their corresponding primitive types.
      */
-    private static Map wrapperPrimitiveMap = new HashMap();
+    private static final Map wrapperPrimitiveMap = new HashMap();
     static {
         for (Iterator it = primitiveWrapperMap.keySet().iterator(); it.hasNext();) {
             Class primitiveClass = (Class) it.next();
@@ -99,12 +99,12 @@
     /**
      * Maps a primitive class name to its corresponding abbreviation used in array class names.
      */
-    private static Map abbreviationMap = new HashMap();
+    private static final Map abbreviationMap = new HashMap();
 
     /**
      * Maps an abbreviation used in array class names to corresponding primitive class name.
      */
-    private static Map reverseAbbreviationMap = new HashMap();
+    private static final Map reverseAbbreviationMap = new HashMap();
 
     /**
      * Add primitive type abbreviation to maps of abbreviations.

Modified: commons/proper/lang/branches/LANG_2_X/src/main/java/org/apache/commons/lang/builder/HashCodeBuilder.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/branches/LANG_2_X/src/main/java/org/apache/commons/lang/builder/HashCodeBuilder.java?rev=904212&r1=904211&r2=904212&view=diff
==============================================================================
--- commons/proper/lang/branches/LANG_2_X/src/main/java/org/apache/commons/lang/builder/HashCodeBuilder.java (original)
+++ commons/proper/lang/branches/LANG_2_X/src/main/java/org/apache/commons/lang/builder/HashCodeBuilder.java Thu Jan 28 18:46:25 2010
@@ -104,7 +104,7 @@
      * 
      * @since 2.3
      */
-    private static ThreadLocal registry = new ThreadLocal() {
+    private static final ThreadLocal registry = new ThreadLocal() {
         protected Object initialValue() {
             // The HashSet implementation is not synchronized,
             // which is just what we need here.

Modified: commons/proper/lang/branches/LANG_2_X/src/main/java/org/apache/commons/lang/builder/ToStringStyle.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/branches/LANG_2_X/src/main/java/org/apache/commons/lang/builder/ToStringStyle.java?rev=904212&r1=904211&r2=904212&view=diff
==============================================================================
--- commons/proper/lang/branches/LANG_2_X/src/main/java/org/apache/commons/lang/builder/ToStringStyle.java (original)
+++ commons/proper/lang/branches/LANG_2_X/src/main/java/org/apache/commons/lang/builder/ToStringStyle.java Thu Jan 28 18:46:25 2010
@@ -133,7 +133,7 @@
      * to detect cyclical object references and avoid infinite loops.
      * </p>
      */
-    private static ThreadLocal registry = new ThreadLocal() {
+    private static final ThreadLocal registry = new ThreadLocal() {
         protected Object initialValue() {
             // The HashSet implementation is not synchronized,
             // which is just what we need here.