You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Tech-Circle-48 (via GitHub)" <gi...@apache.org> on 2024/02/27 09:11:32 UTC
[PR] add error log [doris]
Tech-Circle-48 opened a new pull request, #31469:
URL: https://github.com/apache/doris/pull/31469
## Proposed changes
Issue Number: 31441
Solved core dump caused by Log(FATAL)
## Further comments
LOG(FATAL) in Doris_main.cpp changed to LOG(ERROR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] add error log [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31469:
URL: https://github.com/apache/doris/pull/31469#issuecomment-1968074945
TeamCity be ut coverage result:
Function Coverage: 35.69% (8548/23951)
Line Coverage: 27.49% (69383/252395)
Region Coverage: 26.65% (35979/134991)
Branch Coverage: 23.46% (18392/78388)
Coverage Report: http://coverage.selectdb-in.cc/coverage/b55a89973774df8f308f81d72d862a0ee41677c9_b55a89973774df8f308f81d72d862a0ee41677c9/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] add error log [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31469:
URL: https://github.com/apache/doris/pull/31469#issuecomment-1966143916
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] add error log [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31469:
URL: https://github.com/apache/doris/pull/31469#issuecomment-1968069948
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] add error log [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31469:
URL: https://github.com/apache/doris/pull/31469#issuecomment-1968571610
TeamCity be ut coverage result:
Function Coverage: 35.69% (8548/23952)
Line Coverage: 27.49% (69379/252410)
Region Coverage: 26.64% (35969/135006)
Branch Coverage: 23.45% (18385/78396)
Coverage Report: http://coverage.selectdb-in.cc/coverage/b3e47ed0c276d3303d2f803bf88f59f2f810a1ea_b3e47ed0c276d3303d2f803bf88f59f2f810a1ea/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] add error log [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31469:
URL: https://github.com/apache/doris/pull/31469#issuecomment-1968650759
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] add error log [doris]
Posted by "mrhhsg (via GitHub)" <gi...@apache.org>.
mrhhsg commented on PR #31469:
URL: https://github.com/apache/doris/pull/31469#issuecomment-1968463598
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) avoid core dump caused by Log(FATAL) in doris_main.cpp [doris]
Posted by "Tech-Circle-48 (via GitHub)" <gi...@apache.org>.
Tech-Circle-48 commented on code in PR #31469:
URL: https://github.com/apache/doris/pull/31469#discussion_r1508506895
##########
be/src/service/doris_main.cpp:
##########
@@ -166,8 +166,8 @@ auto instruction_fail_to_string(InstructionFail fail) {
case InstructionFail::ARM_NEON:
ret("ARM_NEON");
}
- LOG(FATAL) << "__builtin_unreachable";
Review Comment:
now,how do i resolve the issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] add error log [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31469:
URL: https://github.com/apache/doris/pull/31469#issuecomment-1966095079
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] add error log [doris]
Posted by "mrhhsg (via GitHub)" <gi...@apache.org>.
mrhhsg commented on PR #31469:
URL: https://github.com/apache/doris/pull/31469#issuecomment-1968159715
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] add error log [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31469:
URL: https://github.com/apache/doris/pull/31469#issuecomment-1968497463
<details>
<summary>TPC-H: <b>Total hot run time: 37751 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit b3e47ed0c276d3303d2f803bf88f59f2f810a1ea, data reload: false
------ Round 1 ----------------------------------
q1 17983 4147 4135 4135
q2 2547 152 142 142
q3 11194 986 967 967
q4 4969 962 960 960
q5 8566 2872 3000 2872
q6 182 123 124 123
q7 1241 764 750 750
q8 9242 1908 2004 1908
q9 7167 6302 6226 6226
q10 8191 2498 2492 2492
q11 415 219 210 210
q12 737 302 309 302
q13 17957 3218 3198 3198
q14 275 259 248 248
q15 534 490 495 490
q16 470 412 404 404
q17 932 830 783 783
q18 6562 6003 5908 5908
q19 1571 1507 1512 1507
q20 548 278 272 272
q21 6895 3571 3571 3571
q22 802 283 290 283
Total cold run time: 108980 ms
Total hot run time: 37751 ms
----- Round 2, with runtime_filter_mode=off -----
q1 3991 3985 4010 3985
q2 304 215 212 212
q3 2961 2928 2899 2899
q4 1838 1842 1821 1821
q5 5064 5093 5096 5093
q6 198 117 117 117
q7 2138 1647 1682 1647
q8 3123 3176 3192 3176
q9 8264 8251 8261 8251
q10 6188 3661 3648 3648
q11 522 418 433 418
q12 675 515 524 515
q13 4047 3052 3073 3052
q14 284 269 254 254
q15 538 496 490 490
q16 491 471 465 465
q17 1699 1682 1671 1671
q18 7724 7534 7432 7432
q19 1657 1639 1618 1618
q20 2096 1897 1898 1897
q21 4721 4730 4611 4611
q22 515 446 443 443
Total cold run time: 59038 ms
Total hot run time: 53715 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] add error log [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31469:
URL: https://github.com/apache/doris/pull/31469#issuecomment-1968529754
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit b3e47ed0c276d3303d2f803bf88f59f2f810a1ea with default session variables
Stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc: 60 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select: 18.0 seconds inserted 10000000 Rows, about 555K ops/s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] add error log [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31469:
URL: https://github.com/apache/doris/pull/31469#issuecomment-1968271011
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] add error log [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31469:
URL: https://github.com/apache/doris/pull/31469#issuecomment-1966212870
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] add error log [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31469:
URL: https://github.com/apache/doris/pull/31469#issuecomment-1966156550
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] add error log [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31469:
URL: https://github.com/apache/doris/pull/31469#issuecomment-1968176514
TeamCity be ut coverage result:
Function Coverage: 35.69% (8548/23951)
Line Coverage: 27.49% (69378/252393)
Region Coverage: 26.65% (35977/134990)
Branch Coverage: 23.46% (18388/78388)
Coverage Report: http://coverage.selectdb-in.cc/coverage/cd17a3c98e5149f38a1ee59ac2ef698dcb10d229_cd17a3c98e5149f38a1ee59ac2ef698dcb10d229/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] add error log [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31469:
URL: https://github.com/apache/doris/pull/31469#issuecomment-1968524328
<details>
<summary>ClickBench: <b>Total hot run time: 31.95 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit b3e47ed0c276d3303d2f803bf88f59f2f810a1ea, data reload: false
query1 0.03 0.03 0.03
query2 0.06 0.02 0.02
query3 0.24 0.06 0.06
query4 1.66 0.10 0.10
query5 0.52 0.51 0.51
query6 1.29 0.67 0.68
query7 0.01 0.01 0.01
query8 0.03 0.02 0.02
query9 0.58 0.53 0.51
query10 0.57 0.57 0.55
query11 0.13 0.10 0.10
query12 0.12 0.10 0.11
query13 0.61 0.61 0.61
query14 0.79 0.79 0.80
query15 0.83 0.83 0.80
query16 0.37 0.38 0.37
query17 0.96 0.96 0.96
query18 0.26 0.26 0.26
query19 1.81 1.67 1.66
query20 0.01 0.01 0.02
query21 15.42 0.67 0.59
query22 2.82 4.23 2.37
query23 17.49 1.05 1.06
query24 2.00 0.56 0.21
query25 0.41 0.16 0.07
query26 0.16 0.15 0.16
query27 0.05 0.06 0.04
query28 12.28 0.89 0.83
query29 12.60 3.30 3.23
query30 0.62 0.51 0.51
query31 3.05 0.35 0.36
query32 3.65 0.48 0.49
query33 3.20 3.18 3.21
query34 15.36 4.76 4.71
query35 4.73 4.74 4.73
query36 1.13 1.07 1.06
query37 0.06 0.04 0.04
query38 0.04 0.02 0.03
query39 0.02 0.01 0.02
query40 0.17 0.13 0.13
query41 0.08 0.02 0.01
query42 0.03 0.02 0.02
query43 0.03 0.02 0.02
Total cold run time: 106.28 s
Total hot run time: 31.95 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] add error log [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31469:
URL: https://github.com/apache/doris/pull/31469#issuecomment-1966114480
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] add error log [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31469:
URL: https://github.com/apache/doris/pull/31469#issuecomment-1966183135
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] add error log [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31469:
URL: https://github.com/apache/doris/pull/31469#issuecomment-1968515138
<details>
<summary>TPC-DS: <b>Total hot run time: 169038 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit b3e47ed0c276d3303d2f803bf88f59f2f810a1ea, data reload: false
query1 918 342 329 329
query2 6549 1770 1796 1770
query3 6721 208 200 200
query4 23413 20544 20515 20515
query5 4294 370 365 365
query6 262 169 162 162
query7 4608 314 305 305
query8 263 190 200 190
query9 8311 2218 2197 2197
query10 422 217 224 217
query11 14772 14254 14111 14111
query12 142 83 83 83
query13 1634 444 433 433
query14 8292 6709 6344 6344
query15 207 178 178 178
query16 7075 260 253 253
query17 1043 537 499 499
query18 1914 267 264 264
query19 187 166 148 148
query20 88 83 90 83
query21 194 121 115 115
query22 4766 4703 4623 4623
query23 30531 29871 29829 29829
query24 11796 3102 3140 3102
query25 665 355 351 351
query26 1840 152 171 152
query27 3059 322 317 317
query28 7039 1794 1775 1775
query29 1232 561 573 561
query30 289 132 140 132
query31 875 681 688 681
query32 98 60 58 58
query33 718 223 221 221
query34 1050 487 500 487
query35 848 762 753 753
query36 939 881 817 817
query37 253 62 62 62
query38 3141 2979 2969 2969
query39 1306 1265 1254 1254
query40 279 105 104 104
query41 36 37 35 35
query42 108 99 100 99
query43 474 432 424 424
query44 1063 691 710 691
query45 193 179 172 172
query46 1061 819 793 793
query47 1503 1365 1430 1365
query48 424 367 370 367
query49 1184 304 290 290
query50 782 381 383 381
query51 4356 4271 4343 4271
query52 99 91 89 89
query53 350 268 264 264
query54 278 217 232 217
query55 86 81 81 81
query56 233 203 216 203
query57 929 880 873 873
query58 205 196 202 196
query59 2240 2052 2123 2052
query60 252 229 220 220
query61 83 81 83 81
query62 598 366 357 357
query63 282 263 261 261
query64 6473 3028 3148 3028
query65 3237 3213 3191 3191
query66 1436 322 318 318
query67 14523 14178 13902 13902
query68 4984 560 575 560
query69 547 413 394 394
query70 1178 1174 1275 1174
query71 391 264 257 257
query72 6164 2803 2649 2649
query73 724 327 332 327
query74 6318 5889 5938 5889
query75 3127 2461 2426 2426
query76 2776 1042 1174 1042
query77 371 233 234 233
query78 8964 8466 8496 8466
query79 1124 551 549 549
query80 924 355 362 355
query81 470 195 196 195
query82 1392 84 86 84
query83 234 120 120 120
query84 276 79 79 79
query85 1328 351 346 346
query86 366 275 290 275
query87 3253 3136 3063 3063
query88 2854 2404 2382 2382
query89 402 339 331 331
query90 1851 165 167 165
query91 170 120 137 120
query92 60 49 52 49
query93 1076 516 521 516
query94 1234 181 187 181
query95 437 339 348 339
query96 592 269 269 269
query97 4246 4129 4147 4129
query98 222 204 193 193
query99 1031 655 651 651
Total cold run time: 263607 ms
Total hot run time: 169038 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) avoid core dump caused by Log(FATAL) in doris_main.cpp [doris]
Posted by "Tech-Circle-48 (via GitHub)" <gi...@apache.org>.
Tech-Circle-48 closed pull request #31469: [fix](be) avoid core dump caused by Log(FATAL) in doris_main.cpp
URL: https://github.com/apache/doris/pull/31469
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] add error log [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31469:
URL: https://github.com/apache/doris/pull/31469#issuecomment-1968435095
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] add error log [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31469:
URL: https://github.com/apache/doris/pull/31469#issuecomment-1968436017
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) avoid core dump caused by Log(FATAL) in doris_main.cpp [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on code in PR #31469:
URL: https://github.com/apache/doris/pull/31469#discussion_r1505742591
##########
be/src/service/doris_main.cpp:
##########
@@ -166,8 +166,8 @@ auto instruction_fail_to_string(InstructionFail fail) {
case InstructionFail::ARM_NEON:
ret("ARM_NEON");
}
- LOG(FATAL) << "__builtin_unreachable";
Review Comment:
why not core dump? if returned, then it will core in other place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] add error log [doris]
Posted by "mrhhsg (via GitHub)" <gi...@apache.org>.
mrhhsg commented on PR #31469:
URL: https://github.com/apache/doris/pull/31469#issuecomment-1968036295
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] add error log [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31469:
URL: https://github.com/apache/doris/pull/31469#issuecomment-1968650687
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org