You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@isis.apache.org by ah...@apache.org on 2020/01/30 12:49:03 UTC
[isis] branch master updated: ISIS-2223: marks 2 thread-local's
deprecated (no mitigation yet)
This is an automated email from the ASF dual-hosted git repository.
ahuber pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/isis.git
The following commit(s) were added to refs/heads/master by this push:
new 291913b ISIS-2223: marks 2 thread-local's deprecated (no mitigation yet)
291913b is described below
commit 291913b3f80d8216b7e937d1509efa5939a6a087
Author: Andi Huber <ah...@apache.org>
AuthorDate: Thu Jan 30 13:48:54 2020 +0100
ISIS-2223: marks 2 thread-local's deprecated (no mitigation yet)
---
.../datejodalocal/JodaLocalDateValueSemanticsProvider.java | 10 ++++------
.../JodaLocalDateTimeValueSemanticsProvider.java | 11 ++++-------
2 files changed, 8 insertions(+), 13 deletions(-)
diff --git a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/facets/value/datejodalocal/JodaLocalDateValueSemanticsProvider.java b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/facets/value/datejodalocal/JodaLocalDateValueSemanticsProvider.java
index 967caf1..40ad524 100644
--- a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/facets/value/datejodalocal/JodaLocalDateValueSemanticsProvider.java
+++ b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/facets/value/datejodalocal/JodaLocalDateValueSemanticsProvider.java
@@ -76,12 +76,10 @@ public class JodaLocalDateValueSemanticsProvider extends ValueSemanticsProviderA
NAMED_TITLE_FORMATTERS.put("short", DateTimeFormat.forStyle("S-"));
}
- private final static ThreadLocal<String> OVERRIDE_TITLE_PATTERN = new ThreadLocal<String>() {
- @Override
- protected String initialValue() {
- return null;
- }
- };
+ /**
+ * @deprecated possible memory leak issue, because this one is never cleared up
+ */
+ private final static ThreadLocal<String> OVERRIDE_TITLE_PATTERN = ThreadLocal.withInitial(()->null);
private final static List<DateTimeFormatter> PARSE_FORMATTERS = _Lists.newArrayList();
diff --git a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/facets/value/datetimejodalocal/JodaLocalDateTimeValueSemanticsProvider.java b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/facets/value/datetimejodalocal/JodaLocalDateTimeValueSemanticsProvider.java
index c783f71..e7fa6b7 100644
--- a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/facets/value/datetimejodalocal/JodaLocalDateTimeValueSemanticsProvider.java
+++ b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/facets/value/datetimejodalocal/JodaLocalDateTimeValueSemanticsProvider.java
@@ -79,13 +79,10 @@ implements JodaLocalDateTimeValueFacet {
NAMED_TITLE_FORMATTERS.put("short", DateTimeFormat.forStyle("SS"));
}
- private final static ThreadLocal<String> OVERRIDE_TITLE_PATTERN = new ThreadLocal<String>() {
- @Override
- protected String initialValue() {
- return null;
- }
- };
-
+ /**
+ * @deprecated possible memory leak issue, because this one is never cleared up
+ */
+ private final static ThreadLocal<String> OVERRIDE_TITLE_PATTERN = ThreadLocal.withInitial(()->null);
private final static List<DateTimeFormatter> PARSE_FORMATTERS = _Lists.newArrayList();
static {