You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/11/20 00:16:11 UTC
[jira] [Commented] (STORM-1221) Create a common interface for all
Trident spout
[ https://issues.apache.org/jira/browse/STORM-1221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15014708#comment-15014708 ]
ASF GitHub Bot commented on STORM-1221:
---------------------------------------
GitHub user haohui opened a pull request:
https://github.com/apache/storm/pull/895
STORM-1221. Create a common interface for all Trident spout.
This PR marks the trident spouts with a common interface. Such a common interface allows StormSQL to manage external data sources with a unified interface.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/haohui/storm STORM-1221
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/895.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #895
----
commit a280891bafb55a3d221a8198e7e80eeb30d0250a
Author: Haohui Mai <wh...@apache.org>
Date: 2015-11-19T22:28:55Z
STORM-1221. Create a common interface for all Trident spout.
----
> Create a common interface for all Trident spout
> -----------------------------------------------
>
> Key: STORM-1221
> URL: https://issues.apache.org/jira/browse/STORM-1221
> Project: Apache Storm
> Issue Type: Bug
> Reporter: Haohui Mai
> Assignee: Haohui Mai
>
> Currently {{IBatchSpout}}, {{IOpaquePartitionSpout}}}, {{ITridentSpout}} and {{IPartitionedSpout}} are all top-level interfaces. The lowest common ancestor of their parent interface is {{Serializable}}. There is no clear, single interface in Trident to mark these class are spouts / data sources. The abstraction is beneficial when components on top of Trident (e.g. StormSQL) need a notion of data source.
> This jira proposes to tags all the spouts above with a common marker interface.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)