[GitHub] [incubator-celeborn] waitinfuture commented on a diff in pull request #1003: [CELEBORN-56] [ISSUE-945] handle map partition mapper end

[GitBox <gi...@apache.org>]

waitinfuture commented on code in PR #1003:
URL: https://github.com/apache/incubator-celeborn/pull/1003#discussion_r1037910911


##########
client/src/main/java/org/apache/celeborn/client/ShuffleClient.java:
##########
@@ -147,11 +147,21 @@ public abstract int mergeData(
   public abstract void pushMergedData(String applicationId, int shuffleId, int mapId, int attemptId)
       throws IOException;
 
-  // Report partition locations written by the completed map task
+  // Report partition locations written by the completed map task of ReducePartition Shuffle Type
   public abstract void mapperEnd(
       String applicationId, int shuffleId, int mapId, int attemptId, int numMappers)
       throws IOException;
 
+  // Report partition locations written by the completed map task of MapPartition Shuffle Type
+  public abstract void mapPartitionMapperEnd(
+      String applicationId,
+      int shuffleId,
+      int mapId,

Review Comment:
   Then



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org