You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Emerson Pinter <de...@pinter.com.br> on 2013/05/15 14:46:34 UTC

Review Request: debian: fix build of cloudstack-awsapi package

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11180/
-----------------------------------------------------------

Review request for cloudstack.


Description
-------

debian: fix build of cloudstack-awsapi package

The debian package cloudstack-awsapi is being built empty. This patch
adds the required files to the package and a symlink for webapps/awsapi so the awsapi can
be found by tomcat, without change in configuration.


This addresses bugs cloudstack-awsapi and package.


Diffs
-----

  debian/cloudstack-awsapi.install 02ba668 
  debian/rules 793771f 

Diff: https://reviews.apache.org/r/11180/diff/


Testing
-------

Debian packages was built using CentOS 6.4, and installed in a fresh Debian 7.0 installation.


Thanks,

Emerson Pinter


Re: Review Request: debian: fix build of cloudstack-awsapi package

Posted by Chip Childers <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11180/#review20854
-----------------------------------------------------------


Wido helped sync master and 4.1.

- Chip Childers


On May 20, 2013, 3:42 p.m., Emerson Pinter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11180/
> -----------------------------------------------------------
> 
> (Updated May 20, 2013, 3:42 p.m.)
> 
> 
> Review request for cloudstack, Chip Childers, Prachi Damle, and Wido den Hollander.
> 
> 
> Description
> -------
> 
> debian: fix build of cloudstack-awsapi package
> 
> The debian package cloudstack-awsapi is being built empty. This patch
> adds the required files to the package and a symlink for webapps/awsapi so the awsapi can
> be found by tomcat, without change in configuration.
> 
> 
> This addresses bugs cloudstack-awsapi and package.
> 
> 
> Diffs
> -----
> 
>   debian/cloudstack-awsapi.install 02ba668 
>   debian/rules 793771f 
> 
> Diff: https://reviews.apache.org/r/11180/diff/
> 
> 
> Testing
> -------
> 
> Debian packages was built using CentOS 6.4, and installed in a fresh Debian 7.0 installation.
> 
> 
> Thanks,
> 
> Emerson Pinter
> 
>


Re: Review Request: debian: fix build of cloudstack-awsapi package

Posted by Chip Childers <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11180/
-----------------------------------------------------------

(Updated May 20, 2013, 3:42 p.m.)


Review request for cloudstack, Chip Childers, Prachi Damle, and Wido den Hollander.


Description
-------

debian: fix build of cloudstack-awsapi package

The debian package cloudstack-awsapi is being built empty. This patch
adds the required files to the package and a symlink for webapps/awsapi so the awsapi can
be found by tomcat, without change in configuration.


This addresses bugs cloudstack-awsapi and package.


Diffs
-----

  debian/cloudstack-awsapi.install 02ba668 
  debian/rules 793771f 

Diff: https://reviews.apache.org/r/11180/diff/


Testing
-------

Debian packages was built using CentOS 6.4, and installed in a fresh Debian 7.0 installation.


Thanks,

Emerson Pinter


Re: Review Request: debian: fix build of cloudstack-awsapi package

Posted by Chip Childers <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11180/
-----------------------------------------------------------

(Updated May 20, 2013, 3:42 p.m.)


Review request for cloudstack, Prachi Damle and Wido den Hollander.


Description
-------

debian: fix build of cloudstack-awsapi package

The debian package cloudstack-awsapi is being built empty. This patch
adds the required files to the package and a symlink for webapps/awsapi so the awsapi can
be found by tomcat, without change in configuration.


This addresses bugs cloudstack-awsapi and package.


Diffs
-----

  debian/cloudstack-awsapi.install 02ba668 
  debian/rules 793771f 

Diff: https://reviews.apache.org/r/11180/diff/


Testing
-------

Debian packages was built using CentOS 6.4, and installed in a fresh Debian 7.0 installation.


Thanks,

Emerson Pinter


Re: Review Request: debian: fix build of cloudstack-awsapi package

Posted by Chip Childers <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11180/#review20771
-----------------------------------------------------------


Applied to 4.1.

However, master seems to be out of sync with 4.1 right now, so cherry-picking failed.

- Chip Childers


On May 17, 2013, 5:24 a.m., Emerson Pinter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11180/
> -----------------------------------------------------------
> 
> (Updated May 17, 2013, 5:24 a.m.)
> 
> 
> Review request for cloudstack, Prachi Damle and Wido den Hollander.
> 
> 
> Description
> -------
> 
> debian: fix build of cloudstack-awsapi package
> 
> The debian package cloudstack-awsapi is being built empty. This patch
> adds the required files to the package and a symlink for webapps/awsapi so the awsapi can
> be found by tomcat, without change in configuration.
> 
> 
> This addresses bugs cloudstack-awsapi and package.
> 
> 
> Diffs
> -----
> 
>   debian/cloudstack-awsapi.install 02ba668 
>   debian/rules 793771f 
> 
> Diff: https://reviews.apache.org/r/11180/diff/
> 
> 
> Testing
> -------
> 
> Debian packages was built using CentOS 6.4, and installed in a fresh Debian 7.0 installation.
> 
> 
> Thanks,
> 
> Emerson Pinter
> 
>


Re: Review Request: debian: fix build of cloudstack-awsapi package

Posted by Animesh Chaturvedi <An...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11180/
-----------------------------------------------------------

(Updated May 17, 2013, 5:24 a.m.)


Review request for cloudstack, Prachi Damle and Wido den Hollander.


Changes
-------

Please check the review board guidelines at https://cwiki.apache.org/confluence/display/CLOUDSTACK/Review+Board+Guidelines on hoe we use ReviewBoard. Here is another link of CloudStack maintainers by components that you can refer to identify who should review your patch

https://cwiki.apache.org/confluence/display/CLOUDSTACK/Current+Maintainers+Per+Component. 

I have added Prachi and Widoh as reviewers


Description
-------

debian: fix build of cloudstack-awsapi package

The debian package cloudstack-awsapi is being built empty. This patch
adds the required files to the package and a symlink for webapps/awsapi so the awsapi can
be found by tomcat, without change in configuration.


This addresses bugs cloudstack-awsapi and package.


Diffs
-----

  debian/cloudstack-awsapi.install 02ba668 
  debian/rules 793771f 

Diff: https://reviews.apache.org/r/11180/diff/


Testing
-------

Debian packages was built using CentOS 6.4, and installed in a fresh Debian 7.0 installation.


Thanks,

Emerson Pinter