You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@beam.apache.org by "Scott Wegner (JIRA)" <ji...@apache.org> on 2016/04/14 22:24:25 UTC

[jira] [Commented] (BEAM-195) Rename DisplayDataMatchers#includes

    [ https://issues.apache.org/jira/browse/BEAM-195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15241830#comment-15241830 ] 

Scott Wegner commented on BEAM-195:
-----------------------------------

Tracking this here instead of implementing right away as to avoid complicated merge with pending PR's.

> Rename DisplayDataMatchers#includes
> -----------------------------------
>
>                 Key: BEAM-195
>                 URL: https://issues.apache.org/jira/browse/BEAM-195
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-java-core
>            Reporter: Scott Wegner
>            Assignee: Davor Bonaci
>            Priority: Trivial
>
> Based on [review feedback|https://github.com/apache/incubator-beam/pull/125#discussion_r59381894], we can improve the name of {{DisplayDataMatchers.includes(HasDisplayData)}} to make the usage more clear. Something like:
> bq. {{assertThat(displayData, includesDisplayDataFrom(fn));}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)