You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Jarek Gawor (JIRA)" <ji...@apache.org> on 2011/04/27 21:52:03 UTC
[jira] [Created] (GERONIMO-5939) Support OBR resolution during
bundle install
Support OBR resolution during bundle install
--------------------------------------------
Key: GERONIMO-5939
URL: https://issues.apache.org/jira/browse/GERONIMO-5939
Project: Geronimo
Issue Type: New Feature
Security Level: public (Regular issues)
Components: deployment, osgi
Affects Versions: 3.0-M1
Reporter: Jarek Gawor
When installing an individual bundle (via the admin console, command line or shell) provide an option to perform OBR resolution to install the dependent bundles.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] [Commented] (GERONIMO-5939) Support OBR resolution during
bundle install
Posted by Rex Wang <rw...@gmail.com>.
John, you should reply in the jira comments, not in the mailing list
directly.
And we won't implement obr in geronimo, we used the implementation of felix.
If they missed something, we need push them to improve their implementation
or commit a patch in their community.
-Rex
2011/7/21 Yi Xiao <xi...@gmail.com>
> I thought we need to implement a new orb api~
> OK, that will be easier for me to use Felix's obr api to manage the bundle
> repository, do I need to create a new plugin in Geronimo to implement the
> function?
> Thx~
>
>
> On Thu, Jul 21, 2011 at 1:36 PM, Jarek Gawor (JIRA) <ji...@apache.org>wrote:
>
>>
>> [
>> https://issues.apache.org/jira/browse/GERONIMO-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13068810#comment-13068810]
>>
>> Jarek Gawor commented on GERONIMO-5939:
>> ---------------------------------------
>>
>> geronimo-obr is just a module that builds OBR's repository.xml from the
>> modules in the repository/ directory. It is not OBR implementation. The OBR
>> implementation is provided by Felix's bundlerepository module.
>>
>>
>> > Support OBR resolution during bundle install
>> > --------------------------------------------
>> >
>> > Key: GERONIMO-5939
>> > URL:
>> https://issues.apache.org/jira/browse/GERONIMO-5939
>> > Project: Geronimo
>> > Issue Type: New Feature
>> > Security Level: public(Regular issues)
>> > Components: deployment, osgi
>> > Affects Versions: 3.0-M1
>> > Reporter: Jarek Gawor
>> >
>> > When installing an individual bundle (via the admin console, command
>> line or shell) provide an option to perform OBR resolution to install the
>> dependent bundles.
>>
>> --
>> This message is automatically generated by JIRA.
>> For more information on JIRA, see: http://www.atlassian.com/software/jira
>>
>>
>>
>
>
> --
> Best regards!
>
>
> John Xiao
>
>
--
Lei Wang (Rex)
rwonly AT apache.org
Re: [jira] [Commented] (GERONIMO-5939) Support OBR resolution during
bundle install
Posted by Yi Xiao <xi...@gmail.com>.
I thought we need to implement a new orb api~
OK, that will be easier for me to use Felix's obr api to manage the bundle
repository, do I need to create a new plugin in Geronimo to implement the
function?
Thx~
On Thu, Jul 21, 2011 at 1:36 PM, Jarek Gawor (JIRA) <ji...@apache.org> wrote:
>
> [
> https://issues.apache.org/jira/browse/GERONIMO-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13068810#comment-13068810]
>
> Jarek Gawor commented on GERONIMO-5939:
> ---------------------------------------
>
> geronimo-obr is just a module that builds OBR's repository.xml from the
> modules in the repository/ directory. It is not OBR implementation. The OBR
> implementation is provided by Felix's bundlerepository module.
>
>
> > Support OBR resolution during bundle install
> > --------------------------------------------
> >
> > Key: GERONIMO-5939
> > URL: https://issues.apache.org/jira/browse/GERONIMO-5939
> > Project: Geronimo
> > Issue Type: New Feature
> > Security Level: public(Regular issues)
> > Components: deployment, osgi
> > Affects Versions: 3.0-M1
> > Reporter: Jarek Gawor
> >
> > When installing an individual bundle (via the admin console, command line
> or shell) provide an option to perform OBR resolution to install the
> dependent bundles.
>
> --
> This message is automatically generated by JIRA.
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>
>
--
Best regards!
John Xiao
[jira] [Commented] (GERONIMO-5939) Support OBR resolution during
bundle install
Posted by "Yi Xiao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13082079#comment-13082079 ]
Yi Xiao commented on GERONIMO-5939:
-----------------------------------
Ok, thanks for your reminder~
I will test it ASAP!
> Support OBR resolution during bundle install
> --------------------------------------------
>
> Key: GERONIMO-5939
> URL: https://issues.apache.org/jira/browse/GERONIMO-5939
> Project: Geronimo
> Issue Type: New Feature
> Security Level: public(Regular issues)
> Components: deployment, osgi
> Affects Versions: 3.0-M1
> Reporter: Jarek Gawor
> Assignee: Rex Wang
> Attachments: GERONIMO-5939-core.patch, GeronimoOBR_5939.patch
>
>
> When installing an individual bundle (via the admin console, command line or shell) provide an option to perform OBR resolution to install the dependent bundles.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (GERONIMO-5939) Support OBR resolution during
bundle install
Posted by "Rex Wang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rex Wang reassigned GERONIMO-5939:
----------------------------------
Assignee: Rex Wang
> Support OBR resolution during bundle install
> --------------------------------------------
>
> Key: GERONIMO-5939
> URL: https://issues.apache.org/jira/browse/GERONIMO-5939
> Project: Geronimo
> Issue Type: New Feature
> Security Level: public(Regular issues)
> Components: deployment, osgi
> Affects Versions: 3.0-M1
> Reporter: Jarek Gawor
> Assignee: Rex Wang
> Attachments: GeronimoOBR_5939.patch
>
>
> When installing an individual bundle (via the admin console, command line or shell) provide an option to perform OBR resolution to install the dependent bundles.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GERONIMO-5939) Support OBR resolution during
bundle install
Posted by "Yi Xiao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13070359#comment-13070359 ]
Yi Xiao commented on GERONIMO-5939:
-----------------------------------
I notice that the geronimo3.0 already has the function of installing a bundle with its dependencies through karaf shell:
obr:deploy 'bundle-identifier'.
The defect is karaf does not persist the bundle and its dependencies into geronimo's local repository.
So, I design a senario:
1 The user use a command(not exist yet),
geronimo: obr-deploy 'bundle-identifier'
to deploy a bundle which has the desc infos in obr.xml(include the referring repositories).
2 The obr-deploy command will resolve the bundle by obr's resolve API of Felix.
3 If the dependencies are satisfied, will download the bundles from remote sites and use the geronimo install bundle API to deploy the bundle into local repository and write the info into 'etc/startup.properties', otherwise, will just log the fail message into log.
> Support OBR resolution during bundle install
> --------------------------------------------
>
> Key: GERONIMO-5939
> URL: https://issues.apache.org/jira/browse/GERONIMO-5939
> Project: Geronimo
> Issue Type: New Feature
> Security Level: public(Regular issues)
> Components: deployment, osgi
> Affects Versions: 3.0-M1
> Reporter: Jarek Gawor
>
> When installing an individual bundle (via the admin console, command line or shell) provide an option to perform OBR resolution to install the dependent bundles.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GERONIMO-5939) Support OBR resolution during
bundle install
Posted by "Rex Wang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13081467#comment-13081467 ]
Rex Wang commented on GERONIMO-5939:
------------------------------------
hi, Xiao Yi, thanks for the patch.
I refactored your solution and uploaded my GERONIMO-5939-core.patch in the attachment.
However, I did not get a chance to test it, could you please review and help test?
And please note:
1. create your patch from the root folder of trunk.
2. always use 4 spaces to replace a tab. (don't forget pom.xml ;-))
-Rex
> Support OBR resolution during bundle install
> --------------------------------------------
>
> Key: GERONIMO-5939
> URL: https://issues.apache.org/jira/browse/GERONIMO-5939
> Project: Geronimo
> Issue Type: New Feature
> Security Level: public(Regular issues)
> Components: deployment, osgi
> Affects Versions: 3.0-M1
> Reporter: Jarek Gawor
> Assignee: Rex Wang
> Attachments: GERONIMO-5939-core.patch, GeronimoOBR_5939.patch
>
>
> When installing an individual bundle (via the admin console, command line or shell) provide an option to perform OBR resolution to install the dependent bundles.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GERONIMO-5939) Support OBR resolution during
bundle install
Posted by "Yi Xiao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13073483#comment-13073483 ]
Yi Xiao commented on GERONIMO-5939:
-----------------------------------
According to the senario above, provide Three karaf shell commands:
1 obr:geronimo-addUrl 'URL of the repo file'
2 obr:geronimo-install 'symbolicName,version'
3 obr:geronimo-uninstall 'symbolicName,version'
The geronimo-install command also can take optional parameters to indicate whether to start the bundle and assign the bundle's start level.
The geronimo-uninstall command matches the install one, if you want to reinstall the obr bundles by no restart server, you should use geronimo-uninstall instead of osgi:uninstall
> Support OBR resolution during bundle install
> --------------------------------------------
>
> Key: GERONIMO-5939
> URL: https://issues.apache.org/jira/browse/GERONIMO-5939
> Project: Geronimo
> Issue Type: New Feature
> Security Level: public(Regular issues)
> Components: deployment, osgi
> Affects Versions: 3.0-M1
> Reporter: Jarek Gawor
> Attachments: GeronimoOBR_5939.patch
>
>
> When installing an individual bundle (via the admin console, command line or shell) provide an option to perform OBR resolution to install the dependent bundles.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GERONIMO-5939) Support OBR resolution during
bundle install
Posted by "Yi Xiao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13068797#comment-13068797 ]
Yi Xiao commented on GERONIMO-5939:
-----------------------------------
According to the spec of OSGI rfc-0112, the geronimo-obr does not support all the obr's functions, such as no repository admin to communicate with other repositories, no resolver to deploy a new bundle into local repository.
So I think it need to reconstruct the code, and add the functions mentioned above.
> Support OBR resolution during bundle install
> --------------------------------------------
>
> Key: GERONIMO-5939
> URL: https://issues.apache.org/jira/browse/GERONIMO-5939
> Project: Geronimo
> Issue Type: New Feature
> Security Level: public(Regular issues)
> Components: deployment, osgi
> Affects Versions: 3.0-M1
> Reporter: Jarek Gawor
>
> When installing an individual bundle (via the admin console, command line or shell) provide an option to perform OBR resolution to install the dependent bundles.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GERONIMO-5939) Support OBR resolution during
bundle install
Posted by "Jarek Gawor (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13068810#comment-13068810 ]
Jarek Gawor commented on GERONIMO-5939:
---------------------------------------
geronimo-obr is just a module that builds OBR's repository.xml from the modules in the repository/ directory. It is not OBR implementation. The OBR implementation is provided by Felix's bundlerepository module.
> Support OBR resolution during bundle install
> --------------------------------------------
>
> Key: GERONIMO-5939
> URL: https://issues.apache.org/jira/browse/GERONIMO-5939
> Project: Geronimo
> Issue Type: New Feature
> Security Level: public(Regular issues)
> Components: deployment, osgi
> Affects Versions: 3.0-M1
> Reporter: Jarek Gawor
>
> When installing an individual bundle (via the admin console, command line or shell) provide an option to perform OBR resolution to install the dependent bundles.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GERONIMO-5939) Support OBR resolution during
bundle install
Posted by "Yi Xiao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yi Xiao updated GERONIMO-5939:
------------------------------
Attachment: GeronimoOBR_5939.patch
> Support OBR resolution during bundle install
> --------------------------------------------
>
> Key: GERONIMO-5939
> URL: https://issues.apache.org/jira/browse/GERONIMO-5939
> Project: Geronimo
> Issue Type: New Feature
> Security Level: public(Regular issues)
> Components: deployment, osgi
> Affects Versions: 3.0-M1
> Reporter: Jarek Gawor
> Attachments: GeronimoOBR_5939.patch
>
>
> When installing an individual bundle (via the admin console, command line or shell) provide an option to perform OBR resolution to install the dependent bundles.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GERONIMO-5939) Support OBR resolution during
bundle install
Posted by "Yi Xiao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yi Xiao updated GERONIMO-5939:
------------------------------
Attachment: GERONIMO_5939_core_modify2.patch
The newest patch is GERONIMO_5939_core_modify2.patch
> Support OBR resolution during bundle install
> --------------------------------------------
>
> Key: GERONIMO-5939
> URL: https://issues.apache.org/jira/browse/GERONIMO-5939
> Project: Geronimo
> Issue Type: New Feature
> Security Level: public(Regular issues)
> Components: deployment, osgi
> Affects Versions: 3.0-M1
> Reporter: Jarek Gawor
> Assignee: Rex Wang
> Attachments: GERONIMO-5939-core.patch, GERONIMO_5939_core_modify.patch, GERONIMO_5939_core_modify2.patch, GeronimoOBR_5939.patch
>
>
> When installing an individual bundle (via the admin console, command line or shell) provide an option to perform OBR resolution to install the dependent bundles.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GERONIMO-5939) Support OBR resolution during
bundle install
Posted by "Forrest Xia (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Forrest Xia updated GERONIMO-5939:
----------------------------------
Fix Version/s: (was: 3.0.0)
3.0.1
> Support OBR resolution during bundle install
> --------------------------------------------
>
> Key: GERONIMO-5939
> URL: https://issues.apache.org/jira/browse/GERONIMO-5939
> Project: Geronimo
> Issue Type: New Feature
> Security Level: public(Regular issues)
> Components: deployment, osgi
> Affects Versions: 3.0-M1
> Reporter: Jarek Gawor
> Assignee: Rex Wang
> Fix For: 3.0.1
>
> Attachments: GERONIMO_5939_core_modify2.patch, GERONIMO_5939_core_modify.patch, GERONIMO-5939-core.patch, GeronimoOBR_5939.patch
>
>
> When installing an individual bundle (via the admin console, command line or shell) provide an option to perform OBR resolution to install the dependent bundles.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GERONIMO-5939) Support OBR resolution during
bundle install
Posted by "Rex Wang (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rex Wang updated GERONIMO-5939:
-------------------------------
Fix Version/s: 3.0
> Support OBR resolution during bundle install
> --------------------------------------------
>
> Key: GERONIMO-5939
> URL: https://issues.apache.org/jira/browse/GERONIMO-5939
> Project: Geronimo
> Issue Type: New Feature
> Security Level: public(Regular issues)
> Components: deployment, osgi
> Affects Versions: 3.0-M1
> Reporter: Jarek Gawor
> Assignee: Rex Wang
> Fix For: 3.0
>
> Attachments: GERONIMO-5939-core.patch, GERONIMO_5939_core_modify.patch, GERONIMO_5939_core_modify2.patch, GeronimoOBR_5939.patch
>
>
> When installing an individual bundle (via the admin console, command line or shell) provide an option to perform OBR resolution to install the dependent bundles.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GERONIMO-5939) Support OBR resolution during
bundle install
Posted by "Rex Wang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rex Wang updated GERONIMO-5939:
-------------------------------
Attachment: GERONIMO-5939-core.patch
> Support OBR resolution during bundle install
> --------------------------------------------
>
> Key: GERONIMO-5939
> URL: https://issues.apache.org/jira/browse/GERONIMO-5939
> Project: Geronimo
> Issue Type: New Feature
> Security Level: public(Regular issues)
> Components: deployment, osgi
> Affects Versions: 3.0-M1
> Reporter: Jarek Gawor
> Assignee: Rex Wang
> Attachments: GERONIMO-5939-core.patch, GeronimoOBR_5939.patch
>
>
> When installing an individual bundle (via the admin console, command line or shell) provide an option to perform OBR resolution to install the dependent bundles.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GERONIMO-5939) Support OBR resolution during
bundle install
Posted by "Yi Xiao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yi Xiao updated GERONIMO-5939:
------------------------------
Attachment: GERONIMO_5939_core_modify.patch
Hi Rex, I've test your patch, it works fine!
I make a little modification, you could review it.
> Support OBR resolution during bundle install
> --------------------------------------------
>
> Key: GERONIMO-5939
> URL: https://issues.apache.org/jira/browse/GERONIMO-5939
> Project: Geronimo
> Issue Type: New Feature
> Security Level: public(Regular issues)
> Components: deployment, osgi
> Affects Versions: 3.0-M1
> Reporter: Jarek Gawor
> Assignee: Rex Wang
> Attachments: GERONIMO-5939-core.patch, GERONIMO_5939_core_modify.patch, GeronimoOBR_5939.patch
>
>
> When installing an individual bundle (via the admin console, command line or shell) provide an option to perform OBR resolution to install the dependent bundles.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GERONIMO-5939) Support OBR resolution during
bundle install
Posted by "Jarek Gawor (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13082923#comment-13082923 ]
Jarek Gawor commented on GERONIMO-5939:
---------------------------------------
A few comments:
1) Don't forget about the license headers.
2) The geronimo-addUrl shell command and related code is unnecessary. There is already obr:addurl operation.
3) When doing geronimo-install would be good to also specify whether the optional resources should also be downloaded and installed.
4) Can't ThreadPool be injected into ObrBundleInstallerGBean just like the repository is (instead of doing Kernel lookup)?
5) GeronimoGBean could also be injected instead of doing OSGi service lookup.
6) You shouldn't need to add LOCAL_OBR into repository. That's what GeronimoOBRGBean does already.
7) The filter created in ObrUtils.searchRepository() essentially specifies to find a bundle with the given symbolic name and the _minimal_ version. That is, for example, the user specified foo,1.0 but the install might result in installing foo,2.0. I think we want to match the _exact_ version. Or maybe we want to support version ranges.
8) The way the code currently decides whether the resource is "local" or not is not very reliable. So we might need to find another way or improve Felix OBR.
> Support OBR resolution during bundle install
> --------------------------------------------
>
> Key: GERONIMO-5939
> URL: https://issues.apache.org/jira/browse/GERONIMO-5939
> Project: Geronimo
> Issue Type: New Feature
> Security Level: public(Regular issues)
> Components: deployment, osgi
> Affects Versions: 3.0-M1
> Reporter: Jarek Gawor
> Assignee: Rex Wang
> Attachments: GERONIMO-5939-core.patch, GERONIMO_5939_core_modify.patch, GeronimoOBR_5939.patch
>
>
> When installing an individual bundle (via the admin console, command line or shell) provide an option to perform OBR resolution to install the dependent bundles.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira