You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by "Yichen Zhou (JIRA)" <ji...@apache.org> on 2018/10/30 07:29:00 UTC
[jira] [Commented] (KYLIN-3582) String comparison should not use ==
in RecordEvent
[ https://issues.apache.org/jira/browse/KYLIN-3582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16668279#comment-16668279 ]
Yichen Zhou commented on KYLIN-3582:
------------------------------------
I verified this. It is fixed now.
> String comparison should not use == in RecordEvent
> --------------------------------------------------
>
> Key: KYLIN-3582
> URL: https://issues.apache.org/jira/browse/KYLIN-3582
> Project: Kylin
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: XiaoXiang Yu
> Priority: Minor
> Fix For: v2.4.2, v2.5.1
>
>
> Here is related code:
> {code}
> for (RecordReserveKeyEnum reserveKey : RecordReserveKeyEnum.values()) {
> if (reserveKey.reserveKey == key) {
> {code}
> equals() should be used to compare Strings.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)