You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Anshul Gangwar <an...@citrix.com> on 2014/04/15 10:44:41 UTC
Review Request 20365: CLOUDSTACK-6411: some files are not loading in visual
studio due to license header at top making them unparsable
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20365/
-----------------------------------------------------------
Review request for cloudstack, Devdeep Singh and Rajesh Battala.
Bugs: CLOUDSTACK-6411
https://issues.apache.org/jira/browse/CLOUDSTACK-6411
Repository: cloudstack-git
Description
-------
some files are not loading in visual studio due to license header at top making them unparsable. removed the license header and put them in exclude list of rat plugin
Diffs
-----
plugins/hypervisors/hyperv/DotNet/ServerResource/.nuget/NuGet.Config 5181cb8
plugins/hypervisors/hyperv/DotNet/ServerResource/AgentShell/AgentSettings.settings fb5b962
pom.xml 6837717
Diff: https://reviews.apache.org/r/20365/diff/
Testing
-------
verified with rat plugin that the license check is passed successfully
Thanks,
Anshul Gangwar
Re: Review Request 20365: CLOUDSTACK-6411: some files are not loading in
visual studio due to license header at top making them unparsable
Posted by Devdeep Singh <de...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20365/#review40873
-----------------------------------------------------------
Ship it!
Ship It!
- Devdeep Singh
On April 15, 2014, 8:44 a.m., Anshul Gangwar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20365/
> -----------------------------------------------------------
>
> (Updated April 15, 2014, 8:44 a.m.)
>
>
> Review request for cloudstack, Devdeep Singh and Rajesh Battala.
>
>
> Bugs: CLOUDSTACK-6411
> https://issues.apache.org/jira/browse/CLOUDSTACK-6411
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> some files are not loading in visual studio due to license header at top making them unparsable. removed the license header and put them in exclude list of rat plugin
>
>
> Diffs
> -----
>
> plugins/hypervisors/hyperv/DotNet/ServerResource/.nuget/NuGet.Config 5181cb8
> plugins/hypervisors/hyperv/DotNet/ServerResource/AgentShell/AgentSettings.settings fb5b962
> pom.xml 6837717
>
> Diff: https://reviews.apache.org/r/20365/diff/
>
>
> Testing
> -------
>
> verified with rat plugin that the license check is passed successfully
>
>
> Thanks,
>
> Anshul Gangwar
>
>
Re: Review Request 20365: CLOUDSTACK-6411: some files are not loading in
visual studio due to license header at top making them unparsable
Posted by daan Hoogland <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20365/#review40388
-----------------------------------------------------------
plugins/hypervisors/hyperv/DotNet/ServerResource/.nuget/NuGet.Config
<https://reviews.apache.org/r/20365/#comment73372>
Did you check if it worked with the license header below the xml header?
- daan Hoogland
On April 15, 2014, 8:44 a.m., Anshul Gangwar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20365/
> -----------------------------------------------------------
>
> (Updated April 15, 2014, 8:44 a.m.)
>
>
> Review request for cloudstack, Devdeep Singh and Rajesh Battala.
>
>
> Bugs: CLOUDSTACK-6411
> https://issues.apache.org/jira/browse/CLOUDSTACK-6411
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> some files are not loading in visual studio due to license header at top making them unparsable. removed the license header and put them in exclude list of rat plugin
>
>
> Diffs
> -----
>
> plugins/hypervisors/hyperv/DotNet/ServerResource/.nuget/NuGet.Config 5181cb8
> plugins/hypervisors/hyperv/DotNet/ServerResource/AgentShell/AgentSettings.settings fb5b962
> pom.xml 6837717
>
> Diff: https://reviews.apache.org/r/20365/diff/
>
>
> Testing
> -------
>
> verified with rat plugin that the license check is passed successfully
>
>
> Thanks,
>
> Anshul Gangwar
>
>
Re: Review Request 20365: CLOUDSTACK-6411: some files are not loading in
visual studio due to license header at top making them unparsable
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20365/#review40760
-----------------------------------------------------------
Commit 7d6712c05e03122dc461f5d524126619cf19f7d1 in cloudstack's branch refs/heads/4.4 from Anshul Gangwar
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=7d6712c ]
CLOUDSTACK-6411: removing license header from nuget.config and agent settings file, with
the header they are not getting loaded properly. Added an exception to not to do rat
checks on these files.
- ASF Subversion and Git Services
On April 15, 2014, 8:44 a.m., Anshul Gangwar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20365/
> -----------------------------------------------------------
>
> (Updated April 15, 2014, 8:44 a.m.)
>
>
> Review request for cloudstack, Devdeep Singh and Rajesh Battala.
>
>
> Bugs: CLOUDSTACK-6411
> https://issues.apache.org/jira/browse/CLOUDSTACK-6411
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> some files are not loading in visual studio due to license header at top making them unparsable. removed the license header and put them in exclude list of rat plugin
>
>
> Diffs
> -----
>
> plugins/hypervisors/hyperv/DotNet/ServerResource/.nuget/NuGet.Config 5181cb8
> plugins/hypervisors/hyperv/DotNet/ServerResource/AgentShell/AgentSettings.settings fb5b962
> pom.xml 6837717
>
> Diff: https://reviews.apache.org/r/20365/diff/
>
>
> Testing
> -------
>
> verified with rat plugin that the license check is passed successfully
>
>
> Thanks,
>
> Anshul Gangwar
>
>
Re: Review Request 20365: CLOUDSTACK-6411: some files are not loading in
visual studio due to license header at top making them unparsable
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20365/#review40870
-----------------------------------------------------------
Commit 455d2b328433178cbeacf5ce5f8f600efb623868 in cloudstack's branch refs/heads/master from Anshul Gangwar
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=455d2b3 ]
CLOUDSTACK-6411: removing license header from nuget.config and agent settings file, with
the header they are not getting loaded properly. Added an exception to not to do rat
checks on these files.
- ASF Subversion and Git Services
On April 15, 2014, 8:44 a.m., Anshul Gangwar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20365/
> -----------------------------------------------------------
>
> (Updated April 15, 2014, 8:44 a.m.)
>
>
> Review request for cloudstack, Devdeep Singh and Rajesh Battala.
>
>
> Bugs: CLOUDSTACK-6411
> https://issues.apache.org/jira/browse/CLOUDSTACK-6411
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> some files are not loading in visual studio due to license header at top making them unparsable. removed the license header and put them in exclude list of rat plugin
>
>
> Diffs
> -----
>
> plugins/hypervisors/hyperv/DotNet/ServerResource/.nuget/NuGet.Config 5181cb8
> plugins/hypervisors/hyperv/DotNet/ServerResource/AgentShell/AgentSettings.settings fb5b962
> pom.xml 6837717
>
> Diff: https://reviews.apache.org/r/20365/diff/
>
>
> Testing
> -------
>
> verified with rat plugin that the license check is passed successfully
>
>
> Thanks,
>
> Anshul Gangwar
>
>