You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by "lianetm (via GitHub)" <gi...@apache.org> on 2023/09/20 19:48:18 UTC

[GitHub] [kafka] lianetm commented on pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

lianetm commented on PR #14364:
URL: https://github.com/apache/kafka/pull/14364#issuecomment-1728333915

   Hey @philipnee, thanks for the changes! I completed another pass to all the non-test files. Agree with the move of the error handling to the HB manager but left a few other comments. 
   
   I will wait for the fixes to the failing tests and then I will go over the test files. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org