You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "martinzink (via GitHub)" <gi...@apache.org> on 2026/08/18 08:47:40 UTC
[PR] MINIFICPP-2878 PRs from apache should not double run CI [nifi-minifi-cpp]
martinzink opened a new pull request, #2248:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2248
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically main)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINIFICPP-2878 PRs from apache should not double run CI [nifi-minifi-cpp]
Posted by "martinzink (via GitHub)" <gi...@apache.org>.
martinzink merged PR #2248:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2248
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINIFICPP-2878 PRs from apache should not double run CI [nifi-minifi-cpp]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #2248:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2248#discussion_r3807116322
##########
.github/workflows/ci.yml:
##########
@@ -17,8 +17,17 @@ env:
-DENABLE_ELASTICSEARCH=ON -DENABLE_GRAFANA_LOKI=ON -DENABLE_COUCHBASE=ON -DENABLE_LLAMACPP=ON -DDOCKER_BUILD_ONLY=ON -DMINIFI_PERFORMANCE_TESTS=ON -DMINIFI_RUST=OFF -DDOCKER_USE_CONAN=ON \
-DDOCKER_NIFI_CONAN_USER=${{ secrets.CONAN_USERNAME }} -DDOCKER_NIFI_CONAN_PASSWORD=${{ secrets.CONAN_ACCESS_TOKEN }}
jobs:
+ check_trigger:
+ if: >-
+ github.event_name != 'push' ||
+ github.repository != 'apache/nifi-minifi-cpp' ||
+ github.ref == 'refs/heads/main'
Review Comment:
This does not prevent the suppressed `push` workflow run from entering the workflow-level concurrency group. For an Apache branch, that group is identical to the corresponding `pull_request` run's group, so a later skipped push run can still cancel the real PR CI because `cancel-in-progress` is enabled. Give suppressed pushes a distinct concurrency key (or prevent the workflow run from being created) so they cannot cancel PR validation.
##########
.github/workflows/ci.yml:
##########
@@ -17,8 +17,17 @@ env:
-DENABLE_ELASTICSEARCH=ON -DENABLE_GRAFANA_LOKI=ON -DENABLE_COUCHBASE=ON -DENABLE_LLAMACPP=ON -DDOCKER_BUILD_ONLY=ON -DMINIFI_PERFORMANCE_TESTS=ON -DMINIFI_RUST=OFF -DDOCKER_USE_CONAN=ON \
-DDOCKER_NIFI_CONAN_USER=${{ secrets.CONAN_USERNAME }} -DDOCKER_NIFI_CONAN_PASSWORD=${{ secrets.CONAN_ACCESS_TOKEN }}
jobs:
+ check_trigger:
+ if: >-
+ github.event_name != 'push' ||
+ github.repository != 'apache/nifi-minifi-cpp' ||
+ github.ref == 'refs/heads/main'
Review Comment:
The condition suppresses every non-`main` push in the Apache repository, not only duplicate pushes for branches with PRs. This also removes CI from tag pushes and direct pushes to maintenance/release branches that were covered by the unfiltered `push` trigger before this change. The gate needs to preserve non-PR push validation while excluding only the duplicate PR case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org