You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2020/03/06 19:11:47 UTC

[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2231: Slinky: use LEDs when available

apache-mynewt-bot commented on issue #2231: Slinky: use LEDs when available
URL: https://github.com/apache/mynewt-core/pull/2231#issuecomment-595917004
 
 
   
   <!-- style-bot -->
   
   ## Style check summary
   
   ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
   #### apps/slinky/src/led.c
   <details>
   
   ```diff
   @@ -38,7 +38,8 @@
    
    static STATS_SECT_DECL(gpio_stats) g_stats_gpio_toggle;
    
   -void init_led_stats()
   +void
   +init_led_stats()
    {
        g_led_pin = LED_BLINK_PIN;
        hal_gpio_init_out(g_led_pin, 1);
   @@ -50,7 +51,8 @@
        stats_register("gpio_toggle", STATS_HDR(g_stats_gpio_toggle));
    }
    
   -void toggle_led()
   +void
   +toggle_led()
    {
        static int prev_pin_state, curr_pin_state;
    
   @@ -63,13 +65,15 @@
    }
    
    #else
   -void init_led_stats()
   +void
   +init_led_stats()
    {
   -   return;
   +    return;
    }
    
   -void toggle_led()
   +void
   +toggle_led()
    {
   -   return;
   +    return;
    }
    #endif
   ```
   
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services