You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "chrisdutz (via GitHub)" <gi...@apache.org> on 2023/09/08 06:59:26 UTC

[GitHub] [iotdb] chrisdutz opened a new pull request, #11098: Fix/addressed issues with rat not being able to process the source bundle

chrisdutz opened a new pull request, #11098:
URL: https://github.com/apache/iotdb/pull/11098

   Also made sure the thrift pom is not copied to the lib directory of the assemblies
   
   The main issue of not being able to scan the source-bundle seems to have been related to having used a very old assembly plugin version. Updating resolved the issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [iotdb] HTHou commented on a diff in pull request #11098: Fix/addressed issues with rat not being able to process the source bundle

Posted by "HTHou (via GitHub)" <gi...@apache.org>.
HTHou commented on code in PR #11098:
URL: https://github.com/apache/iotdb/pull/11098#discussion_r1324010920


##########
iotdb-client/service-rpc/pom.xml:
##########
@@ -109,7 +109,7 @@
         <dependency>
             <groupId>org.apache.iotdb</groupId>
             <artifactId>tsfile</artifactId>
-            <version>${project.version}</version>
+            <version>1.3.0-SNAPSHOT</version>

Review Comment:
   If I want using `mvn versions:set -DnewVersion=xxx` to change the project version, will the version here also change to the new one?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [iotdb] HTHou commented on pull request #11098: Fix/addressed issues with rat not being able to process the source bundle

Posted by "HTHou (via GitHub)" <gi...@apache.org>.
HTHou commented on PR #11098:
URL: https://github.com/apache/iotdb/pull/11098#issuecomment-1713304465

   > @HTHou do you have an idea, why all ITs are failing?
   
   I guess that because of the change of `maven.assembly.version`, but I don't know the reason. Having a try to change it back?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [iotdb] chrisdutz commented on a diff in pull request #11098: Fix/addressed issues with rat not being able to process the source bundle

Posted by "chrisdutz (via GitHub)" <gi...@apache.org>.
chrisdutz commented on code in PR #11098:
URL: https://github.com/apache/iotdb/pull/11098#discussion_r1324596375


##########
iotdb-client/service-rpc/pom.xml:
##########
@@ -121,7 +121,7 @@
         <dependency>
             <groupId>org.apache.iotdb</groupId>
             <artifactId>iotdb-thrift</artifactId>
-            <version>${project.version}</version>
+            <version>1.3.0-SNAPSHOT</version>

Review Comment:
   Undid the change ...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [iotdb] chrisdutz commented on pull request #11098: Fix/addressed issues with rat not being able to process the source bundle

Posted by "chrisdutz (via GitHub)" <gi...@apache.org>.
chrisdutz commented on PR #11098:
URL: https://github.com/apache/iotdb/pull/11098#issuecomment-1713296168

   @HTHou do you have an idea, why all ITs are failing?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [iotdb] chrisdutz commented on pull request #11098: Fix/addressed issues with rat not being able to process the source bundle

Posted by "chrisdutz (via GitHub)" <gi...@apache.org>.
chrisdutz commented on PR #11098:
URL: https://github.com/apache/iotdb/pull/11098#issuecomment-1713326543

   Thing is that the reason for me updating that version was that the release produced slightly corrupted archives ... updating to the latest fixed that.
   
   In general we should ensure our plugins are always updated to the most recent versions, as only this way will be get support.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [iotdb] chrisdutz commented on a diff in pull request #11098: Fix/addressed issues with rat not being able to process the source bundle

Posted by "chrisdutz (via GitHub)" <gi...@apache.org>.
chrisdutz commented on code in PR #11098:
URL: https://github.com/apache/iotdb/pull/11098#discussion_r1324004235


##########
iotdb-client/service-rpc/pom.xml:
##########
@@ -109,7 +109,7 @@
         <dependency>
             <groupId>org.apache.iotdb</groupId>
             <artifactId>tsfile</artifactId>
-            <version>${project.version}</version>
+            <version>1.3.0-SNAPSHOT</version>

Review Comment:
   Well actually that's a best practice ... the release plugin replaces all of them so that's no extra work.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [iotdb] HTHou commented on pull request #11098: Fix/addressed issues with rat not being able to process the source bundle

Posted by "HTHou (via GitHub)" <gi...@apache.org>.
HTHou commented on PR #11098:
URL: https://github.com/apache/iotdb/pull/11098#issuecomment-1715465767

   I find a code error in ConfigExecution.java.
   https://github.com/apache/iotdb/blob/3c24fa31750623182ab1b94df018a321f1680085/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/execution/config/ConfigExecution.java#L43-L45
   
   L44 should be `com.google.common.util.concurrent.SettableFuture;`
   
   After fixing that, the tests would pass.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [iotdb] HTHou commented on a diff in pull request #11098: Fix/addressed issues with rat not being able to process the source bundle

Posted by "HTHou (via GitHub)" <gi...@apache.org>.
HTHou commented on code in PR #11098:
URL: https://github.com/apache/iotdb/pull/11098#discussion_r1323836488


##########
iotdb-client/service-rpc/pom.xml:
##########
@@ -109,7 +109,7 @@
         <dependency>
             <groupId>org.apache.iotdb</groupId>
             <artifactId>tsfile</artifactId>
-            <version>${project.version}</version>
+            <version>1.3.0-SNAPSHOT</version>

Review Comment:
   Why do you change `${project.version}` to `1.3.0-SNAPSHOT`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [iotdb] chrisdutz commented on a diff in pull request #11098: Fix/addressed issues with rat not being able to process the source bundle

Posted by "chrisdutz (via GitHub)" <gi...@apache.org>.
chrisdutz commented on code in PR #11098:
URL: https://github.com/apache/iotdb/pull/11098#discussion_r1324004697


##########
iotdb-client/service-rpc/pom.xml:
##########
@@ -121,7 +121,7 @@
         <dependency>
             <groupId>org.apache.iotdb</groupId>
             <artifactId>iotdb-thrift</artifactId>
-            <version>${project.version}</version>
+            <version>1.3.0-SNAPSHOT</version>

Review Comment:
   I just stumbled of the the usage in those two cases, but would lean towards doing that for all.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [iotdb] HTHou commented on a diff in pull request #11098: Fix/addressed issues with rat not being able to process the source bundle

Posted by "HTHou (via GitHub)" <gi...@apache.org>.
HTHou commented on code in PR #11098:
URL: https://github.com/apache/iotdb/pull/11098#discussion_r1323842352


##########
iotdb-client/service-rpc/pom.xml:
##########
@@ -121,7 +121,7 @@
         <dependency>
             <groupId>org.apache.iotdb</groupId>
             <artifactId>iotdb-thrift</artifactId>
-            <version>${project.version}</version>
+            <version>1.3.0-SNAPSHOT</version>

Review Comment:
   Same point as above.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [iotdb] HTHou merged pull request #11098: Fix/addressed issues with rat not being able to process the source bundle

Posted by "HTHou (via GitHub)" <gi...@apache.org>.
HTHou merged PR #11098:
URL: https://github.com/apache/iotdb/pull/11098


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org