You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@sedona.apache.org by "paleolimbot (via GitHub)" <gi...@apache.org> on 2025/10/31 14:49:00 UTC
[PR] chore: Fix clippy errors from newer Rust [sedona-db]
paleolimbot opened a new pull request, #266:
URL: https://github.com/apache/sedona-db/pull/266
Totally optional fixes...my local Rust gives yellow squigglies for variables not inlined into the format string.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: Fix clippy errors from newer Rust and pin Python version [sedona-db]
Posted by "petern48 (via GitHub)" <gi...@apache.org>.
petern48 commented on code in PR #266:
URL: https://github.com/apache/sedona-db/pull/266#discussion_r2483047486
##########
.github/workflows/python.yml:
##########
@@ -63,7 +63,7 @@ jobs:
- uses: actions/setup-python@v4
with:
- python-version: '3.x'
+ python-version: '3.13'
Review Comment:
I never realized this until now that we don't test multiple Python versions. Is that intentional and planned to be kept that way? (i have zero complaints. makes my life as a dev much easier haha)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: Fix clippy errors from newer Rust and pin Python version [sedona-db]
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot commented on code in PR #266:
URL: https://github.com/apache/sedona-db/pull/266#discussion_r2483048486
##########
.github/workflows/python.yml:
##########
@@ -63,7 +63,7 @@ jobs:
- uses: actions/setup-python@v4
with:
- python-version: '3.x'
+ python-version: '3.13'
Review Comment:
(Those tests run only on commits to main because they take forever)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: Fix clippy errors from newer Rust and pin Python version [sedona-db]
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot commented on code in PR #266:
URL: https://github.com/apache/sedona-db/pull/266#discussion_r2483048407
##########
.github/workflows/python.yml:
##########
@@ -63,7 +63,7 @@ jobs:
- uses: actions/setup-python@v4
with:
- python-version: '3.x'
+ python-version: '3.13'
Review Comment:
We don't run multiple versions of Python in CI for PRs, but we build wheels for (and run tests on those wheels) for Python 3.9 to Python 3.14 (including the free-threaded versions of Python 3.13 and 3.14). Mostly our Python surface area/rate of change is not very high (much more Rust code than Python code!)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: Fix clippy errors from newer Rust and pin Python version [sedona-db]
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot commented on PR #266:
URL: https://github.com/apache/sedona-db/pull/266#issuecomment-3474295666
Merging to keep CI passing in PRs! Anybody feel free to review and I will follow up 🙂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: Fix clippy errors from newer Rust and pin Python version [sedona-db]
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot merged PR #266:
URL: https://github.com/apache/sedona-db/pull/266
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org