You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2025/06/23 21:24:45 UTC
[PR] Update release instructions to not push tags until release is approved [arrow-rs]
alamb opened a new pull request, #7754:
URL: https://github.com/apache/arrow-rs/pull/7754
# Which issue does this PR close?
- Closes https://github.com/apache/arrow-rs/issues/7753
# Rationale for this change
When we push a tag like `55.2.0` to github it now makes a github 'release' (thanks to @kou )
https://github.com/apache/arrow-rs/relea
However we shouldn't make a release until it is officially approved per ASF guidelines to avoid confusion about what constitutes an official release
# What changes are included in this PR?
Update release instructions and scripts to postpone pushing the release tag until the release is approved
# Are there any user-facing changes?
Hopefully next release we'll only see releases after the release is approved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update release instructions to not push tags until release is approved [arrow-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #7754:
URL: https://github.com/apache/arrow-rs/pull/7754#issuecomment-3023205910
Thanks again @kou
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update release instructions to not push tags until release is approved [arrow-rs]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #7754:
URL: https://github.com/apache/arrow-rs/pull/7754#discussion_r2165440511
##########
dev/release/README.md:
##########
@@ -191,9 +191,16 @@ If the release is not approved, fix whatever the problem is and try again with t
### If the release is approved,
-Move tarball to the release location in SVN, e.g. https://dist.apache.org/repos/dist/release/arrow/arrow-4.1.0/, using the `release-tarball.sh` script:
+Then, create a new release on GitHub using the tag `<version>` (e.g. `4.1.0`).
-Rust Arrow Crates:
+Push the release tag to github
+
+```shell
+git tag <version> <version>-<rc>
+git push apache <version>
+```
+
+Move tarball to the release location in SVN, e.g. https://dist.apache.org/repos/dist/release/arrow/arrow-4.1.0/, using the `release-tarball.sh` script:
Review Comment:
```suggestion
Move tarball to the release location in SVN, e.g. https://dist.apache.org/repos/dist/release/arrow/arrow-rs-4.1.0/, using the `release-tarball.sh` script:
```
##########
dev/release/README.md:
##########
@@ -109,21 +109,21 @@ distribution servers.
While the official release artifact is a signed tarball, we also tag the commit it was created for convenience and code archaeology.
+### Pick a Release Candidate (RC) number
Review Comment:
"Pick a Release Candidate (RC) number" -> "Create git tag for the release" order may be better:
```diff
diff --git a/dev/release/README.md b/dev/release/README.md
index 7b2d4f175..e2257b69c 100644
--- a/dev/release/README.md
+++ b/dev/release/README.md
@@ -105,14 +105,14 @@ create a release candidate using the following steps. Note you need to
be a committer to run these scripts as they upload to the apache `svn`
distribution servers.
-### Create git tag for the release:
-
-While the official release artifact is a signed tarball, we also tag the commit it was created for convenience and code archaeology.
-
### Pick a Release Candidate (RC) number
Pick numbers in sequential order, with `1` for `rc1`, `2` for `rc2`, etc.
+### Create git tag for the release:
+
+While the official release artifact is a signed tarball, we also tag the commit it was created for convenience and code archaeology.
+
Use a string such as `43.0.0` as the `<version>`.
Create and push the tag thusly (for example, for version `4.1.0` and `rc2` would be `4.1.0-rc2`):
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update release instructions to not push tags until release is approved [arrow-rs]
Posted by "etseidl (via GitHub)" <gi...@apache.org>.
etseidl commented on code in PR #7754:
URL: https://github.com/apache/arrow-rs/pull/7754#discussion_r2162692344
##########
dev/release/README.md:
##########
@@ -109,21 +109,21 @@ distribution servers.
While the official release artifact is a signed tarball, we also tag the commit it was created for convenience and code archaeology.
+### Pick an Release Candidate (RC) number
Review Comment:
```suggestion
### Pick a Release Candidate (RC) number
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update release instructions to not push tags until release is approved [arrow-rs]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #7754:
URL: https://github.com/apache/arrow-rs/pull/7754#discussion_r2162567116
##########
dev/release/README.md:
##########
@@ -109,21 +109,21 @@ distribution servers.
While the official release artifact is a signed tarball, we also tag the commit it was created for convenience and code archaeology.
+### Pick an Release Candidate (RC) number
+
+Pick numbers in sequential order, with `1` for `rc1`, `2` for `rc2`, etc.
Review Comment:
Can we move this before `### Create git tag for the release:`?
##########
dev/release/create-tarball.sh:
##########
@@ -64,7 +64,7 @@ else
tar=tar
fi
-release_hash=$(cd "${SOURCE_TOP_DIR}" && git rev-list --max-count=1 ${tag})
+release_hash=$(cd "${SOURCE_TOP_DIR}" && git rev-list --max-count=1 ${tag}-rc${rc})
Review Comment:
It seems that we need more changes in this file.
How about the following? It seems that we don't need `release_hash` anymore because we don't re-tag with the `X.Y.Z-rcN` approach.
```diff
diff --git a/dev/release/create-tarball.sh b/dev/release/create-tarball.sh
index a77ddbe757..2b5071d35b 100755
--- a/dev/release/create-tarball.sh
+++ b/dev/release/create-tarball.sh
@@ -45,14 +45,16 @@ SOURCE_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
SOURCE_TOP_DIR="$(cd "${SOURCE_DIR}/../../" && pwd)"
if [ "$#" -ne 2 ]; then
- echo "Usage: $0 <tag> <rc>"
+ echo "Usage: $0 <version> <rc>"
echo "ex. $0 4.1.0 2"
exit
fi
-tag=$1
+version=$1
rc=$2
+tag="${version}-rc${rc}"
+
# mac tar doesn't have --delete, so use gnutar
# e.g. brew install gtar
@@ -64,9 +66,12 @@ else
tar=tar
fi
-release_hash=$(cd "${SOURCE_TOP_DIR}" && git rev-list --max-count=1 ${tag})
+if ! gic -C "${SORUCE_TOP_DIR}" rev-list --max-count=1 ${tag}; then
+ echo "Cannot continue: unknown git tag: $tag"
+fi
+
-release=apache-arrow-rs-${tag}
+release=apache-arrow-rs-${version}
distdir=${SOURCE_TOP_DIR}/dev/dist/${release}-rc${rc}
tarname=${release}.tar.gz
tarball=${distdir}/${tarname}
@@ -75,22 +80,18 @@ url="https://dist.apache.org/repos/dist/dev/arrow/${release}-rc${rc}"
echo "Attempting to create ${tarball} from tag ${tag}"
-if [ -z "$release_hash" ]; then
- echo "Cannot continue: unknown git tag: $tag"
-fi
-
echo "Draft email for dev@arrow.apache.org mailing list"
echo ""
echo "---------------------------------------------------------"
cat <<MAIL
To: dev@arrow.apache.org
-Subject: [VOTE][RUST] Release Apache Arrow Rust ${tag} RC${rc}
+Subject: [VOTE][RUST] Release Apache Arrow Rust ${version} RC${rc}
Hi,
I would like to propose a release of Apache Arrow Rust Implementation, version ${tag}.
-This release candidate is based on commit: ${release_hash} [1]
+This release candidate is based on commit: ${tag} [1]
The proposed release tarball and signatures are hosted at [2].
@@ -106,21 +107,22 @@ The vote will be open for at least 72 hours.
[ ] +0
[ ] -1 Do not release this as Apache Arrow Rust ${version} because...
-[1]: https://github.com/apache/arrow-rs/tree/${release_hash}
+[1]: https://github.com/apache/arrow-rs/tree/${tag}
[2]: ${url}
-[3]: https://github.com/apache/arrow-rs/blob/${release_hash}/CHANGELOG.md
+[3]: https://github.com/apache/arrow-rs/blob/${tag}/CHANGELOG.md
[4]: https://github.com/apache/arrow-rs/blob/master/dev/release/verify-release-candidate.sh
MAIL
echo "---------------------------------------------------------"
-# create <tarball> containing the files in git at $release_hash
-# the files in the tarball are prefixed with {tag} (e.g. 4.0.1)
+# create <tarball> containing the files in git at $tag
+# the files in the tarball are prefixed with {release}
+# (e.g. apache-arrow-rs-4.0.1)
# use --delete to filter out `object_store` files
mkdir -p ${distdir}
(cd "${SOURCE_TOP_DIR}" && \
- git archive ${release_hash} --prefix ${release}/ \
+ git archive ${tag} --prefix ${release}/ \
| $tar --delete ${release}/'object_store' \
| gzip > ${tarball})
@@ -138,4 +140,4 @@ gpg --armor --output ${tarball}.asc --detach-sig ${tarball}
echo "Uploading to apache dist/dev to ${url}"
svn co --depth=empty https://dist.apache.org/repos/dist/dev/arrow ${SOURCE_TOP_DIR}/dev/dist
svn add ${distdir}
-svn ci -m "Apache Arrow Rust ${tag} ${rc}" ${distdir}
+svn ci -m "Apache Arrow Rust ${version} ${rc}" ${distdir}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update release instructions to not push tags until release is approved [arrow-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #7754:
URL: https://github.com/apache/arrow-rs/pull/7754#discussion_r2165010736
##########
dev/release/create-tarball.sh:
##########
@@ -64,7 +64,7 @@ else
tar=tar
fi
-release_hash=$(cd "${SOURCE_TOP_DIR}" && git rev-list --max-count=1 ${tag})
+release_hash=$(cd "${SOURCE_TOP_DIR}" && git rev-list --max-count=1 ${tag}-rc${rc})
Review Comment:
I have applied this diff locally
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update release instructions to not push tags until release is approved [arrow-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #7754:
URL: https://github.com/apache/arrow-rs/pull/7754
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update release instructions to not push tags until release is approved [arrow-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #7754:
URL: https://github.com/apache/arrow-rs/pull/7754#discussion_r2167477209
##########
dev/release/README.md:
##########
@@ -109,21 +109,21 @@ distribution servers.
While the official release artifact is a signed tarball, we also tag the commit it was created for convenience and code archaeology.
+### Pick an Release Candidate (RC) number
+
+Pick numbers in sequential order, with `1` for `rc1`, `2` for `rc2`, etc.
Review Comment:
Done via https://github.com/apache/arrow-rs/pull/7754#discussion_r2165446394 / 597a8c3f16
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update release instructions to not push tags until release is approved [arrow-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #7754:
URL: https://github.com/apache/arrow-rs/pull/7754#discussion_r2162579794
##########
dev/release/create-tarball.sh:
##########
@@ -64,7 +64,7 @@ else
tar=tar
fi
-release_hash=$(cd "${SOURCE_TOP_DIR}" && git rev-list --max-count=1 ${tag})
+release_hash=$(cd "${SOURCE_TOP_DIR}" && git rev-list --max-count=1 ${tag}-rc${rc})
Review Comment:
Sounds good to me -- thanks @kou
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org