You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Ted Yu (JIRA)" <ji...@apache.org> on 2014/03/16 00:02:43 UTC
[jira] [Comment Edited] (HBASE-5175) Add DoubleColumnInterpreter
[ https://issues.apache.org/jira/browse/HBASE-5175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13936334#comment-13936334 ]
Ted Yu edited comment on HBASE-5175 at 3/15/14 11:02 PM:
---------------------------------------------------------
Some nits:
{code}
+ @Override
+ public Double add(Double d1, Double d2) {
{code}
@Override should align with the start of 'p' in public.
{code}
+ } else if (d1 == null) // both are null
+ return null;
{code}
'else' is not needed. Please enclose 'return null;' in braces.
{code}
Running org.apache.hadoop.hbase.coprocessor.TestDoubleColumnInterpreter
Tests run: 38, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 25.34 sec
{code}
Good, new test passed.
{code}
+ @Test(timeout = 300000)
+ public void testMaxWithValidRange2WithNoCQ() throws Throwable {
{code}
We don't need such long timeout, right ?
{code}
+ } catch (Throwable e) {
+ }
{code}
Why is Throwable ignored ?
The long line warnings were for protobuf generated code.
was (Author: yuzhihong@gmail.com):
Some nits:
{code}
+ @Override
+ public Double add(Double d1, Double d2) {
{code}
@Override should align with the start of 'p' in public.
{code}
+ } else if (d1 == null) // both are null
+ return null;
{code}
'else' is not needed. Please enclose 'return null;' in braces.
{code}
Running org.apache.hadoop.hbase.coprocessor.TestDoubleColumnInterpreter
Tests run: 38, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 25.34 sec
{code}
Good, new test passed.
{code}
+ @Test(timeout = 300000)
+ public void testMaxWithValidRange2WithNoCQ() throws Throwable {
{code}
We don't need such long timeout, right ?
+ } catch (Throwable e) {
+ }
Why is Throwable ignored ?
The long line warnings were for protobuf generated code.
> Add DoubleColumnInterpreter
> ---------------------------
>
> Key: HBASE-5175
> URL: https://issues.apache.org/jira/browse/HBASE-5175
> Project: HBase
> Issue Type: Sub-task
> Reporter: Ted Yu
> Assignee: Julian Wissmann
> Labels: aggregator, features
> Fix For: 0.99.0
>
> Attachments: DoubleColumnInterpreter.java, DoubleColumnInterpreter.patch, DoubleColumnInterpreterV2.patch, DoubleColumnInterpreterV3.patch, HBase.proto, TestDoubleColumnInterpreter.java
>
>
> DoubleColumnInterpreter was requested by Royston Sellman.
--
This message was sent by Atlassian JIRA
(v6.2#6252)