[GitHub] [skywalking] harvies commented on issue #5521: How to find witnessClasses efficiently when adapting multi-version plug-ins?

[GitBox <gi...@apache.org>]

harvies commented on issue #5521:
URL: https://github.com/apache/skywalking/issues/5521#issuecomment-695235752


   > > I am currently planning to write a tool to find witnessClasses that exist in the old version but do not exist in the new version.
   > 
   > This is an interesting idea :).
   > 
   > > How to find witnessClasses efficiently when adapting multi-version plug-ins?
   > 
   > From my experiences, there seems no efficient way to do this in theory. But, logically and in the real world, but we are targeting stable and widely used libraries, they wouldn't randomly change source codes. Once one important core level class changed, the code structure changed with them, like SkyWalking v7 and v8, you are easy to identify the differences. Of course, this experience wouldn't affect your tool.
   
   I have another idea to resolve the conflict. After reviewing the source code and testing, I found that skywalking does not seem to enhance the target class from high to low according to the version of the agent package. Usually, a class will not appear again after the old version of the package is removed. , But classes that exist in an old package usually also exist in a new package. Do you think it is feasible?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org