You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/06/03 20:41:37 UTC

[GitHub] [beam] TheNeuralBit commented on a change in pull request #11914: [BEAM-10187] Push release candidate tag to Github.

TheNeuralBit commented on a change in pull request #11914:
URL: https://github.com/apache/beam/pull/11914#discussion_r434840793



##########
File path: release/src/main/scripts/build_release_candidate.sh
##########
@@ -106,9 +106,7 @@ if [[ $confirmation = "y" ]]; then
                 -Prelease.releaseVersion=${RELEASE}-RC${RC_NUM} \
                 -Prelease.useAutomaticVersion=true --info --no-daemon
 
-  echo "Please make sure gradle release succeed: "
-  echo "1. release code has been pushed to github repo."
-  echo "2. new rc tag has created in github."
+  git push "v${RELEASE}-RC${RC_NUM}"

Review comment:
       When I did this locally there was one more commit on the `release-2.22.0` branch changing the version to 2.22.0-SNAPSHOT, so I had to run `git push origin release-2.22.0` as well.
   
   Also is it ok to omit the `origin`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org