You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Brijesh Bhalala <br...@gmail.com> on 2023/10/27 11:47:41 UTC
Review Request 74701: RANGER-4493: Keep the UI behaviour for tag based and resource based services filtering for zone without any service
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74701/
-----------------------------------------------------------
Review request for ranger, Dhaval Rajpara and Mugdha Varadkar.
Bugs: RANGER-4493
https://issues.apache.org/jira/browse/RANGER-4493
Repository: ranger
Description
-------
In Ranger admin, security zones can be now created without any services/resources.
If a security zone is created without any service, and on the service manager page,
if the resource based services are filtered based on the zone without any service,
then the UI displays an image with the text "No Services".
But if the same service filtering is done for tag based services, then the UI shows a service element for tag.
It will be better if the UI behaviour is consistent for both resource and tag based service filtering
Diffs
-----
security-admin/src/main/webapp/react-webapp/src/views/Home.jsx 3dee1d086
security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceDefinitions.jsx 0b2f46bec
security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceForm.jsx 2df0c4d63
security-admin/src/main/webapp/react-webapp/src/views/SideBar/TopNavBar.jsx d4dbc57d1
Diff: https://reviews.apache.org/r/74701/diff/1/
Testing
-------
Testing is in progress
Thanks,
Brijesh Bhalala
Re: Review Request 74701: RANGER-4493: Keep the UI behaviour for tag based and resource based services filtering for zone without any service
Posted by Mugdha Varadkar <mu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74701/#review225952
-----------------------------------------------------------
Ship it!
Ship It!
- Mugdha Varadkar
On Nov. 6, 2023, 12:56 p.m., Brijesh Bhalala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74701/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2023, 12:56 p.m.)
>
>
> Review request for ranger, Dhaval Rajpara and Mugdha Varadkar.
>
>
> Bugs: RANGER-4493
> https://issues.apache.org/jira/browse/RANGER-4493
>
>
> Repository: ranger
>
>
> Description
> -------
>
> In Ranger admin, security zones can be now created without any services/resources.
> If a security zone is created without any service, and on the service manager page,
> if the resource based services are filtered based on the zone without any service,
> then the UI displays an image with the text "No Services".
> But if the same service filtering is done for tag based services, then the UI shows a service element for tag.
> It will be better if the UI behaviour is consistent for both resource and tag based service filtering
>
> In the current review request, I have improvise the code with following fixes :
>
> 1)Fix for the No service page in tag based.
> 2)Fix for the deleting the zone service while filtering zone.
> 3)Fix for import and export button click when there are no service while filtering zone.
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/react-webapp/src/views/Home.jsx 3dee1d086
> security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceDefinitions.jsx 0b2f46bec
> security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceForm.jsx 2df0c4d63
> security-admin/src/main/webapp/react-webapp/src/views/SideBar/TopNavBar.jsx d4dbc57d1
>
>
> Diff: https://reviews.apache.org/r/74701/diff/2/
>
>
> Testing
> -------
>
> Testing is in progress
>
>
> Thanks,
>
> Brijesh Bhalala
>
>
Re: Review Request 74701: RANGER-4493: Keep the UI behaviour for tag based and resource based services filtering for zone without any service
Posted by Mugdha Varadkar <mu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74701/#review225981
-----------------------------------------------------------
Ship it!
Ship It!
- Mugdha Varadkar
On Nov. 20, 2023, 6:53 a.m., Brijesh Bhalala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74701/
> -----------------------------------------------------------
>
> (Updated Nov. 20, 2023, 6:53 a.m.)
>
>
> Review request for ranger, Dhaval Rajpara and Mugdha Varadkar.
>
>
> Bugs: RANGER-4493
> https://issues.apache.org/jira/browse/RANGER-4493
>
>
> Repository: ranger
>
>
> Description
> -------
>
> In Ranger admin, security zones can be now created without any services/resources.
> If a security zone is created without any service, and on the service manager page,
> if the resource based services are filtered based on the zone without any service,
> then the UI displays an image with the text "No Services".
> But if the same service filtering is done for tag based services, then the UI shows a service element for tag.
> It will be better if the UI behaviour is consistent for both resource and tag based service filtering
>
> In the current review request, I have improvise the code with following fixes :
>
> 1)Fix for the No service page in tag based.
> 2)Fix for the deleting the zone service while filtering zone.
> 3)Fix for import and export button click when there are no service while filtering zone.
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/react-webapp/src/views/Home.jsx 67f71ec79
> security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceDefinitions.jsx 8c222d080
> security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceForm.jsx 47763fb9d
> security-admin/src/main/webapp/react-webapp/src/views/SideBar/TopNavBar.jsx d4dbc57d1
>
>
> Diff: https://reviews.apache.org/r/74701/diff/3/
>
>
> Testing
> -------
>
> Testing is in progress
>
>
> Thanks,
>
> Brijesh Bhalala
>
>
Re: Review Request 74701: RANGER-4493: Keep the UI behaviour for tag based and resource based services filtering for zone without any service
Posted by Brijesh Bhalala <br...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74701/
-----------------------------------------------------------
(Updated Nov. 21, 2023, 6:11 a.m.)
Review request for ranger, Dhaval Rajpara, Dineshkumar Yadav, Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, and Nitin Galave.
Bugs: RANGER-4493
https://issues.apache.org/jira/browse/RANGER-4493
Repository: ranger
Description
-------
In Ranger admin, security zones can be now created without any services/resources.
If a security zone is created without any service, and on the service manager page,
if the resource based services are filtered based on the zone without any service,
then the UI displays an image with the text "No Services".
But if the same service filtering is done for tag based services, then the UI shows a service element for tag.
It will be better if the UI behaviour is consistent for both resource and tag based service filtering
In the current review request, I have improvise the code with following fixes :
1)Fix for the No service page in tag based.
2)Fix for the deleting the zone service while filtering zone.
3)Fix for import and export button click when there are no service while filtering zone.
Diffs
-----
security-admin/src/main/webapp/react-webapp/src/views/Home.jsx 67f71ec79
security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceDefinitions.jsx 8c222d080
security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceForm.jsx 47763fb9d
security-admin/src/main/webapp/react-webapp/src/views/SideBar/TopNavBar.jsx d4dbc57d1
Diff: https://reviews.apache.org/r/74701/diff/3/
Testing (updated)
-------
Tested changes on a cluster setup with Ranger Admin build with React JS code base.
Verified the "Resource Based Policies" & "Tag Based Policies" Module.
Verified the policy listing page.
Thanks,
Brijesh Bhalala
Re: Review Request 74701: RANGER-4493: Keep the UI behaviour for tag based and resource based services filtering for zone without any service
Posted by Brijesh Bhalala <br...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74701/
-----------------------------------------------------------
(Updated Nov. 20, 2023, 6:53 a.m.)
Review request for ranger, Dhaval Rajpara and Mugdha Varadkar.
Bugs: RANGER-4493
https://issues.apache.org/jira/browse/RANGER-4493
Repository: ranger
Description
-------
In Ranger admin, security zones can be now created without any services/resources.
If a security zone is created without any service, and on the service manager page,
if the resource based services are filtered based on the zone without any service,
then the UI displays an image with the text "No Services".
But if the same service filtering is done for tag based services, then the UI shows a service element for tag.
It will be better if the UI behaviour is consistent for both resource and tag based service filtering
In the current review request, I have improvise the code with following fixes :
1)Fix for the No service page in tag based.
2)Fix for the deleting the zone service while filtering zone.
3)Fix for import and export button click when there are no service while filtering zone.
Diffs (updated)
-----
security-admin/src/main/webapp/react-webapp/src/views/Home.jsx 67f71ec79
security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceDefinitions.jsx 8c222d080
security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceForm.jsx 47763fb9d
security-admin/src/main/webapp/react-webapp/src/views/SideBar/TopNavBar.jsx d4dbc57d1
Diff: https://reviews.apache.org/r/74701/diff/3/
Changes: https://reviews.apache.org/r/74701/diff/2-3/
Testing
-------
Testing is in progress
Thanks,
Brijesh Bhalala
Re: Review Request 74701: RANGER-4493: Keep the UI behaviour for tag based and resource based services filtering for zone without any service
Posted by Dhaval Rajpara <dh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74701/#review225971
-----------------------------------------------------------
Ship it!
Ship It!
- Dhaval Rajpara
On Nov. 6, 2023, 12:56 p.m., Brijesh Bhalala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74701/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2023, 12:56 p.m.)
>
>
> Review request for ranger, Dhaval Rajpara and Mugdha Varadkar.
>
>
> Bugs: RANGER-4493
> https://issues.apache.org/jira/browse/RANGER-4493
>
>
> Repository: ranger
>
>
> Description
> -------
>
> In Ranger admin, security zones can be now created without any services/resources.
> If a security zone is created without any service, and on the service manager page,
> if the resource based services are filtered based on the zone without any service,
> then the UI displays an image with the text "No Services".
> But if the same service filtering is done for tag based services, then the UI shows a service element for tag.
> It will be better if the UI behaviour is consistent for both resource and tag based service filtering
>
> In the current review request, I have improvise the code with following fixes :
>
> 1)Fix for the No service page in tag based.
> 2)Fix for the deleting the zone service while filtering zone.
> 3)Fix for import and export button click when there are no service while filtering zone.
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/react-webapp/src/views/Home.jsx 3dee1d086
> security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceDefinitions.jsx 0b2f46bec
> security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceForm.jsx 2df0c4d63
> security-admin/src/main/webapp/react-webapp/src/views/SideBar/TopNavBar.jsx d4dbc57d1
>
>
> Diff: https://reviews.apache.org/r/74701/diff/2/
>
>
> Testing
> -------
>
> Testing is in progress
>
>
> Thanks,
>
> Brijesh Bhalala
>
>
Re: Review Request 74701: RANGER-4493: Keep the UI behaviour for tag based and resource based services filtering for zone without any service
Posted by Brijesh Bhalala <br...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74701/
-----------------------------------------------------------
(Updated Nov. 6, 2023, 12:56 p.m.)
Review request for ranger, Dhaval Rajpara and Mugdha Varadkar.
Bugs: RANGER-4493
https://issues.apache.org/jira/browse/RANGER-4493
Repository: ranger
Description
-------
In Ranger admin, security zones can be now created without any services/resources.
If a security zone is created without any service, and on the service manager page,
if the resource based services are filtered based on the zone without any service,
then the UI displays an image with the text "No Services".
But if the same service filtering is done for tag based services, then the UI shows a service element for tag.
It will be better if the UI behaviour is consistent for both resource and tag based service filtering
In the current review request, I have improvise the code with following fixes :
1)Fix for the No service page in tag based.
2)Fix for the deleting the zone service while filtering zone.
3)Fix for import and export button click when there are no service while filtering zone.
Diffs (updated)
-----
security-admin/src/main/webapp/react-webapp/src/views/Home.jsx 3dee1d086
security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceDefinitions.jsx 0b2f46bec
security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceForm.jsx 2df0c4d63
security-admin/src/main/webapp/react-webapp/src/views/SideBar/TopNavBar.jsx d4dbc57d1
Diff: https://reviews.apache.org/r/74701/diff/2/
Changes: https://reviews.apache.org/r/74701/diff/1-2/
Testing
-------
Testing is in progress
Thanks,
Brijesh Bhalala
Re: Review Request 74701: RANGER-4493: Keep the UI behaviour for tag based and resource based services filtering for zone without any service
Posted by Brijesh Bhalala <br...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74701/
-----------------------------------------------------------
(Updated Oct. 27, 2023, 1:15 p.m.)
Review request for ranger, Dhaval Rajpara and Mugdha Varadkar.
Bugs: RANGER-4493
https://issues.apache.org/jira/browse/RANGER-4493
Repository: ranger
Description (updated)
-------
In Ranger admin, security zones can be now created without any services/resources.
If a security zone is created without any service, and on the service manager page,
if the resource based services are filtered based on the zone without any service,
then the UI displays an image with the text "No Services".
But if the same service filtering is done for tag based services, then the UI shows a service element for tag.
It will be better if the UI behaviour is consistent for both resource and tag based service filtering
In the current review request, I have improvise the code with following fixes :
1)Fix for the No service page in tag based.
2)Fix for the deleting the zone service while filtering zone.
3)Fix for import and export button click when there are no service while filtering zone.
Diffs
-----
security-admin/src/main/webapp/react-webapp/src/views/Home.jsx 3dee1d086
security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceDefinitions.jsx 0b2f46bec
security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceForm.jsx 2df0c4d63
security-admin/src/main/webapp/react-webapp/src/views/SideBar/TopNavBar.jsx d4dbc57d1
Diff: https://reviews.apache.org/r/74701/diff/1/
Testing
-------
Testing is in progress
Thanks,
Brijesh Bhalala
Re: Review Request 74701: RANGER-4493: Keep the UI behaviour for tag based and resource based services filtering for zone without any service
Posted by Brijesh Bhalala <br...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74701/
-----------------------------------------------------------
(Updated Oct. 27, 2023, 12:40 p.m.)
Review request for ranger, Dhaval Rajpara and Mugdha Varadkar.
Bugs: RANGER-4493
https://issues.apache.org/jira/browse/RANGER-4493
Repository: ranger
Description (updated)
-------
In Ranger admin, security zones can be now created without any services/resources.
If a security zone is created without any service, and on the service manager page,
if the resource based services are filtered based on the zone without any service,
then the UI displays an image with the text "No Services".
But if the same service filtering is done for tag based services, then the UI shows a service element for tag.
It will be better if the UI behaviour is consistent for both resource and tag based service filtering
I will improvise code and some UI part with the following fixes:-
1)Fix for the No service page in tag based.
2)Fix for the deleting the zone service while filtering zone.
3)Fix for import and export button click when there are no service while filtering zone.
Diffs
-----
security-admin/src/main/webapp/react-webapp/src/views/Home.jsx 3dee1d086
security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceDefinitions.jsx 0b2f46bec
security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceForm.jsx 2df0c4d63
security-admin/src/main/webapp/react-webapp/src/views/SideBar/TopNavBar.jsx d4dbc57d1
Diff: https://reviews.apache.org/r/74701/diff/1/
Testing
-------
Testing is in progress
Thanks,
Brijesh Bhalala