You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "HyukjinKwon (via GitHub)" <gi...@apache.org> on 2023/10/18 07:53:00 UTC
[PR] [SPARK-45353][SPARK-45196][PYTHON][DOCS][FOLLOW-UP] Fix doctests of array and create_map compatible with ANSI mode [spark]
HyukjinKwon opened a new pull request, #43429:
URL: https://github.com/apache/spark/pull/43429
### What changes were proposed in this pull request?
This PR fixes doctests of `array` and `create_map` compatible with ANSI mode.
### Why are the changes needed?
To recover the ANSI build: https://github.com/apache/spark/actions/runs/6554930168/job/17802692465
### Does this PR introduce _any_ user-facing change?
No, test-only.
### How was this patch tested?
Manually tested by:
```bash
SPARK_ANSI_SQL_MODE=true ./python/run-tests --python-executables=python3 --testnames 'pyspark.sql.functions'
```
and
```bash
./python/run-tests --python-executables=python3 --testnames 'pyspark.sql.functions'
```
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45353][SPARK-45196][PYTHON][DOCS][FOLLOW-UP] Fix doctests of array and create_map compatible with ANSI mode [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #43429:
URL: https://github.com/apache/spark/pull/43429#issuecomment-1767915443
Merging that :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45353][SPARK-45196][PYTHON][DOCS][FOLLOW-UP] Fix doctests of array and create_map compatible with ANSI mode [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #43429:
URL: https://github.com/apache/spark/pull/43429#issuecomment-1767886447
cc @LuciferYang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45353][SPARK-45196][PYTHON][DOCS][FOLLOW-UP] Fix doctests of array and create_map compatible with ANSI mode [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #43429: [SPARK-45353][SPARK-45196][PYTHON][DOCS][FOLLOW-UP] Fix doctests of array and create_map compatible with ANSI mode
URL: https://github.com/apache/spark/pull/43429
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45353][SPARK-45196][PYTHON][DOCS][FOLLOW-UP] Fix doctests of array and create_map compatible with ANSI mode [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #43429:
URL: https://github.com/apache/spark/pull/43429#issuecomment-1767917292
haha :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45353][SPARK-45196][PYTHON][DOCS][FOLLOW-UP] Fix doctests of array and create_map compatible with ANSI mode [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #43429:
URL: https://github.com/apache/spark/pull/43429#issuecomment-1767895581
@HyukjinKwon https://github.com/apache/spark/pull/43168 Is it because this has not been merged yet?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45353][SPARK-45196][PYTHON][DOCS][FOLLOW-UP] Fix doctests of array and create_map compatible with ANSI mode [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #43429:
URL: https://github.com/apache/spark/pull/43429#issuecomment-1767914583
ohhh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45353][SPARK-45196][PYTHON][DOCS][FOLLOW-UP] Fix doctests of array and create_map compatible with ANSI mode [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #43429:
URL: https://github.com/apache/spark/pull/43429#issuecomment-1767890957
also cc @panbingkun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45353][SPARK-45196][PYTHON][DOCS][FOLLOW-UP] Fix doctests of array and create_map compatible with ANSI mode [spark]
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #43429:
URL: https://github.com/apache/spark/pull/43429#issuecomment-1767919775
😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org