You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/10/07 16:55:24 UTC

[GitHub] [geode-native] mmartell opened a new pull request #670: GEODE-8580: Don't throw pointers in GfshExecute

mmartell opened a new pull request #670:
URL: https://github.com/apache/geode-native/pull/670


   This is a fix to the new C++ test framework. We were throwing pointers.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [geode-native] pdxcodemonkey merged pull request #670: GEODE-8580: Don't throw pointers in GfshExecute

Posted by GitBox <gi...@apache.org>.
pdxcodemonkey merged pull request #670:
URL: https://github.com/apache/geode-native/pull/670


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [geode-native] codecov-io commented on pull request #670: GEODE-8580: Don't throw pointers in GfshExecute

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #670:
URL: https://github.com/apache/geode-native/pull/670#issuecomment-705137350


   # [Codecov](https://codecov.io/gh/apache/geode-native/pull/670?src=pr&el=h1) Report
   > :exclamation: No coverage uploaded for pull request base (`develop@3ae0f32`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/geode-native/pull/670/graphs/tree.svg?width=650&height=150&src=pr&token=plpAqoqGag)](https://codecov.io/gh/apache/geode-native/pull/670?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##             develop     #670   +/-   ##
   ==========================================
     Coverage           ?   74.26%           
   ==========================================
     Files              ?      644           
     Lines              ?    51131           
     Branches           ?        0           
   ==========================================
     Hits               ?    37971           
     Misses             ?    13160           
     Partials           ?        0           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/geode-native/pull/670?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/geode-native/pull/670?src=pr&el=footer). Last update [3ae0f32...4b85e17](https://codecov.io/gh/apache/geode-native/pull/670?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org