[GitHub] [fineract] mohitsinha commented on a diff in pull request #3150: FINERACT-1724: Fee's are not included in total balance amount, when we have multiple disbursements on first day

["mohitsinha (via GitHub)" <gi...@apache.org>]

mohitsinha commented on code in PR #3150:
URL: https://github.com/apache/fineract/pull/3150#discussion_r1182961875


##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java:
##########
@@ -773,8 +773,10 @@ private void handleChargePaidTransaction(final LoanCharge charge, final LoanTran
         LocalDate startDate = getDisbursementDate();
         List<LoanRepaymentScheduleInstallment> installments = getRepaymentScheduleInstallments();
         for (final LoanRepaymentScheduleInstallment installment : installments) {
-            if (installmentNumber == null && charge.isDueForCollectionFromAndUpToAndIncluding(startDate, installment.getDueDate())) {
-
+            boolean isDue = installment.isFirstPeriod()
+                    ? charge.isDueForCollectionFromIncludingAndUpToAndIncluding(startDate, installment.getDueDate())

Review Comment:
   Can both the cases be handled using `installment.getFromDate(), installment.getDueDate()`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org