You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "panbingkun (via GitHub)" <gi...@apache.org> on 2023/05/21 10:21:24 UTC

[GitHub] [spark] panbingkun opened a new pull request, #41245: [MINOR][DOCS] Fix wrong reference

panbingkun opened a new pull request, #41245:
URL: https://github.com/apache/spark/pull/41245

   ### What changes were proposed in this pull request?
   The pr aims to fix wrong reference, include:
   - Hadoop doc related
   - Kafka doc related
   - Other
   
   ### Why are the changes needed?
   Update reference.
   
   ### Does this PR introduce _any_ user-facing change?
   No.
   
   ### How was this patch tested?
   Manual testing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon closed pull request #41245: [MINOR][DOCS] Fix wrong reference

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #41245: [MINOR][DOCS] Fix wrong reference
URL: https://github.com/apache/spark/pull/41245


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #41245: [MINOR][DOCS] Fix wrong reference

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #41245:
URL: https://github.com/apache/spark/pull/41245#issuecomment-1556565071

   Merged to master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] panbingkun commented on a diff in pull request #41245: [MINOR][DOCS] Fix wrong reference

Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on code in PR #41245:
URL: https://github.com/apache/spark/pull/41245#discussion_r1199738085


##########
connector/kafka-0-10/src/main/scala/org/apache/spark/streaming/kafka010/ConsumerStrategy.scala:
##########
@@ -39,15 +39,15 @@ import org.apache.spark.kafka010.KafkaConfigUpdater
  */
 abstract class ConsumerStrategy[K, V] {
   /**
-   * Kafka <a href="http://kafka.apache.org/documentation.html#newconsumerconfigs">
+   * Kafka <a href="https://kafka.apache.org/documentation.html#consumerconfigs">
    * configuration parameters</a> to be used on executors. Requires "bootstrap.servers" to be set

Review Comment:
   The old link has outdated



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] panbingkun commented on a diff in pull request #41245: [MINOR][DOCS] Fix wrong reference

Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on code in PR #41245:
URL: https://github.com/apache/spark/pull/41245#discussion_r1199738222


##########
core/src/main/scala/org/apache/spark/deploy/SparkHadoopUtil.scala:
##########
@@ -560,7 +560,7 @@ private[spark] object SparkHadoopUtil extends Logging {
    * Create a file on the given file system, optionally making sure erasure coding is disabled.
    *
    * Disabling EC can be helpful as HDFS EC doesn't support hflush(), hsync(), or append().
-   * https://hadoop.apache.org/docs/r3.0.0/hadoop-project-dist/hadoop-hdfs/HDFSErasureCoding.html#Limitations

Review Comment:
   The Hadoop version that Spark relies on has exceeded 3.0



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] panbingkun commented on a diff in pull request #41245: [MINOR][DOCS] Fix wrong reference

Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on code in PR #41245:
URL: https://github.com/apache/spark/pull/41245#discussion_r1199738326


##########
streaming/src/main/scala/org/apache/spark/streaming/Checkpoint.scala:
##########
@@ -173,7 +173,7 @@ object Checkpoint extends Logging {
       // to find classes, which maybe the wrong class loader. Hence, an inherited version
       // of ObjectInputStream is used to explicitly use the current thread's default class
       // loader to find and load classes. This is a well know Java issue and has popped up
-      // in other places (e.g., http://jira.codehaus.org/browse/GROOVY-1627)

Review Comment:
   Dead link



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org