[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #7201: Perf: cache metrics id and entity id

[GitBox <gi...@apache.org>]

kezhenxu94 commented on a change in pull request #7201:
URL: https://github.com/apache/skywalking/pull/7201#discussion_r660645610



##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/metrics/Metrics.java
##########
@@ -131,4 +132,18 @@ private boolean isHourBucket() {
     private boolean isDayBucket() {
         return TimeBucket.isDayBucket(timeBucket);
     }
+
+    private volatile String id;
+
+    @Override
+    public String id() {
+        if (id == null) {
+            id = id0();
+        }
+        return id;
+    }
+
+    protected String id0() {
+        return null;
+    }

Review comment:
       DONE




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org