[PR] FINERACT-2552: Fix NullPointerException in flat EMI calculation when no previous repayment period exists [fineract]

["devi-pathak2263 (via GitHub)" <gi...@apache.org>]

devi-pathak2263 opened a new pull request, #5685:
URL: https://github.com/apache/fineract/pull/5685

   ##Description
   
   This PR fixes a potential NullPointerException in calculateEMIOnActualModelWithFlatInterestMethod within ProgressiveEMICalculator.
   
   When recalculation starts from the first repayment period, firstRepaymentPeriod.getPrevious() can return empty. In such cases, alreadyRepaidPrincipals becomes null and is later used in a subtraction operation, which may lead to a runtime exception.
   
   ##Changes
   Replaced null fallback with Money.zero(currency) to ensure safe computation
   Added unit test to validate behavior when no previous repayment period exists
   
   ##Impact
   Prevents runtime failure in flat interest EMI calculation
   Maintains existing business logic and behavior
   
   ##Testing
   Added test case to ensure no exception is thrown in the identified scenario
   Verified existing tests pass for the progressive loan module
   
   ##Jira: https://issues.apache.org/jira/browse/FINERACT-2552
   
   ## Checklist
   Please make sure these boxes are checked before submitting your pull request - thanks!
   
   - [x] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests)
   - [x] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
   - [x] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made.
   - [x] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions).
   - [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
   - [ ] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute).
   
   Your assigned reviewer(s) will follow our [guidelines for code reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] FINERACT-2552: Fix NullPointerException in flat EMI calculation when no previous repayment period exists [fineract]

["adamsaghy (via GitHub)" <gi...@apache.org>]

adamsaghy merged PR #5685:
URL: https://github.com/apache/fineract/pull/5685


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org