You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/08/22 12:41:27 UTC
[GitHub] [airflow] RosterIn opened a new pull request, #25874: Fix task policy example
RosterIn opened a new pull request, #25874:
URL: https://github.com/apache/airflow/pull/25874
There is no timeout parameter there is execution_timeout
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] RosterIn closed pull request #25874: Fix task policy example
Posted by GitBox <gi...@apache.org>.
RosterIn closed pull request #25874: Fix task policy example
URL: https://github.com/apache/airflow/pull/25874
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] josh-fell commented on a diff in pull request #25874: Fix task policy example
Posted by GitBox <gi...@apache.org>.
josh-fell commented on code in PR #25874:
URL: https://github.com/apache/airflow/pull/25874#discussion_r951874773
##########
tests/cluster_policies/__init__.py:
##########
@@ -89,8 +89,8 @@ class TimedOperator(BaseOperator, ABC):
def task_policy(task: TimedOperator):
if task.task_type == 'HivePartitionSensor':
task.queue = "sensor_queue"
- if task.timeout > timedelta(hours=48):
Review Comment:
This is relative to the `TimedOperator` just above this policy though. The `[START example_task_cluster_policy]` marker was moved above the `TimedOperator` declaration in #23468 so it will show up in the Cluster Policy doc when published. Should the `TimedOperator` piece be removed altogether then?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] RosterIn commented on a diff in pull request #25874: Fix task policy example
Posted by GitBox <gi...@apache.org>.
RosterIn commented on code in PR #25874:
URL: https://github.com/apache/airflow/pull/25874#discussion_r952722974
##########
tests/cluster_policies/__init__.py:
##########
@@ -89,8 +89,8 @@ class TimedOperator(BaseOperator, ABC):
def task_policy(task: TimedOperator):
if task.task_type == 'HivePartitionSensor':
task.queue = "sensor_queue"
- if task.timeout > timedelta(hours=48):
Review Comment:
It seems complex to change the whole example. everything I touch produce another error.
I'll leave it to someone more experienced with cluster policy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org