You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/10/21 15:40:30 UTC
[GitHub] [solr] joel-bernstein opened a new pull request, #1099: SOLR-15733: Migrate streaming
joel-bernstein opened a new pull request, #1099:
URL: https://github.com/apache/solr/pull/1099
https://issues.apache.org/jira/browse/SOLR-XXXXX
<!--
_(If you are a project committer then you may remove some/all of the following template.)_
Before creating a pull request, please file an issue in the ASF Jira system for Solr:
* https://issues.apache.org/jira/projects/SOLR
For something minor (i.e. that wouldn't be worth putting in release notes), you can skip JIRA.
To create a Jira issue, you will need to create an account there first.
The title of the PR should reference the Jira issue number in the form:
* SOLR-####: <short description of problem or changes>
SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on.
Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->
# Description
Please provide a short description of the changes you're making with this pull request.
# Solution
Please provide a short description of the approach taken to implement your solution.
# Tests
Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem.
# Checklist
Please review the following and check all that apply:
- [ ] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [ ] I have created a Jira issue and added the issue ID to my pull request title.
- [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [ ] I have developed this patch against the `main` branch.
- [ ] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] joel-bernstein commented on pull request #1099: SOLR-15733: Separate out a solrj-streaming module
Posted by GitBox <gi...@apache.org>.
joel-bernstein commented on PR #1099:
URL: https://github.com/apache/solr/pull/1099#issuecomment-1294135600
I am also a member of the apache organization on github.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] joel-bernstein commented on pull request #1099: SOLR-15733: Separate out a solrj-streaming module
Posted by GitBox <gi...@apache.org>.
joel-bernstein commented on PR #1099:
URL: https://github.com/apache/solr/pull/1099#issuecomment-1294778348
I'm not able to see https://github.com/orgs/apache/teams/solr-committers/members?query=joel which must be the reason I'm not seeing the merge button. Is this something that infra needs to fix or does the Solr pmc manage this list?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] joel-bernstein commented on a diff in pull request #1099: SOLR-15733: Migrate streaming
Posted by GitBox <gi...@apache.org>.
joel-bernstein commented on code in PR #1099:
URL: https://github.com/apache/solr/pull/1099#discussion_r1002047225
##########
solr/solrj-streaming/build.gradle:
##########
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+apply plugin: 'java-library'
+
+description = 'Solrj-Streaming - SolrJ requiring Streaming Expressions'
+
+dependencies {
+
+
+ implementation project(':solr:solrj')
+
+ // declare dependencies we use even though already declared by solrj-core
+ implementation 'org.slf4j:slf4j-api'
+ implementation 'org.apache.httpcomponents:httpclient'
+ implementation 'org.apache.httpcomponents:httpcore'
+ implementation 'org.apache.commons:commons-math3'
+
+ testImplementation project(':solr:test-framework')
+ testImplementation project(':solr:core')
+
+ testImplementation 'junit:junit'
+ testImplementation 'commons-io:commons-io'
+ testImplementation 'com.google.guava:guava'
+ testImplementation project(':solr:solrj-zookeeper')
+ testImplementation('org.apache.zookeeper:zookeeper', {
+ exclude group: "org.apache.yetus", module: "audience-annotations"
+ })
+
+ permitTestUsedUndeclared project(':solr:solrj-zookeeper') // duh!
Review Comment:
sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] joel-bernstein commented on pull request #1099: SOLR-15733: Migrate streaming
Posted by GitBox <gi...@apache.org>.
joel-bernstein commented on PR #1099:
URL: https://github.com/apache/solr/pull/1099#issuecomment-1294024484
@risdenk, thanks for the commits on this! I pulled all the latest and things look good.
Does the solrj build.gradle need to refer to solrj-streaming so 9x users don't have a back compat issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on a diff in pull request #1099: SOLR-15733: Migrate streaming
Posted by GitBox <gi...@apache.org>.
risdenk commented on code in PR #1099:
URL: https://github.com/apache/solr/pull/1099#discussion_r1002034900
##########
solr/solrj-streaming/build.gradle:
##########
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+apply plugin: 'java-library'
+
+description = 'Solrj-Streaming - SolrJ requiring Streaming Expressions'
+
+dependencies {
+
+
+ implementation project(':solr:solrj')
+
+ // declare dependencies we use even though already declared by solrj-core
+ implementation 'org.slf4j:slf4j-api'
+ implementation 'org.apache.httpcomponents:httpclient'
+ implementation 'org.apache.httpcomponents:httpcore'
+ implementation 'org.apache.commons:commons-math3'
+
+ testImplementation project(':solr:test-framework')
+ testImplementation project(':solr:core')
+
+ testImplementation 'junit:junit'
+ testImplementation 'commons-io:commons-io'
+ testImplementation 'com.google.guava:guava'
+ testImplementation project(':solr:solrj-zookeeper')
+ testImplementation('org.apache.zookeeper:zookeeper', {
+ exclude group: "org.apache.yetus", module: "audience-annotations"
+ })
+
+ permitTestUsedUndeclared project(':solr:solrj-zookeeper') // duh!
Review Comment:
nit: can you put this line under `testImplementation project(':solr:solrj-zookeeper')` - I've been trying to keep the `permitTestUsedUndeclared` near the line that introduced it.
##########
solr/solrj-streaming/build.gradle:
##########
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+apply plugin: 'java-library'
+
+description = 'Solrj-Streaming - SolrJ requiring Streaming Expressions'
+
+dependencies {
+
+
Review Comment:
nit: extra lines
##########
solr/solrj/build.gradle:
##########
@@ -25,8 +25,6 @@ dependencies {
implementation 'org.slf4j:slf4j-api'
runtimeOnly 'org.slf4j:jcl-over-slf4j'
- implementation 'org.apache.commons:commons-math3'
Review Comment:
woot!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on pull request #1099: SOLR-15733: Separate out a solrj-streaming module
Posted by GitBox <gi...@apache.org>.
risdenk commented on PR #1099:
URL: https://github.com/apache/solr/pull/1099#issuecomment-1295006402
> I assume this is the PR that will stay in main branch, since there is no dependency added in solrj's build.gradle to depend on solrj-streaming?
@janhoy yes - will add to branch_9x like solrj-zookeeper did - see https://github.com/apache/solr/pull/1099#issuecomment-1294043754. @dsmiley asked the same question on the Jira.
> Should there not be some refguide docs in streaming about the need to add solrj-streaming as a dependency to your app if you need the IO classes?
good catch will need to update.
> I also assume there will be a backport PR that adds the transitive dependency from solrj to solrj-zookeeper, perhaps along with a note in the Upgrade Notes for 9.2 that you can now opt out of solrj-streaming on client if you don't use it, simply by excluding the coordinates in your POM.
yup makes sense.
> solrj/build.gradle shouldn't need hsqldb anymore; right? And it shouldn't depend on 'solr:modules:sql' if the corresponding tests have been moved.
@joel-bernstein I can help take another look at the dependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] HoustonPutman commented on pull request #1099: SOLR-15733: Separate out a solrj-streaming module
Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on PR #1099:
URL: https://github.com/apache/solr/pull/1099#issuecomment-1295124192
Looked through the gradle stuff and it looks good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on pull request #1099: SOLR-15733: Separate out a solrj-streaming module
Posted by GitBox <gi...@apache.org>.
risdenk commented on PR #1099:
URL: https://github.com/apache/solr/pull/1099#issuecomment-1295087385
@dsmiley / @janhoy I think I addressed your concerns so far. The only one not addressed (yet) is only for branch_9x to add upgrade notes and opting out of solrj-streaming.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on pull request #1099: SOLR-15733: Separate out a solrj-streaming module
Posted by GitBox <gi...@apache.org>.
risdenk commented on PR #1099:
URL: https://github.com/apache/solr/pull/1099#issuecomment-1294361637
@joel-bernstein I don't see you listed here https://github.com/orgs/apache/teams/solr-committers/members?query=joel - its a private list if you are on it you can see it. I see your username here https://whimsy.apache.org/roster/committer/jbernste
so not sure what is going on
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] joel-bernstein commented on pull request #1099: SOLR-15733: Migrate streaming
Posted by GitBox <gi...@apache.org>.
joel-bernstein commented on PR #1099:
URL: https://github.com/apache/solr/pull/1099#issuecomment-1287138644
First step of migrating Streaming Expressions to solrj-streaming.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] joel-bernstein commented on pull request #1099: SOLR-15733: Migrate streaming
Posted by GitBox <gi...@apache.org>.
joel-bernstein commented on PR #1099:
URL: https://github.com/apache/solr/pull/1099#issuecomment-1287348911
The full test suit is passing except for the following which fails everytime and seems to be unrelated.
2> 32414 INFO (TEST-PerReplicaStatesIntegrationTest.testPerReplicaStateCollection-seed#[D7017DB2FFB75346]) [] o.a.s.SolrTestCaseJ4 ###Ending testPerReplicaStateCollection
> org.apache.solr.client.solrj.impl.BaseHttpSolrClient$RemoteSolrException: Error from server at http://127.0.0.1:65178/solr: Invalid replica : core_node8 in shard/collection : shard1/perReplicaState_test available replicas are core_node2,core_node6,core_node10
> at __randomizedtesting.SeedInfo.seed([D7017DB2FFB75346:FD3CD6F05F17894B]:0)
> at app//org.apache.solr.client.solrj.impl.HttpSolrClient.executeMethod(HttpSolrClient.java:720)
> at app//org.apache.solr.client.solrj.impl.HttpSolrClient.request(HttpSolrClient.java:234)
> at app//org.apache.solr.client.solrj.impl.HttpSolrClient.request(HttpSolrClient.java:215)
> at app//org.apache.solr.client.solrj.impl.LBSolrClient.doRequest(LBSolrClient.java:405)
> at app//org.apache.solr.client.solrj.impl.LBSolrClient.request(LBSolrClient.java:371)
> at app//org.apache.solr.client.solrj.impl.CloudSolrClient.sendRequest(CloudSolrClient.java:1174)
> at app//org.apache.solr.client.solrj.impl.CloudSolrClient.requestWithRetryOnStaleState(CloudSolrClient.java:880)
> at app//org.apache.solr.client.solrj.impl.CloudSolrClient.request(CloudSolrClient.java:807)
> at app//org.apache.solr.client.solrj.SolrRequest.process(SolrRequest.java:234)
> at app//org.apache.solr.client.solrj.SolrRequest.process(SolrRequest.java:249)
> at app//org.apache.solr.common.cloud.PerReplicaStatesIntegrationTest.testPerReplicaStateCollection(PerReplicaStatesIntegrationTest.java:91)
> at java.base@11.0.9/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at java.base@11.0.9/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at java.base@11.0.9/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base@11.0.9/java.lang.reflect.Method.invoke(Method.java:566)
> at app//com.carrotsearch.randomizedtesting.RandomizedRunner.invoke(RandomizedRunner.java:1758)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] joel-bernstein commented on pull request #1099: SOLR-15733: Separate out a solrj-streaming module
Posted by GitBox <gi...@apache.org>.
joel-bernstein commented on PR #1099:
URL: https://github.com/apache/solr/pull/1099#issuecomment-1294121660
I checked my account at id.apache.org and my github account is there. So this may take a jira to infra to sort out.
I have this branch squash merged to main locally and am running tests. I can push it out from my local repo or @risdenk you can merge from here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] joel-bernstein commented on pull request #1099: SOLR-15733: Separate out a solrj-streaming module
Posted by GitBox <gi...@apache.org>.
joel-bernstein commented on PR #1099:
URL: https://github.com/apache/solr/pull/1099#issuecomment-1294788724
@dsmiley I believe Solrj no long needs the hsql dependency. The solrj-streaming dependency on solr:modules:sql I believe is only there to support tests for the JDBCStream and JDBC driver. Both of which could eventually be moved to solrj-jdbc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on pull request #1099: SOLR-15733: Migrate streaming
Posted by GitBox <gi...@apache.org>.
risdenk commented on PR #1099:
URL: https://github.com/apache/solr/pull/1099#issuecomment-1292121497
@joel-bernstein that error was being looked at. it should be fixed on main. I can help fix the merge conflicts since they are due to some of the changes I've made.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on pull request #1099: SOLR-15733: Separate out a solrj-streaming module
Posted by GitBox <gi...@apache.org>.
risdenk commented on PR #1099:
URL: https://github.com/apache/solr/pull/1099#issuecomment-1303860976
backport to branch_9x here: https://github.com/apache/solr/pull/1161
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] joel-bernstein commented on pull request #1099: SOLR-15733: Migrate streaming
Posted by GitBox <gi...@apache.org>.
joel-bernstein commented on PR #1099:
URL: https://github.com/apache/solr/pull/1099#issuecomment-1287232533
The latest commit allows Solr to assemble with the new solrj-streaming jar. The distribution starts and streaming expressions run. So it getting closer. Next I'll dig into the tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on pull request #1099: SOLR-15733: Separate out a solrj-streaming module
Posted by GitBox <gi...@apache.org>.
risdenk commented on PR #1099:
URL: https://github.com/apache/solr/pull/1099#issuecomment-1296329111
I think this is good to go. Just need to do follow up on branch_9x after this is merged and backported to branch_9x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] dsmiley commented on pull request #1099: SOLR-15733: Separate out a solrj-streaming module
Posted by GitBox <gi...@apache.org>.
dsmiley commented on PR #1099:
URL: https://github.com/apache/solr/pull/1099#issuecomment-1294941143
Shouldn't those tests move out of solrj(core) now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on pull request #1099: SOLR-15733: Migrate streaming
Posted by GitBox <gi...@apache.org>.
risdenk commented on PR #1099:
URL: https://github.com/apache/solr/pull/1099#issuecomment-1292412323
@joel-bernstein all tests pass too!
```
./gradlew clean
...
./gradlew check -Pvalidation.errorprone=true
...
BUILD SUCCESSFUL in 19m 13s
610 actionable tasks: 556 executed, 54 up-to-date
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] madrob commented on pull request #1099: SOLR-15733: Separate out a solrj-streaming module
Posted by GitBox <gi...@apache.org>.
madrob commented on PR #1099:
URL: https://github.com/apache/solr/pull/1099#issuecomment-1294123389
Do you have 2FA enabled for your GitHub account?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on pull request #1099: SOLR-15733: Separate out a solrj-streaming module
Posted by GitBox <gi...@apache.org>.
risdenk commented on PR #1099:
URL: https://github.com/apache/solr/pull/1099#issuecomment-1295129586
`./gradlew check -Pvalidation.errorprone=true` passed with changes pushed so far.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on pull request #1099: SOLR-15733: Separate out a solrj-streaming module
Posted by GitBox <gi...@apache.org>.
risdenk commented on PR #1099:
URL: https://github.com/apache/solr/pull/1099#issuecomment-1294043754
@joel-bernstein I'd do that separately on branch_9x only - similar to https://github.com/apache/solr/commit/80889178990369617bb5edb0b284ad24e34d5ad3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] joel-bernstein commented on pull request #1099: SOLR-15733: Migrate streaming
Posted by GitBox <gi...@apache.org>.
joel-bernstein commented on PR #1099:
URL: https://github.com/apache/solr/pull/1099#issuecomment-1287318530
solrj-streaming test are passing now. Checking the entire test suite, there will be failures in places that expect to find Streaming Expressions in solrj.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] joel-bernstein commented on pull request #1099: SOLR-15733: Separate out a solrj-streaming module
Posted by GitBox <gi...@apache.org>.
joel-bernstein commented on PR #1099:
URL: https://github.com/apache/solr/pull/1099#issuecomment-1294085546
I don't have the merge button. Let me see if I can figure out why.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] joel-bernstein commented on pull request #1099: SOLR-15733: Separate out a solrj-streaming module
Posted by GitBox <gi...@apache.org>.
joel-bernstein commented on PR #1099:
URL: https://github.com/apache/solr/pull/1099#issuecomment-1295305765
The merge button has appeared for me. Anything more to do or should we merge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on pull request #1099: SOLR-15733: Separate out a solrj-streaming module
Posted by GitBox <gi...@apache.org>.
risdenk commented on PR #1099:
URL: https://github.com/apache/solr/pull/1099#issuecomment-1295074740
Added a note to solrj refguide for solrj-streaming.
```
git grep -F hsql | grep -Fv -e 'solr/solrj-streaming'
NOTICE.txt:HSQL Database (HSQLDB): http://hsqldb.org/
NOTICE.txt:License: http://hsqldb.org/web/hsqlLicense.html
NOTICE.txt:For work added by the HSQL Development Group (a.k.a. hsqldb_lic.txt):
solr/solrj/build.gradle: testRuntimeOnly "org.hsqldb:hsqldb" // runtime because via JDBC reflection
versions.lock:org.hsqldb:hsqldb:2.4.0 (1 constraints: 08050136)
versions.props:org.hsqldb:hsqldb=2.4.0
```
hsqldb does not look to be used in solr/solrj anymore so will remove and run tests.
need to check on sql module still.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on pull request #1099: SOLR-15733: Separate out a solrj-streaming module
Posted by GitBox <gi...@apache.org>.
risdenk commented on PR #1099:
URL: https://github.com/apache/solr/pull/1099#issuecomment-1295084688
removed hsqldb and sql module from solrj core. both solrj core and solrj streaming tests pass. Rerunning the whole test suite now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] joel-bernstein commented on pull request #1099: SOLR-15733: Separate out a solrj-streaming module
Posted by GitBox <gi...@apache.org>.
joel-bernstein commented on PR #1099:
URL: https://github.com/apache/solr/pull/1099#issuecomment-1294129147
2FA is enabled on github.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on a diff in pull request #1099: SOLR-15733: Migrate streaming
Posted by GitBox <gi...@apache.org>.
risdenk commented on code in PR #1099:
URL: https://github.com/apache/solr/pull/1099#discussion_r1002091268
##########
solr/solrj-streaming/build.gradle:
##########
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+apply plugin: 'java-library'
+
+description = 'Solrj-Streaming - SolrJ requiring Streaming Expressions'
+
+dependencies {
+
+
+ implementation project(':solr:solrj')
+
+ // declare dependencies we use even though already declared by solrj-core
+ implementation 'org.slf4j:slf4j-api'
+ implementation 'org.apache.httpcomponents:httpclient'
+ implementation 'org.apache.httpcomponents:httpcore'
+ implementation 'org.apache.commons:commons-math3'
+
+ testImplementation project(':solr:test-framework')
+ testImplementation project(':solr:core')
+
+ testImplementation 'junit:junit'
+ testImplementation 'commons-io:commons-io'
+ testImplementation 'com.google.guava:guava'
+ testImplementation project(':solr:solrj-zookeeper')
+
+ permitTestUsedUndeclared project(':solr:solrj-zookeeper') // duh!
+
+ testImplementation('org.apache.zookeeper:zookeeper', {
+ exclude group: "org.apache.yetus", module: "audience-annotations"
+ })
+
+ testRuntimeOnly project(':solr:modules:sql')
Review Comment:
Why is this needed? there are classes in solr/modules/sql that somehow are needed in these tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] joel-bernstein merged pull request #1099: SOLR-15733: Separate out a solrj-streaming module
Posted by GitBox <gi...@apache.org>.
joel-bernstein merged PR #1099:
URL: https://github.com/apache/solr/pull/1099
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] joel-bernstein commented on a diff in pull request #1099: SOLR-15733: Migrate streaming
Posted by GitBox <gi...@apache.org>.
joel-bernstein commented on code in PR #1099:
URL: https://github.com/apache/solr/pull/1099#discussion_r1002114271
##########
solr/solrj-streaming/build.gradle:
##########
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+apply plugin: 'java-library'
+
+description = 'Solrj-Streaming - SolrJ requiring Streaming Expressions'
+
+dependencies {
+
+
+ implementation project(':solr:solrj')
+
+ // declare dependencies we use even though already declared by solrj-core
+ implementation 'org.slf4j:slf4j-api'
+ implementation 'org.apache.httpcomponents:httpclient'
+ implementation 'org.apache.httpcomponents:httpcore'
+ implementation 'org.apache.commons:commons-math3'
+
+ testImplementation project(':solr:test-framework')
+ testImplementation project(':solr:core')
+
+ testImplementation 'junit:junit'
+ testImplementation 'commons-io:commons-io'
+ testImplementation 'com.google.guava:guava'
+ testImplementation project(':solr:solrj-zookeeper')
+
+ permitTestUsedUndeclared project(':solr:solrj-zookeeper') // duh!
+
+ testImplementation('org.apache.zookeeper:zookeeper', {
+ exclude group: "org.apache.yetus", module: "audience-annotations"
+ })
+
+ testRuntimeOnly project(':solr:modules:sql')
Review Comment:
The SQL handler is exercised by the JDBCStream I believe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on pull request #1099: SOLR-15733: Migrate streaming
Posted by GitBox <gi...@apache.org>.
risdenk commented on PR #1099:
URL: https://github.com/apache/solr/pull/1099#issuecomment-1292371294
FWIW on your branch ran into when running `./gradlew check -x test -Pvalidation.errorprone=true`
```
* What went wrong:
Execution failed for task ':solr:solrj-streaming:analyzeTestClassesDependencies'.
> Dependency analysis found issues.
usedUndeclaredArtifacts
- com.carrotsearch.randomizedtesting:randomizedtesting-runner:2.8.1@jar
- org.apache.lucene:lucene-test-framework:9.4.0@jar
- org.apache.solr:solrj-streaming:10.0.0-SNAPSHOT@
unusedDeclaredArtifacts
- com.google.guava:guava:31.1-jre@jar
- commons-io:commons-io:2.11.0@jar
- org.apache.zookeeper:zookeeper:3.8.0@jar
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on pull request #1099: SOLR-15733: Migrate streaming
Posted by GitBox <gi...@apache.org>.
risdenk commented on PR #1099:
URL: https://github.com/apache/solr/pull/1099#issuecomment-1292389342
@joel-bernstein I merged main, fixed the dependency issues, and a ref guide link. `./gradlew check -x test -Pvalidation.errorprone=true` now passes. I didn't run any tests yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org