[GitHub] [iceberg] RussellSpitzer commented on a diff in pull request #7933: Core: Abort file groups should be under same lock as committerService

["RussellSpitzer (via GitHub)" <gi...@apache.org>]

RussellSpitzer commented on code in PR #7933:
URL: https://github.com/apache/iceberg/pull/7933#discussion_r1248305559


##########
core/src/main/java/org/apache/iceberg/actions/BaseCommitService.java:
##########
@@ -169,7 +169,11 @@ public void close() {
 
     if (!completedRewrites.isEmpty() && timeout) {
       LOG.error("Attempting to cleanup uncommitted file groups");
-      completedRewrites.forEach(this::abortFileGroup);
+      synchronized (completedRewrites) {
+        while (!completedRewrites.isEmpty()) {

Review Comment:
   The issue is we could leave the synchronized block and then touch completedRewrites? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org