You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@rya.apache.org by pujav65 <gi...@git.apache.org> on 2016/07/21 18:13:06 UTC
[GitHub] incubator-rya pull request #59: Adding a dynamo db backend for Rya
GitHub user pujav65 opened a pull request:
https://github.com/apache/incubator-rya/pull/59
Adding a dynamo db backend for Rya
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pujav65/incubator-rya feature/dynamodb
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-rya/pull/59.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #59
----
commit 40ad4df99c04b30bbd81dd458fac5232d709545e
Author: pujav65 <pu...@gmail.com>
Date: 2016-06-23T15:59:05Z
initial commit
commit fbc13162654002687cad02b68b6eed38490ff634
Author: pujav65 <pu...@gmail.com>
Date: 2016-06-23T19:22:23Z
interim checkin
commit e30b29d0f98094cbda12c622a96581f38c337654
Author: pujav65 <pu...@gmail.com>
Date: 2016-06-24T02:45:24Z
initial implementation
commit cfeeac91907f2ebc60e0b04a7cb70d84b585af5b
Author: pujav65 <pu...@gmail.com>
Date: 2016-07-08T12:30:25Z
adding tests and mock support
commit 353f992bc852cd1f38513f8fa1d58e599521f87b
Author: pujav65 <pu...@gmail.com>
Date: 2016-06-23T15:59:05Z
initial commit of dynamo db backend,
adding tests and mock support
commit 8303548b8da35eefc28c65d49a1d64bf377b36d2
Author: pujav65 <pu...@gmail.com>
Date: 2016-07-21T17:54:23Z
fixing merge
commit c0fdfcea91b757d36f650a90d935abd1f98e5b9f
Author: pujav65 <pu...@gmail.com>
Date: 2016-07-21T18:11:59Z
merging in develop
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya issue #59: Adding a dynamo db backend for Rya
Posted by isper3at <gi...@git.apache.org>.
Github user isper3at commented on the issue:
https://github.com/apache/incubator-rya/pull/59
can you squash?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya pull request #59: Adding a dynamo db backend for Rya
Posted by DLotts <gi...@git.apache.org>.
Github user DLotts commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/59#discussion_r73240715
--- Diff: dao/dynamodb.rya/src/main/java/mvm/rya/dynamodb/dao/DynamoRdfConfiguration.java ---
@@ -0,0 +1,83 @@
+package mvm.rya.dynamodb.dao;
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.hadoop.conf.Configuration;
+
+import mvm.rya.api.RdfCloudTripleStoreConfiguration;
+
+public class DynamoRdfConfiguration extends RdfCloudTripleStoreConfiguration{
+
+ public static final String USE_MOCK = ".useMockInstance";
+ public static final String AWS_USER = "rya.aws.user";
+ public static final String AWS_SECRET_KEY = "rya.aws.secret.key";
+ public static final String AWS_ENDPOINT = "rya.aws.endpoint";
+ public static final String DYNAMO_TABLE_NAME = "rya.dynamo.tablename";
+
+ public DynamoRdfConfiguration(Configuration dynamoRdfConfiguration) {
+ super(dynamoRdfConfiguration);
+ }
+
+ public boolean useMockInstance() {
+ return getBoolean(USE_MOCK, false);
+ }
+
+
+ public DynamoRdfConfiguration(){
+ super();
+ }
+
+ public String getAWSUserName(){
+ return super.get(AWS_USER, "FakeUser");
+ }
+
+ public void setAWSUserName(String username){
+ super.set(AWS_USER, username);
+ }
+
+ public void setAWSSecretKey(String key){
+ super.set(AWS_SECRET_KEY, key);
+ }
+
+ public void setAWSEndPoint(String endpoint){
+ super.set(AWS_ENDPOINT, endpoint);
+ }
+
+ public void setDynamoTablename(String name){
+ super.set(DYNAMO_TABLE_NAME, name);
+ }
+ public String getTableName(){
--- End diff --
Using a config key for the table name is deprecated with RYA-81 / RYA-112. See note above.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya pull request #59: Adding a dynamo db backend for Rya
Posted by pujav65 <gi...@git.apache.org>.
Github user pujav65 closed the pull request at:
https://github.com/apache/incubator-rya/pull/59
---
[GitHub] incubator-rya pull request #59: Adding a dynamo db backend for Rya
Posted by pujav65 <gi...@git.apache.org>.
Github user pujav65 commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/59#discussion_r73537084
--- Diff: dao/dynamodb.rya/src/main/java/mvm/rya/dynamodb/dao/DynamoRdfConfiguration.java ---
@@ -0,0 +1,83 @@
+package mvm.rya.dynamodb.dao;
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.hadoop.conf.Configuration;
+
+import mvm.rya.api.RdfCloudTripleStoreConfiguration;
+
+public class DynamoRdfConfiguration extends RdfCloudTripleStoreConfiguration{
+
+ public static final String USE_MOCK = ".useMockInstance";
+ public static final String AWS_USER = "rya.aws.user";
+ public static final String AWS_SECRET_KEY = "rya.aws.secret.key";
+ public static final String AWS_ENDPOINT = "rya.aws.endpoint";
+ public static final String DYNAMO_TABLE_NAME = "rya.dynamo.tablename";
--- End diff --
The table name here is kind of synonymous with the mongo collection or the rya table prefix in accumulo.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya pull request #59: Adding a dynamo db backend for Rya
Posted by isper3at <gi...@git.apache.org>.
Github user isper3at commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/59#discussion_r73231384
--- Diff: dao/dynamodb.rya/src/main/java/mvm/rya/dynamodb/iter/RyaItemCollectionIterator.java ---
@@ -0,0 +1,108 @@
+package mvm.rya.dynamodb.iter;
+/*
--- End diff --
duplicated licenses
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya issue #59: Adding a dynamo db backend for Rya
Posted by amihalik <gi...@git.apache.org>.
Github user amihalik commented on the issue:
https://github.com/apache/incubator-rya/pull/59
Please change this to point to the apache master branch. Also, what's the status of this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya issue #59: Adding a dynamo db backend for Rya
Posted by isper3at <gi...@git.apache.org>.
Github user isper3at commented on the issue:
https://github.com/apache/incubator-rya/pull/59
can you add a jira ticket for this and a description on the pull request for why we're adding dynamoDB support?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya pull request #59: Adding a dynamo db backend for Rya
Posted by DLotts <gi...@git.apache.org>.
Github user DLotts commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/59#discussion_r73240362
--- Diff: dao/dynamodb.rya/src/main/java/mvm/rya/dynamodb/dao/DynamoRdfConfiguration.java ---
@@ -0,0 +1,83 @@
+package mvm.rya.dynamodb.dao;
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.hadoop.conf.Configuration;
+
+import mvm.rya.api.RdfCloudTripleStoreConfiguration;
+
+public class DynamoRdfConfiguration extends RdfCloudTripleStoreConfiguration{
+
+ public static final String USE_MOCK = ".useMockInstance";
+ public static final String AWS_USER = "rya.aws.user";
+ public static final String AWS_SECRET_KEY = "rya.aws.secret.key";
+ public static final String AWS_ENDPOINT = "rya.aws.endpoint";
+ public static final String DYNAMO_TABLE_NAME = "rya.dynamo.tablename";
--- End diff --
Using a config key for the table name is deprecated with RYA-81 / RYA-112. Instead use getTableName() or getTableNameXXX where XXX distinguishes multiple tables. Declare it in the class that primarily access the table, for example: the DAO. Most implementations return table prefix (AKA Rya Instance) followed by a static string. This applies to secondary indexes and may not apply to SPO, POS and OSP.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya pull request #59: Adding a dynamo db backend for Rya
Posted by DLotts <gi...@git.apache.org>.
Github user DLotts commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/59#discussion_r73240644
--- Diff: dao/dynamodb.rya/src/main/java/mvm/rya/dynamodb/dao/DynamoRdfConfiguration.java ---
@@ -0,0 +1,83 @@
+package mvm.rya.dynamodb.dao;
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.hadoop.conf.Configuration;
+
+import mvm.rya.api.RdfCloudTripleStoreConfiguration;
+
+public class DynamoRdfConfiguration extends RdfCloudTripleStoreConfiguration{
+
+ public static final String USE_MOCK = ".useMockInstance";
+ public static final String AWS_USER = "rya.aws.user";
+ public static final String AWS_SECRET_KEY = "rya.aws.secret.key";
+ public static final String AWS_ENDPOINT = "rya.aws.endpoint";
+ public static final String DYNAMO_TABLE_NAME = "rya.dynamo.tablename";
+
+ public DynamoRdfConfiguration(Configuration dynamoRdfConfiguration) {
+ super(dynamoRdfConfiguration);
+ }
+
+ public boolean useMockInstance() {
+ return getBoolean(USE_MOCK, false);
+ }
+
+
+ public DynamoRdfConfiguration(){
+ super();
+ }
+
+ public String getAWSUserName(){
+ return super.get(AWS_USER, "FakeUser");
+ }
+
+ public void setAWSUserName(String username){
+ super.set(AWS_USER, username);
+ }
+
+ public void setAWSSecretKey(String key){
+ super.set(AWS_SECRET_KEY, key);
+ }
+
+ public void setAWSEndPoint(String endpoint){
+ super.set(AWS_ENDPOINT, endpoint);
+ }
+
+ public void setDynamoTablename(String name){
--- End diff --
Using a config key for the table name is deprecated with RYA-81 / RYA-112. See note above.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---