You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/27 19:01:52 UTC
[GitHub] [airflow] kaxil opened a new pull request #10613: Revert Clean up DAG serializations based on last_updated (#7424)
kaxil opened a new pull request #10613:
URL: https://github.com/apache/airflow/pull/10613
This PR reverts the behavior of https://github.com/apache/airflow/pull/7424
We don't want to delete dags if they are stable. Serialized DAGs are now refreshed based on `min_serialized_dag_fetch_interval` & `min_serialized_dag_update_interval`
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] sanjayhallan commented on pull request #10613: Revert Clean up DAG serializations based on last_updated (#7424)
Posted by GitBox <gi...@apache.org>.
sanjayhallan commented on pull request #10613:
URL: https://github.com/apache/airflow/pull/10613#issuecomment-805766205
this revert misses the entire point of what the original PR was doing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #10613: Revert Clean up DAG serializations based on last_updated (#7424)
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #10613:
URL: https://github.com/apache/airflow/pull/10613
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #10613: Revert Clean up DAG serializations based on last_updated (#7424)
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #10613:
URL: https://github.com/apache/airflow/pull/10613#issuecomment-805783510
> this revert misses the entire point of what the original PR was doing
The original PR caused several issues when the DAGs were deleted prematurely. This will be done in a better way in 2.0.3 / 2.1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org