You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by te...@apache.org on 2023/02/14 14:04:31 UTC
[pulsar] branch master updated: [cleanup][broker] Cleanup finalPosition null-check in asyncFindPosition (#19497)
This is an automated email from the ASF dual-hosted git repository.
technoboy pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new 8639585bfe5 [cleanup][broker] Cleanup finalPosition null-check in asyncFindPosition (#19497)
8639585bfe5 is described below
commit 8639585bfe50720f6791fa512704100ff0541d48
Author: houxiaoyu <ho...@apache.org>
AuthorDate: Tue Feb 14 22:04:23 2023 +0800
[cleanup][broker] Cleanup finalPosition null-check in asyncFindPosition (#19497)
---
.../java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java b/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java
index f6c9fb3bfd8..d541f60a0d3 100644
--- a/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java
+++ b/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java
@@ -1779,7 +1779,7 @@ public class ManagedLedgerImpl implements ManagedLedger, CreateCallback {
@Override
public CompletableFuture<Position> asyncFindPosition(Predicate<Entry> predicate) {
- CompletableFuture<Position> future = new CompletableFuture();
+ CompletableFuture<Position> future = new CompletableFuture<>();
Long firstLedgerId = ledgers.firstKey();
final PositionImpl startPosition = firstLedgerId == null ? null : new PositionImpl(firstLedgerId, 0);
if (startPosition == null) {
@@ -1792,11 +1792,6 @@ public class ManagedLedgerImpl implements ManagedLedger, CreateCallback {
final Position finalPosition;
if (position == null) {
finalPosition = startPosition;
- if (finalPosition == null) {
- log.warn("[{}] Unable to find position for predicate {}.", name, predicate);
- future.complete(null);
- return;
- }
log.info("[{}] Unable to find position for predicate {}. Use the first position {} instead.", name,
predicate, startPosition);
} else {